Mode base sdk implementation #27504
Merged
Mode base sdk implementation #27504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with and internally managed variable.
…ypass the limitations of the the current zap generation.
…ibutes to ensure that not RAM memory is allocated for these attibutes.
…ibute accessability following management of attributes by the mode base instance.
…r to the all-clusters-app example.
… ModeBase attribute type infos. Updated documentation.
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo and
chshu
plauric
reviewed
Jul 20, 2023
cliffamzn
reviewed
Jul 20, 2023
cliffamzn
reviewed
Jul 20, 2023
plauric
reviewed
Jul 20, 2023
examples/all-clusters-app/all-clusters-common/src/rvc-modes.cpp
Outdated
Show resolved
Hide resolved
tcarmelveilleux
approved these changes
Jul 20, 2023
bzbarsky-apple
approved these changes
Jul 20, 2023
plauric
reviewed
Jul 20, 2023
examples/all-clusters-app/all-clusters-common/src/rvc-modes.cpp
Outdated
Show resolved
Hide resolved
jmartinez-silabs
approved these changes
Jul 21, 2023
Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the ModeBase cluster.
This PR follows from the draft PR 26447. It reimplements that PR due to the number of changes in the spec. However, most comments in PR 26447 are still relevant and have been addressed in this PR.
Examples of all the ModeBase aliases (DishwasherMode, LaundyrWasherMode, RefrigeratorAndTemperatureControlledCabinetMode, RvcRunMode, RvcCleanMode) have been added to the all-clusters-app.