Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] replace the use of EMBER_AF_PLUGIN_MODE_BASE with a BUILD.gn variable #28155

Closed
hicklin opened this issue Jul 21, 2023 · 3 comments
Closed

[Feature] replace the use of EMBER_AF_PLUGIN_MODE_BASE with a BUILD.gn variable #28155

hicklin opened this issue Jul 21, 2023 · 3 comments
Assignees
@hicklin
Labels
feature request feature work needs triage

Comments

@hicklin
Copy link
Contributor

hicklin commented Jul 21, 2023

Feature description

Remove #define EMBER_AF_PLUGIN_MODE_BASE form the all-clusters-app CHIPProjectAppConfig.h and find a solution using the BUILD.gn.

Update the Mode Base readme.

Platform

all

Platform Version(s)

No response

Anything else?

No response
@hicklin hicklin self-assigned this Jul 21, 2023
@hicklin hicklin mentioned this issue Jul 21, 2023
Merged
@hicklin
Copy link
Contributor Author

hicklin commented Jul 21, 2023

See the conversation here.

@bzbarsky-apple
Copy link
Contributor

Better conversation link that will not break: #27504

@hicklin
Copy link
Contributor Author

hicklin commented Jul 25, 2023

Should I close this issue given that there are no strong opinions against the current implementation?

If matter continues to utilise zap and generated code, the best way that I think this can be implemented is to have the code regen script define EMBER_AF_PLUGIN_MODE_BASE with all the others in gen_config.h once, when at least one ModeBase derived cluster is enabled.

@hicklin hicklin closed this as completed Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hicklin hicklin

Labels
feature request feature work needs triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hicklin @bzbarsky-apple