-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update concentration measurement cluster revisions to 3. #27396
Merged
mergify
merged 1 commit into
project-chip:master
from
bzbarsky-apple:concentration-measurement-cluster-revision
Jun 22, 2023
Merged
Update concentration measurement cluster revisions to 3. #27396
mergify
merged 1 commit into
project-chip:master
from
bzbarsky-apple:concentration-measurement-cluster-revision
Jun 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bzbarsky-apple
commented
Jun 21, 2023
•
edited
Loading
edited
- Fixes [TC-CMOCONC-1.1] ClusterRevision value missmatch in Carbon Monoxide Concentration Measurement Cluster #27364
- Fixes [TC-CDOCONC-1.1] ClusterRevision value has to be updated in Carbon Dioxide Concentration Measurement Cluster as per spec. #27367
- Fixes [TC-NDOCONC-1.1] ClusterRevision value has to be updated in Nitrogen Dioxide Concentration Measurement Cluster as per spec. #27368
- Fixes [TC-OZCONC-1.1] ClusterRevision value has to be updated in Ozone Concentration Measurement Cluster as per spec. #27369
- Fixes [TC-PMICONC-1.1] ClusterRevision value has to be updated in PM2.5 Concentration Measurement Cluster as per spec. #27370
- Fixes [TC-FLDCONC-1.1] ClusterRevision value has to be updated in Formaldehyde Concentration Measurement Cluster as per spec. #27371
- Fixes [TC-PMHCONC-1.1] ClusterRevision value has to be updated in PM1 Concentration Measurement Cluster as per spec. #27372
- Fixes [TC-PMKCONC-1.1] ClusterRevision value has to be updated in PM10 Concentration Measurement Cluster as per spec. #27373
- Fixes [TC-TVOCCONC-1.1] ClusterRevision value has to be updated in Total Volatile Organic Compounds Concentration Measurement Cluster as per spec. #27375
- Fixes [TC-RNCONC-1.1] ClusterRevision value has to be updated in Radon Concentration Measurement Cluster as per spec. #27376
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock,
kkasperczyk-no,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
June 21, 2023 18:54
pullapprove
bot
requested review from
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yunhanw-google
June 21, 2023 18:54
bzbarsky-apple
force-pushed
the
concentration-measurement-cluster-revision
branch
from
June 21, 2023 18:55
dc7473b
to
46fe824
Compare
PR #27396: Size comparison from 3706e06 to 46fe824 Increases (5 builds for esp32, nrfconnect, psoc6, telink)
Decreases (14 builds for bl602, cc32xx, k32w, nrfconnect, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
woody-apple
approved these changes
Jun 21, 2023
* Fixes project-chip#27364 * Fixes project-chip#27367 * Fixes project-chip#27368 * Fixes project-chip#27369 * Fixes project-chip#27370 * Fixes project-chip#27371 * Fixes project-chip#27372 * Fixes project-chip#27373 * Fixes project-chip#27375 * Fixes project-chip#27376
bzbarsky-apple
force-pushed
the
concentration-measurement-cluster-revision
branch
from
June 21, 2023 22:32
46fe824
to
81b447f
Compare
PR #27396: Size comparison from 9cf7d36 to 81b447f Increases (13 builds for bl602, cc32xx, esp32, psoc6, qpg, telink)
Decreases (7 builds for bl702, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.