Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TC-CMOCONC-1.1] ClusterRevision value missmatch in Carbon Monoxide Concentration Measurement Cluster #27364

Closed
Survensa opened this issue Jun 21, 2023 · 1 comment · Fixed by #27396
Closed

[TC-CMOCONC-1.1] ClusterRevision value missmatch in Carbon Monoxide Concentration Measurement Cluster #27364

Survensa opened this issue Jun 21, 2023 · 1 comment · Fixed by #27396
Labels
bug Something isn't working cert blocker needs triage Spec XML align SDK XML does not match the spec (including naming, etc)

Comments

@Survensa
Copy link

Survensa commented Jun 21, 2023 •
edited
Loading

Problem:
As per Spec, ClusterRevision attribute value should be 3 but currently getting ClusterRevision value as 1 in SDK .

Expected behavior: ClusterRevision value as 3.

Actual behavior : ClusterRevision value as 1.

Steps to reproduce: 2

Command: ./chip-tool carbonmonoxideconcentrationmeasurement read cluster-revision 1 1

System configuration:
Chip-tool - RPI-4, 8GB RAM
DUT - RPI, Version- RPI-4, 8GB RAM
Platform : Onnetwork
Commit-ID: f5c4621
Dut application: all-clusters-app

Spec Reference: https://github.com/CHIP-Specifications/connectedhomeip-spec/blob/master/src/app_clusters/ConcentrationMeasurement.adoc#ref_ConcentrationMeasurementRevisionHistory

Log: TC-CMOCONC-1.1.txt
@Survensa Survensa added bug Something isn't working needs triage labels Jun 21, 2023
@bzbarsky-apple bzbarsky-apple added cert blocker Spec XML align SDK XML does not match the spec (including naming, etc) labels Jun 21, 2023
@github-project-automation github-project-automation bot moved this to Open Cert Blockers in [Certification] Blockers Jun 21, 2023
@bzbarsky-apple
Copy link
Contributor

Looks like the cluster XML is missing the ClusterRevision bits, actually...

bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Jun 21, 2023
@bzbarsky-apple
Update concentration measurement cluster revisions to 3.
dc7473b 
Fixes project-chip#27364
@bzbarsky-apple bzbarsky-apple mentioned this issue Jun 21, 2023
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Jun 21, 2023
@bzbarsky-apple
Update concentration measurement cluster revisions to 3.
46fe824 
* Fixes project-chip#27364
* Fixes project-chip#27367
* Fixes project-chip#27368
* Fixes project-chip#27369
* Fixes project-chip#27370
* Fixes project-chip#27371
* Fixes project-chip#27372
* Fixes project-chip#27373
* Fixes project-chip#27375
* Fixes project-chip#27376
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Jun 21, 2023
@bzbarsky-apple
Update concentration measurement cluster revisions to 3.
81b447f 
* Fixes project-chip#27364
* Fixes project-chip#27367
* Fixes project-chip#27368
* Fixes project-chip#27369
* Fixes project-chip#27370
* Fixes project-chip#27371
* Fixes project-chip#27372
* Fixes project-chip#27373
* Fixes project-chip#27375
* Fixes project-chip#27376
@mergify mergify bot closed this as completed in #27396 Jun 22, 2023
mergify bot pushed a commit that referenced this issue Jun 22, 2023
@bzbarsky-apple
Update concentration measurement cluster revisions to 3. (#27396)
e149bb7 
* Fixes #27364
* Fixes #27367
* Fixes #27368
* Fixes #27369
* Fixes #27370
* Fixes #27371
* Fixes #27372
* Fixes #27373
* Fixes #27375
* Fixes #27376
@github-project-automation github-project-automation bot moved this from Open Cert Blockers to Complete in [Certification] Blockers Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working cert blocker needs triage Spec XML align SDK XML does not match the spec (including naming, etc)
Projects
[Certification] Blockers
Archived in project
[Enhancements] Spec/XML Alignment
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update concentration measurement cluster revisions to 3. bzbarsky-apple/connectedhomeip
2 participants
@bzbarsky-apple @Survensa