Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bootstrap.sh more friendly to other shells. #27392

Merged
merged 8 commits into from
Jun 21, 2023
Prev Previous commit
Next Next commit
Restyle
andy31415 committed Jun 21, 2023
commit 321b2d39819a6b3de86eca4fa7f7429cd6bb94a2
6 changes: 3 additions & 3 deletions scripts/setup/bootstrap.sh
Original file line number Diff line number Diff line change
@@ -21,7 +21,7 @@ _install_additional_pip_requirements() {
# figure out additional pip install items
while [ $# -gt 0 ]; do
case $1 in
-p|--platform)
-p | --platform)
_SETUP_PLATFORM=$2
shift # argument
shift # value
@@ -36,10 +36,10 @@ _install_additional_pip_requirements() {
_OLD_IFS=$IFS
IFS=","
if [ -n "$ZSH_VERSION" ]; then
setopt sh_word_split
setopt sh_word_split
andy31415 marked this conversation as resolved.
Show resolved Hide resolved
fi

for platform in ${_SETUP_PLATFORM}; do
for platform in "$_SETUP_PLATFORM"; do
# Allow none as an alias of nothing extra installed (like -p none)
if [ "$platform" != "none" ]; then
echo "Installing pip requirements for $platform..."