Make bootstrap.sh more friendly to other shells. #27392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found some CI systems trying to use dash, and that does not seem to work at all due to it not understanding '<<<' or `[[`. Dash is still not ok because overall because arguments to `.` do not get passed along, however it would work as a default. Changes: - loop using IFS (and set sh_word_split for ZSH) - replaced `[[` tests with `[`
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock,
kkasperczyk-no and
ksperling-apple
pullapprove
bot
requested review from
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yufengwangca
woody-apple
approved these changes
Jun 21, 2023
|
PR #27392: Size comparison from a0397c2 to cb6f86c Decreases (3 builds for bl602, cc32xx, nrfconnect)
Full report (11 builds for bl602, bl702, cc32xx, mbed, nrfconnect, qpg)
|
bzbarsky-apple
approved these changes
Jun 21, 2023
|
PR #27392: Size comparison from a0397c2 to 6195292 Increases (1 build for bl602)
Decreases (6 builds for bl602, bl702, k32w, nrfconnect, qpg)
Full report (16 builds for bl602, bl702, cc32xx, k32w, linux, mbed, nrfconnect, qpg)
|
…score seems more common in docs
|
fast tracking: infra change not functionality, tested locally on various shells, CI validates builds. |
|
PR #27392: Size comparison from 9cf7d36 to e3c3880 Increases (11 builds for bl602, cc32xx, esp32, psoc6, qpg, telink)
Decreases (9 builds for bl702, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmartinez-silabs
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found some CI systems trying to use dash, and that does not seem to work at all due to it not understanding
<<<or[[.Dash is still not ok because overall because arguments to
. scripts/activate.shdo not get passed along, however it would work as a default invocation.Changes:
[[tests with[for platform in ${_SETUP_PLATFORM};and that breaks the script. I found no way to tell shellharden to not try to fix that. Still checking...