-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ESP32] Config option to enable background matter thread #27348
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubhamdp
changed the title
[ESP32] Config option to enable background matter thread
Draft: [ESP32] Config option to enable background matter thread
Jun 20, 2023
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kkasperczyk-no
June 20, 2023 15:22
pullapprove
bot
requested review from
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yufengwangca
June 20, 2023 15:22
PR #27348: Size comparison from 84e38ee to 2abac19 Increases (9 builds for bl602, bl702, esp32, psoc6)
Decreases (1 build for cc32xx)
Full report (41 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
bzbarsky-apple
approved these changes
Jun 20, 2023
PR #27348: Size comparison from 84e38ee to 6030c1d Increases above 0.2%:
Increases (18 builds for bl602, esp32, linux, telink)
Decreases (17 builds for bl702, cc32xx, linux, psoc6, qpg, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
woody-apple
approved these changes
Jun 20, 2023
wqx6
reviewed
Jun 21, 2023
shubhamdp
changed the title
Draft: [ESP32] Config option to enable background matter thread
[ESP32] Config option to enable background matter thread
Jun 21, 2023
wqx6
approved these changes
Jun 21, 2023
woody-apple
approved these changes
Jun 21, 2023
shubhamdp
force-pushed
the
esp32_bg_thread
branch
from
June 21, 2023 09:15
2abd44c
to
cc1ebec
Compare
PR #27348: Size comparison from 534b6d9 to cc1ebec Increases (8 builds for bl702, esp32, nrfconnect, psoc6, telink)
Decreases (13 builds for bl602, cc32xx, esp32, psoc6, telink)
Full report (46 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Jun 23, 2023
I forgot to add two more config option, one for TASK_STACK_SIZE and one for QUEUE_SIZE. I'll add a follow up PR now :-D |
shubhamdp
added a commit
to shubhamdp/connectedhomeip
that referenced
this pull request
Jun 24, 2023
I missed adding them in project-chip#27348
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We have support for background matter thread in SDK but not enabled for ESP32 platform.
Change Overview
Tests