Fix Chef build broken on nRFConnect(vscode docker) #27317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple and
lazarkov
pullapprove
bot
requested review from
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
|
@andy31415 / @kkasperczyk-no / @Damian-Nordic Can you help to review this PR? |
Damian-Nordic
approved these changes
Jun 19, 2023
|
PR #27317: Size comparison from f5c4621 to c512774 Increases (15 builds for bl702, cyw30739, nrfconnect, psoc6, qpg, telink)
Decreases (4 builds for cc32xx, esp32, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
reviewed
Jun 19, 2023
| @@ -110,6 +110,7 @@ ENV TELINK_ZEPHYR_BASE=/opt/telink/zephyrproject/zephyr | |||
| ENV TELINK_ZEPHYR_SDK_DIR=/opt/telink/zephyr-sdk-0.15.2 | |||
| ENV TI_SYSCONFIG_ROOT=/opt/ti/sysconfig_1.13.0 | |||
| ENV ZEPHYR_BASE=/opt/NordicSemiconductor/nrfconnect/zephyr | |||
| ENV ZEPHYR_SDK_INSTALL_DIR=/opt/NordicSemiconductor/nRF5_tools/zephyr-sdk-0.16.0 | |||
There was a problem hiding this comment.
This changes the vscode image in an incompatible way, so it needs a version file update.
There was a problem hiding this comment.
@andy31415 Actually the chip-build-vscode image already imported latest chip-build-nrf-platform image (refer to Dockerfile), so the chip-build-vscode has the latest version ZEPHYR SDK installed.
FROM connectedhomeip/chip-build-nrf-platform:${VERSION} AS nrf
...
COPY --from=nrf /opt/NordicSemiconductor/nRF5_tools /opt/NordicSemiconductor/nRF5_tools
There was a problem hiding this comment.
BTW, the Docker -efr32 build failure is caused by issue #27362 and is nothing to do with current PR.
There was a problem hiding this comment.
@woody-apple this was not resolved - any changes in docker files should have updated the version. This is obvious here since this "fixes chef" meaning after the update something changed...but you cannot do that without updating the version.
There was a problem hiding this comment.
My point would be: even if file content is not changed, the env values are part of the image, so the image is changed. If the image changes, the version has to be bumped up, that way if I say "I am using version 0.7.17" I know exactly what I have without saying "pulled today" or "pulled 1 week ago".
|
PR #27317: Size comparison from f99a71a to 3cfe81a Increases (10 builds for bl702, psoc6, telink)
Decreases (6 builds for esp32, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
PR #27317: Size comparison from 9a5b909 to 79cecf8 Increases (10 builds for bl602, bl702, esp32, qpg, telink)
Decreases (5 builds for bl602, cc32xx, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
woody-apple
approved these changes
Jun 20, 2023
Chef build broken on nRFConnect on dokcer image connectedhomeip/chip-build-vscode:0.7.16 The root cause is lacking of env `ZEPHYR_SDK_INSTALL_DIR`
|
PR #27317: Size comparison from d7407b2 to 130ce8b Increases (9 builds for bl702, esp32, psoc6, telink)
Decreases (8 builds for cc32xx, esp32, psoc6, telink)
Full report (46 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
woody-apple
approved these changes
Jun 21, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chef build broken on nRFConnect on dokcer image connectedhomeip/chip-build-vscode:0.7.16 The root cause is lacking of env
ZEPHYR_SDK_INSTALL_DIRFix #27316