-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose the Basic Information VID/PID as part of attestation results. #27282
Merged
bzbarsky-apple
merged 2 commits into
project-chip:master
from
bzbarsky-apple:basic-info-attestation
Jun 16, 2023
Merged
Expose the Basic Information VID/PID as part of attestation results. #27282
bzbarsky-apple
merged 2 commits into
project-chip:master
from
bzbarsky-apple:basic-info-attestation
Jun 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets consumers see what actual VID/PID was checked against the certification declaration during attestation. While the VID is available from the certification declaration (assuming attestation passed), without this change there is no way to recover the PID short of reading the Basic Information cluster and hoping that it's not malicious and returns the same value as the one that was previously validated against the certification declaration. Removes declaration for an un-implemented constructor of AttestationDeviceInfo.
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
June 15, 2023 19:22
pullapprove
bot
requested review from
sharadb-amazon,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
June 15, 2023 19:22
anush-apple
reviewed
Jun 15, 2023
anush-apple
reviewed
Jun 15, 2023
anush-apple
approved these changes
Jun 15, 2023
carol-apple
reviewed
Jun 15, 2023
carol-apple
reviewed
Jun 15, 2023
carol-apple
reviewed
Jun 15, 2023
carol-apple
reviewed
Jun 15, 2023
src/credentials/attestation_verifier/DeviceAttestationVerifier.h
Outdated
Show resolved
Hide resolved
tcarmelveilleux
approved these changes
Jun 15, 2023
PR #27282: Size comparison from eef9529 to 4f31bed Increases (9 builds for bl602, bl702, cc32xx, cyw30739, linux, psoc6)
Decreases (3 builds for cyw30739, psoc6)
Full report (39 builds for bl602, bl702, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
carol-apple
approved these changes
Jun 15, 2023
PR #27282: Size comparison from eef9529 to e5dd47e Increases (13 builds for bl602, cc32xx, cyw30739, linux, nrfconnect, psoc6, telink)
Decreases (10 builds for bl702, esp32, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets consumers see what actual VID/PID was checked against the certification declaration during attestation. While the VID is available from the certification declaration (assuming attestation passed), without this change there is no way to recover the PID short of reading the Basic Information cluster and hoping that it's not malicious and returns the same value as the one that was previously validated against the certification declaration.
Removes declaration for an un-implemented constructor of AttestationDeviceInfo.