Skip to content

Commit

Permalink
Address review comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
bzbarsky-apple committed Jun 15, 2023
1 parent 4f31bed commit e5dd47e
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -317,15 +317,15 @@ class DeviceAttestationVerifier
}
}

VendorId BasicInformationVendorId() const { return mBasicInformationVendorId; }
uint16_t BasicInformationVendorId() const { return mBasicInformationVendorId; }

uint16_t BasicInformationProductId() const { return mBasicInformationProductId; }

private:
Platform::ScopedMemoryBufferWithSize<uint8_t> mPaiDerBuffer;
Platform::ScopedMemoryBufferWithSize<uint8_t> mDacDerBuffer;
Platform::ScopedMemoryBufferWithSize<uint8_t> mCdBuffer;
VendorId mBasicInformationVendorId;
uint16_t mBasicInformationVendorId;
uint16_t mBasicInformationProductId;
};

Expand Down
12 changes: 6 additions & 6 deletions src/darwin/Framework/CHIP/MTRDeviceAttestationDelegate.h
Original file line number Diff line number Diff line change
Expand Up @@ -28,26 +28,26 @@ NS_ASSUME_NONNULL_BEGIN
+ (instancetype)new NS_UNAVAILABLE;

/**
* The vendor ID from the Device Attestation Certificate. May be nil only if attestation was unsucessful.
* The vendor ID from the Device Attestation Certificate. May be nil only if attestation was unsuccessful.
*/
@property (nonatomic, readonly, nullable) NSNumber * vendorID API_AVAILABLE(ios(16.4), macos(13.3), watchos(9.4), tvos(16.4));

/**
* The product ID from the Device Attestation Certificate. May be nil only if attestation was unsucessful.
* The product ID from the Device Attestation Certificate. May be nil only if attestation was unsuccessful.
*/
@property (nonatomic, readonly, nullable) NSNumber * productID API_AVAILABLE(ios(16.4), macos(13.3), watchos(9.4), tvos(16.4));

/**
* The vendor ID value from the device's Basic Information cluster that was used
* for device attestation. If attestation succeds, this must match the vendor
* for device attestation. If attestation succeeds, this must match the vendor
* ID from the certification declaration.
*/
@property (nonatomic, readonly) NSNumber * basicInformationVendorID MTR_NEWLY_AVAILABLE;

/**
* The product ID value from the device's Basic Information cluster that was used
* for device attestation. If attestation succeds, this must match one of the
* product IDs from the certification declaration.
* The product ID value from the device's Basic Information cluster that was
* used for device attestation. If attestation succeeds, this must match one of
* the product IDs from the certification declaration.
*/
@property (nonatomic, readonly) NSNumber * basicInformationProductID MTR_NEWLY_AVAILABLE;

Expand Down

0 comments on commit e5dd47e

Please sign in to comment.