-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix thread names for k32w's DiagnosticDataProvider. (v1.1 cherry-pick of PR 26892) #26950
Merged
andy31415
merged 1 commit into
project-chip:v1.1-branch
from
bzbarsky-apple:v1.1-branch
May 30, 2023
Merged
Fix thread names for k32w's DiagnosticDataProvider. (v1.1 cherry-pick of PR 26892) #26950
andy31415
merged 1 commit into
project-chip:v1.1-branch
from
bzbarsky-apple:v1.1-branch
May 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old code was copying in N-1 chars, then creating a string of length N from them, so ending up with a random byte in the string, which could lead to the string not being valid UTF-8. Fixes project-chip#26891
PR #26950: Size comparison from 65b6ed4 to 97cd5fa Increases (9 builds for bl702, cc13x2_26x2, k32w, psoc6, telink)
Decreases (16 builds for bl602, bl702, efr32, psoc6, telink)
Full report (62 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick of #26892 to the v1.1 branch.
The old code was copying in N-1 chars, then creating a string of length N from them, so ending up with a random byte in the string, which could lead to the string not being valid UTF-8.