Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix thread names for k32w's DiagnosticDataProvider. #26892

Merged
merged 1 commit into from
May 29, 2023
Merged

Fix thread names for k32w's DiagnosticDataProvider. #26892

merged 1 commit into from
May 29, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

The old code was copying in N-1 chars, then creating a string of length N from them, so ending up with a random byte in the string, which could lead to the string not being valid UTF-8.

Fixes #26891

@bzbarsky-apple
Fix thread names for k32w's DiagnosticDataProvider.
05716e8 
The old code was copying in N-1 chars, then creating a string of length N from
them, so ending up with a random byte in the string, which could lead to the
string not being valid UTF-8.

Fixes project-chip#26891
@github-actions
Copy link

github-actions bot commented May 26, 2023 •
edited
Loading

PR #26892: Size comparison from 8f16fe9 to 05716e8

Increases (12 builds for bl602, bl702, psoc6, qpg, telink)
platform target config section 8f16fe9 05716e8 change % change
bl602 lighting-app bl602+rpc .text 1067978 1067980 2 0.0
bl702 lighting-app bl702 .debug_info 44666451 44666452 1 0.0
.text 966824 966826 2 0.0
bl702+rpc .debug_info 49613627 49613628 1 0.0
.text 1040212 1040214 2 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 31376858 31376860 2 0.0
light cy8ckit_062s2_43012 .debug_info 25634974 25634975 1 0.0
qpg lighting-app qpg6105+debug (read/write) 1170744 1170752 8 0.0
.text 617844 617852 8 0.0
telink all-clusters-app tlsr9518adk80d text 689146 689148 2 0.0
contact-sensor-app tlsr9518adk80d text 583330 583334 4 0.0
pump-app tlsr9518adk80d text 589508 589510 2 0.0
pump-controller-app tlsr9518adk80d (read/write) 851288 851296 8 0.0
text 579624 579626 2 0.0
temperature-measurement-app tlsr9518adk80d text 575340 575342 2 0.0
window-covering tlsr9518adk80d text 595358 595360 2 0.0
Decreases (8 builds for bl602, efr32, esp32, telink)
platform target config section 8f16fe9 05716e8 change % change
bl602 lighting-app bl602 .text 1036624 1036622 -2 -0.0
efr32 lock-app BRD4161A+wf200 (read/write) 1068896 1068888 -8 -0.0
.text 892580 892572 -8 -0.0
esp32 all-clusters-app m5stack (read/write) 493018 493014 -4 -0.0
.flash.rodata 241356 241352 -4 -0.0
telink light-switch-app tlsr9518adk80d text 597964 597962 -2 -0.0
lighting-app-factory-data tlsr9518adk80d (read/write) 953768 953760 -8 -0.0
text 665168 665164 -4 -0.0
lighting-app-shell tlsr9518adk80d text 722680 722678 -2 -0.0
lock-app tlsr9518adk80d text 612002 612000 -2 -0.0
ota-requestor-app tlsr9518adk80d text 605266 605264 -2 -0.0
Full report (66 builds for bl602, bl702, cc13x2_26x2, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 8f16fe9 05716e8 change % change
bl602 lighting-app bl602 (read/write) 1356558 1356558 0 0.0
.bss 87886 87886 0 0.0
.data 9648 9648 0 0.0
.text 1036624 1036622 -2 -0.0
bl602+rpc (read/write) 1402834 1402834 0 0.0
.bss 95934 95934 0 0.0
.data 10040 10040 0 0.0
.text 1067978 1067980 2 0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1188335 1188335 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 67585 67585 0 0.0
.bss_psram 24656 24656 0 0.0
.comment 48 48 0 0.0
.data 3952 3952 0 0.0
.debug_abbrev 1555658 1555658 0 0.0
.debug_aranges 148432 148432 0 0.0
.debug_frame 546356 546356 0 0.0
.debug_info 44666451 44666452 1 0.0
.debug_line 5580063 5580063 0 0.0
.debug_loc 3803744 3803744 0 0.0
.debug_ranges 392424 392424 0 0.0
.debug_str 4311524 4311524 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 140 140 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 107232 107232 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 582494 582494 0 0.0
.symtab 175632 175632 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
966824 966826 2 0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1277155 1277155 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 75633 75633 0 0.0
.bss_psram 25056 25056 0 0.0
.comment 48 48 0 0.0
.data 4504 4504 0 0.0
.debug_abbrev 1714641 1714641 0 0.0
.debug_aranges 156720 156720 0 0.0
.debug_frame 574368 574368 0 0.0
.debug_info 49613627 49613628 1 0.0
.debug_line 5995980 5995980 0 0.0
.debug_loc 4006451 4006451 0 0.0
.debug_ranges 417784 417784 0 0.0
.debug_str 4737041 4737041 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 156 156 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121328 121328 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 643814 643814 0 0.0
.symtab 194128 194128 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1040212 1040214 2 0.0
cc13x2_26x2 lock-mtd LP_CC2652R7 (read only) 658123 658123 0 0.0
(read/write) 158713 158713 0 0.0
.bss 80376 80376 0 0.0
.data 3272 3272 0 0.0
.rodata 77115 77115 0 0.0
.text 580516 580516 0 0.0
pump-app LP_CC2652R7 (read only) 648839 648839 0 0.0
(read/write) 153177 153177 0 0.0
.bss 74600 74600 0 0.0
.data 3264 3264 0 0.0
.rodata 79695 79695 0 0.0
.text 568656 568656 0 0.0
pump-controller-app LP_CC2652R7 (read only) 634343 634343 0 0.0
(read/write) 153317 153317 0 0.0
.bss 74744 74744 0 0.0
.data 3260 3260 0 0.0
.rodata 75575 75575 0 0.0
.text 558280 558280 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 747267 747267 0 0.0
(read/write) 170152 170152 0 0.0
.bss 92488 92488 0 0.0
.data 3464 3464 0 0.0
.rodata 79687 79687 0 0.0
.text 667192 667192 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 739287 739287 0 0.0
(read/write) 175372 175372 0 0.0
.bss 97712 97712 0 0.0
.data 3460 3460 0 0.0
.rodata 76355 76355 0 0.0
.text 662540 662540 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 727419 727419 0 0.0
(read/write) 169980 169980 0 0.0
.bss 92320 92320 0 0.0
.data 3460 3460 0 0.0
.rodata 102319 102319 0 0.0
.text 624712 624712 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 680819 680819 0 0.0
(read/write) 164444 164444 0 0.0
.bss 86544 86544 0 0.0
.data 3452 3452 0 0.0
.rodata 76879 76879 0 0.0
.text 603548 603548 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 666267 666267 0 0.0
(read/write) 164576 164576 0 0.0
.bss 86688 86688 0 0.0
.data 3448 3448 0 0.0
.rodata 72727 72727 0 0.0
.text 593148 593148 0 0.0
cc32xx lock CC3235SF_LAUNCHXL (blank) 0 0 0 0.0
(read only) 605850 605850 0 0.0
(read/write) 204164 204164 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197576 197576 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 955050 955050 0 0.0
.debug_aranges 117632 117632 0 0.0
.debug_frame 401616 401616 0 0.0
.debug_info 22806527 22806527 0 0.0
.debug_line 2864625 2864625 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1714439 1714439 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 106796 106796 0 0.0
.debug_str 3750276 3750276 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104402 104402 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 484235 484235 0 0.0
.symtab 287456 287456 0 0.0
.text 499328 499328 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 524483 524483 0 0.0
.app_xip_area 417277 417277 0 0.0
.bss 62184 62184 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 529187 529187 0 0.0
.app_xip_area 416677 416677 0 0.0
.bss 67480 67480 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 566355 566355 0 0.0
.app_xip_area 459909 459909 0 0.0
.bss 61472 61472 0 0.0
.data 668 668 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 530987 530987 0 0.0
.app_xip_area 421973 421973 0 0.0
.bss 63960 63960 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 964396 964396 0 0.0
.bss 179680 179680 0 0.0
.data 2136 2136 0 0.0
.text 782560 782560 0 0.0
BRD4187C (read/write) 1001008 1001008 0 0.0
.bss 159412 159412 0 0.0
.data 2780 2780 0 0.0
.text 838796 838796 0 0.0
lock-app BRD4161A+wf200 (read/write) 1068896 1068888 -8 -0.0
.bss 174144 174144 0 0.0
.data 2152 2152 0 0.0
.text 892580 892572 -8 -0.0
window-app BRD4187C (read/write) 1076340 1076340 0 0.0
.bss 143884 143884 0 0.0
.data 2676 2676 0 0.0
.text 929760 929760 0 0.0
esp32 all-clusters-app c3devkit (read only) 1054374 1054374 0 0.0
(read/write) 1583864 1583864 0 0.0
.dram0.bss 77192 77192 0 0.0
.dram0.data 13964 13964 0 0.0
.flash.rodata 213568 213568 0 0.0
.flash.text 1054374 1054374 0 0.0
.iram0.text 76538 76538 0 0.0
m5stack (read only) 1101663 1101663 0 0.0
(read/write) 493018 493014 -4 -0.0
.dram0.bss 82208 82208 0 0.0
.dram0.data 34300 34300 0 0.0
.flash.rodata 241356 241352 -4 -0.0
.flash.text 1096279 1096279 0 0.0
.iram0.text 126055 126055 0 0.0
k32w contact k32w0+release (read only) 583644 583644 0 0.0
(read/write) 82704 82704 0 0.0
.bss 65888 65888 0 0.0
.data 2192 2192 0 0.0
.text 583108 583108 0 0.0
light k32w0+release (read only) 582588 582588 0 0.0
(read/write) 82356 82356 0 0.0
.bss 65552 65552 0 0.0
.data 2180 2180 0 0.0
.text 582052 582052 0 0.0
lock k32w0+release (read only) 556076 556076 0 0.0
(read/write) 80352 80352 0 0.0
.bss 63624 63624 0 0.0
.data 2104 2104 0 0.0
.text 555540 555540 0 0.0
linux all-clusters-app debug (read only) 3150541 3150541 0 0.0
(read/write) 152904 152904 0 0.0
.bss 60224 60224 0 0.0
.data 2160 2160 0 0.0
.data.rel.ro 84016 84016 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 1120 1120 0 0.0
.rodata 231048 231048 0 0.0
.text 2733397 2733397 0 0.0
all-clusters-minimal-app debug (read only) 2958437 2958437 0 0.0
(read/write) 145792 145792 0 0.0
.bss 59328 59328 0 0.0
.data 2128 2128 0 0.0
.data.rel.ro 77936 77936 0 0.0
.dynamic 608 608 0 0.0
.got 4664 4664 0 0.0
.init 27 27 0 0.0
.init_array 1080 1080 0 0.0
.rodata 224360 224360 0 0.0
.text 2551637 2551637 0 0.0
bridge-app debug (read only) 2518333 2518333 0 0.0
(read/write) 129648 129648 0 0.0
.bss 50232 50232 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 69608 69608 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 173256 173256 0 0.0
.text 2172757 2172757 0 0.0
chip-tool debug (read only) 15263089 15263089 0 0.0
(read/write) 701160 701160 0 0.0
.bss 26424 26424 0 0.0
.data 3042 3042 0 0.0
.data.rel.ro 664904 664904 0 0.0
.dynamic 608 608 0 0.0
.got 5360 5360 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 672181 672181 0 0.0
.text 12964052 12964052 0 0.0
chip-tool-ipv6only arm64 (read only) 14618020 14618020 0 0.0
(read/write) 753720 753720 0 0.0
.bss 34408 34408 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 694560 694560 0 0.0
.dynamic 560 560 0 0.0
.got 16504 16504 0 0.0
.init 24 24 0 0.0
.init_array 224 224 0 0.0
.rodata 608792 608792 0 0.0
.text 12225860 12225860 0 0.0
dynamic-bridge-app-ipv6only debug (read only) 2581997 2581997 0 0.0
(read/write) 126840 126840 0 0.0
.bss 47544 47544 0 0.0
.data 2864 2864 0 0.0
.data.rel.ro 70192 70192 0 0.0
.dynamic 624 624 0 0.0
.got 4800 4800 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 175976 175976 0 0.0
.text 2228661 2228661 0 0.0
lighting-app debug+rpc+ui (read only) 3246537 3246537 0 0.0
(read/write) 132272 132272 0 0.0
.bss 48032 48032 0 0.0
.data 2704 2704 0 0.0
.data.rel.ro 74736 74736 0 0.0
.dynamic 656 656 0 0.0
.got 5240 5240 0 0.0
.init 27 27 0 0.0
.init_array 872 872 0 0.0
.rodata 284628 284628 0 0.0
.text 2770114 2770114 0 0.0
lock-app debug (read only) 2658517 2658517 0 0.0
(read/write) 123624 123624 0 0.0
.bss 45952 45952 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 69648 69648 0 0.0
.dynamic 608 608 0 0.0
.got 4648 4648 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 206312 206312 0 0.0
.text 2279509 2279509 0 0.0
ota-provider-app debug (read only) 2209453 2209453 0 0.0
(read/write) 103672 103672 0 0.0
.bss 44528 44528 0 0.0
.data 2112 2112 0 0.0
.data.rel.ro 51944 51944 0 0.0
.dynamic 608 608 0 0.0
.got 3800 3800 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 154408 154408 0 0.0
.text 1913525 1913525 0 0.0
ota-requestor-app debug (read only) 2377013 2377013 0 0.0
(read/write) 111464 111464 0 0.0
.bss 46960 46960 0 0.0
.data 2512 2512 0 0.0
.data.rel.ro 56800 56800 0 0.0
.dynamic 608 608 0 0.0
.got 3784 3784 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 158472 158472 0 0.0
.text 2068149 2068149 0 0.0
shell debug (read only) 2687145 2687145 0 0.0
(read/write) 141328 141328 0 0.0
.bss 59176 59176 0 0.0
.data 1232 1232 0 0.0
.data.rel.ro 75080 75080 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 1056 1056 0 0.0
.rodata 199570 199570 0 0.0
.text 2325410 2325410 0 0.0
thermostat-no-ble arm64 (read only) 2537340 2537340 0 0.0
(read/write) 142696 142696 0 0.0
.bss 53496 53496 0 0.0
.data 1736 1736 0 0.0
.data.rel.ro 77960 77960 0 0.0
.dynamic 560 560 0 0.0
.got 5416 5416 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 129288 129288 0 0.0
.text 2146180 2146180 0 0.0
tv-app debug (read only) 3314545 3314545 0 0.0
(read/write) 261512 261512 0 0.0
.bss 171232 171232 0 0.0
.data 4080 4080 0 0.0
.data.rel.ro 79480 79480 0 0.0
.dynamic 608 608 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 1088 1088 0 0.0
.rodata 222744 222744 0 0.0
.text 2895618 2895618 0 0.0
tv-casting-app debug (read only) 8953321 8953321 0 0.0
(read/write) 215504 215504 0 0.0
.bss 52064 52064 0 0.0
.data 1744 1744 0 0.0
.data.rel.ro 155128 155128 0 0.0
.dynamic 608 608 0 0.0
.got 4920 4920 0 0.0
.init 27 27 0 0.0
.init_array 1000 1000 0 0.0
.rodata 325612 325612 0 0.0
.text 8208690 8208690 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2495496 2495496 0 0.0
.bss 216304 216304 0 0.0
.data 5144 5144 0 0.0
.text 1458180 1458180 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1178080 1178080 0 0.0
bss 155621 155621 0 0.0
rodata 133104 133104 0 0.0
text 808644 808644 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1437824 1437824 0 0.0
bss 135361 135361 0 0.0
rodata 229120 229120 0 0.0
text 779256 779256 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1124288 1124288 0 0.0
bss 154773 154773 0 0.0
rodata 109856 109856 0 0.0
text 778944 778944 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 840616 840616 0 0.0
(read/write) 1709300 1709300 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 190164 190164 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2560 2560 0 0.0
.debug_abbrev 1286095 1286095 0 0.0
.debug_aranges 145040 145040 0 0.0
.debug_frame 484944 484944 0 0.0
.debug_info 31376858 31376860 2 0.0
.debug_line 3963591 3963591 0 0.0
.debug_line_str 957 957 0 0.0
.debug_loclists 2254176 2254176 0 0.0
.debug_rnglists 140785 140785 0 0.0
.debug_str 4262593 4262593 0 0.0
.heap 840616 840616 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 720479 720479 0 0.0
.symtab 467904 467904 0 0.0
.text 1508188 1508188 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 841424 841424 0 0.0
(read/write) 1650372 1650372 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189364 189364 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2552 2552 0 0.0
.debug_abbrev 1275829 1275829 0 0.0
.debug_aranges 144288 144288 0 0.0
.debug_frame 487384 487384 0 0.0
.debug_info 30935183 30935183 0 0.0
.debug_line 3976791 3976791 0 0.0
.debug_line_str 981 981 0 0.0
.debug_loclists 2245088 2245088 0 0.0
.debug_rnglists 139734 139734 0 0.0
.debug_str 4251352 4251352 0 0.0
.heap 841424 841424 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 676786 676786 0 0.0
.symtab 452352 452352 0 0.0
.text 1450068 1450068 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 849736 849736 0 0.0
(read/write) 1571372 1571372 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 181220 181220 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2384 2384 0 0.0
.debug_abbrev 1108681 1108681 0 0.0
.debug_aranges 134320 134320 0 0.0
.debug_frame 450216 450216 0 0.0
.debug_info 25634974 25634975 1 0.0
.debug_line 3537890 3537890 0 0.0
.debug_line_str 942 942 0 0.0
.debug_loclists 2074975 2074975 0 0.0
.debug_rnglists 129271 129271 0 0.0
.debug_str 4057388 4057388 0 0.0
.heap 849736 849736 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 592238 592238 0 0.0
.symtab 414352 414352 0 0.0
.text 1379380 1379380 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 821960 821960 0 0.0
(read/write) 1627988 1627988 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 208988 208988 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2392 2392 0 0.0
.debug_abbrev 1107791 1107791 0 0.0
.debug_aranges 134824 134824 0 0.0
.debug_frame 452308 452308 0 0.0
.debug_info 25757758 25757758 0 0.0
.debug_line 3534370 3534370 0 0.0
.debug_line_str 933 933 0 0.0
.debug_loclists 2088422 2088422 0 0.0
.debug_rnglists 129727 129727 0 0.0
.debug_str 4072299 4072299 0 0.0
.heap 821960 821960 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 596154 596154 0 0.0
.symtab 416688 416688 0 0.0
.text 1408220 1408220 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1170744 1170752 8 0.0
.bss 99928 99928 0 0.0
.data 856 856 0 0.0
.text 617844 617852 8 0.0
lock-app qpg6105+debug (read/write) 1139956 1139956 0 0.0
.bss 94824 94824 0 0.0
.data 856 856 0 0.0
.text 587056 587056 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1013532 1013532 0 0.0
bss 98984 98984 0 0.0
text 689146 689148 2 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 949200 949200 0 0.0
bss 98036 98036 0 0.0
text 651014 651014 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 927248 927248 0 0.0
bss 100252 100252 0 0.0
text 640656 640656 0 0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 858504 858504 0 0.0
bss 89936 89936 0 0.0
text 583330 583334 4 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 874808 874808 0 0.0
bss 90092 90092 0 0.0
text 597964 597962 -2 -0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 942388 942388 0 0.0
bss 98272 98272 0 0.0
text 657646 657646 0 0.0
lighting-app-factory-data tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 953768 953760 -8 -0.0
bss 102520 102520 0 0.0
text 665168 665164 -4 -0.0
lighting-app-rpc tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1010812 1010812 0 0.0
bss 99836 99836 0 0.0
text 702104 702104 0 0.0
lighting-app-shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1043244 1043244 0 0.0
bss 110920 110920 0 0.0
text 722680 722678 -2 -0.0
lock-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 913556 913556 0 0.0
bss 90588 90588 0 0.0
text 612002 612000 -2 -0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 881096 881096 0 0.0
bss 91192 91192 0 0.0
text 605266 605264 -2 -0.0
pump-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 864500 864500 0 0.0
bss 90056 90056 0 0.0
text 589508 589510 2 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 851288 851296 8 0.0
bss 89856 89856 0 0.0
text 579624 579626 2 0.0
temperature-measurement-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 847496 847496 0 0.0
bss 89776 89776 0 0.0
text 575340 575342 2 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 879684 879684 0 0.0
bss 91496 91496 0 0.0
text 600118 600118 0 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 875840 875840 0 0.0
bss 91892 91892 0 0.0
text 595358 595360 2 0.0

@doru91
Copy link
Contributor

doru91 commented May 29, 2023

thanks for the fix. we also fixed this locally but for some unknown reason it didn't get the chance to go upstream.

@andy31415 andy31415 merged commit 38013f3 into project-chip:master May 29, 2023
@bzbarsky-apple bzbarsky-apple deleted the fix-k32-diagnostic-provider branch May 29, 2023 23:13
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this pull request May 30, 2023
@bzbarsky-apple
Fix thread names for k32w's DiagnosticDataProvider. (project-chip#26892)
97cd5fa 
The old code was copying in N-1 chars, then creating a string of length N from
them, so ending up with a random byte in the string, which could lead to the
string not being valid UTF-8.

Fixes project-chip#26891
@bzbarsky-apple bzbarsky-apple mentioned this pull request May 30, 2023
Merged
andy31415 pushed a commit that referenced this pull request May 30, 2023
@bzbarsky-apple
Fix thread names for k32w's DiagnosticDataProvider. (#26892) (#26950)
e407cc2 
The old code was copying in N-1 chars, then creating a string of length N from
them, so ending up with a random byte in the string, which could lead to the
string not being valid UTF-8.

Fixes #26891
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doru91 doru91 doru91 approved these changes

@andy31415 andy31415 andy31415 approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

Assignees
No one assigned
Labels
cherry picked to 1.1 fast track platform review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] k32w DiagnosticDataProviderImpl encodes random bytes as "utf-8"
4 participants
@bzbarsky-apple @doru91 @tcarmelveilleux @andy31415