-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MediaClusters: Update SkipChannel per issue 26104 #26501
Merged
lazarkov
merged 23 commits into
project-chip:master
from
lazarkov:feature/channel-issue-6968
May 19, 2023
Merged
MediaClusters: Update SkipChannel per issue 26104 #26501
lazarkov
merged 23 commits into
project-chip:master
from
lazarkov:feature/channel-issue-6968
May 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs and
jmeg-sfy
May 11, 2023 09:02
lazarkov
force-pushed
the
feature/channel-issue-6968
branch
from
May 19, 2023 09:29
6a8075f
to
ab25822
Compare
PR #26501: Size comparison from e75e729 to ab25822 Increases (1 build for cc32xx)
Full report (4 builds for cc32xx, mbed, qpg)
|
PR #26501: Size comparison from e75e729 to 5d2aa73 Increases above 0.2%:
Increases (18 builds for cc32xx, esp32, k32w, linux, nrfconnect, psoc6, telink)
Decreases (10 builds for bl602, bl702, efr32, k32w, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Change overview
Updated Count value to INT16S
Issue(s) fixed:
26104
6968
Testing
Run
./scripts/run_in_build_env.sh \ "./scripts/tests/run_test_suite.py \ --runner chip_tool_python \ --chip-tool ./out/debug/standalone/chip-tool \ --target-skip-glob '{Test_TC_DGTHREAD_2_1,Test_TC_DGTHREAD_2_2,Test_TC_DGTHREAD_2_3,Test_TC_DGTHREAD_2_4}' \ run \ --iterations 1 \ --test-timeout-seconds 120 \ --all-clusters-app ./out/debug/standalone/chip-all-clusters-app \ --lock-app ./out/debug/standalone/chip-lock-app \ --ota-provider-app ./out/debug/standalone/chip-ota-provider-app \ --ota-requestor-app ./out/debug/standalone/chip-ota-requestor-app \ --tv-app ./out/debug/standalone/chip-tv-app \ --bridge-app ./out/debug/standalone/chip-bridge-app \ "