Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0] SkipChannel count should be SIGNED #26104

Closed
andy31415 opened this issue Apr 14, 2023 · 2 comments
Closed

[1.0] SkipChannel count should be SIGNED #26104

andy31415 opened this issue Apr 14, 2023 · 2 comments
Assignees
Labels
Spec XML align SDK XML does not match the spec (including naming, etc) spec Mismatch between spec and implementation

Comments

@andy31415
Copy link
Contributor

Reproduction steps

SkipChannel in channel-cluster is currently INT16U, however it should be signed to allow channels to move backwards.

This may mean also fixing some TV implementations

Bug prevalence

Always

GitHub hash of the SDK that was being used

fcb34b7

Platform

core

Platform Version(s)

No response

Type

Spec Compliance Issue

Anything else?

No response

@bzbarsky-apple
Copy link
Contributor

Note that this would be a backwards-incompatible change with the 1.0 SDK, which would cause commands sent by clients that have made this change to not be decodable at all by servers that have not been updated to the change, and vice versa.

The backwards-compatible thing is probably to change the spec to keep a field at index 0 which is unsigned int which only allows going up, and add a second, optional, field which allows going both up or down. Or something.

How much of a worry that should be in practice, I can't tell you.

@bzbarsky-apple bzbarsky-apple added spec Mismatch between spec and implementation Spec XML align SDK XML does not match the spec (including naming, etc) labels Apr 14, 2023
@bzbarsky-apple
Copy link
Contributor

Fixed in #26501

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Spec XML align SDK XML does not match the spec (including naming, etc) spec Mismatch between spec and implementation
Projects
Development

No branches or pull requests

3 participants