Add a way to specify certificate validity period on Darwin. #26403

bzbarsky-apple · 2023-05-06T02:44:47Z

This PR includes the change in #26402 to pass the newly added tests, but I'd like to merge it after the other PR merges, for clarity.

github-actions · 2023-05-06T02:59:10Z

PR #26403: Size comparison from c8e453c to e3f8d23

Full report (1 build for cc32xx)

platform	target	config	section	`c8e453c`	`e3f8d23`
cc32xx	lock	CC3235SF_LAUNCHXL		0	0
			(read only)	605090	605090
			(read/write)	204164	204164
			.ARM.attributes	44	44
			.ARM.exidx	8	8
			.bss	197576	197576
			.comment	206	206
			.data	1468	1468
			.debug_abbrev	957621	957621
			.debug_aranges	101136	101136
			.debug_frame	341512	341512
			.debug_info	19609756	19609756
			.debug_line	`2666632`	`2666632`
			.debug_line_str	513	513
			.debug_loc	33340	33340
			.debug_loclists	1489225	1489225
			.debug_ranges	4984	4984
			.debug_rnglists	94315	94315
			.debug_str	3108982	3108982
			.ramVecs	780	780
			.resetVecs	64	64
			.rodata	104354	104354
			.shstrtab	265	265
			.stack	2048	2048
			.strtab	483384	483384
			.symtab	287328	287328
			.text	498612	498612

github-actions · 2023-05-06T04:04:45Z

PR #26403: Size comparison from c984f0b to e3f8d23

Decreases (1 build for cc32xx)

platform	target	config	section	`c984f0b`	`e3f8d23`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_info	19609757	19609755	-2	-0.0

Full report (1 build for cc32xx)

platform	target	config	section	`c984f0b`	`e3f8d23`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0	0.0
			(read only)	605090	605090	0	0.0
			(read/write)	204164	204164	0	0.0
			.ARM.attributes	44	44	0	0.0
			.ARM.exidx	8	8	0	0.0
			.bss	197576	197576	0	0.0
			.comment	206	206	0	0.0
			.data	1468	1468	0	0.0
			.debug_abbrev	957621	957621	0	0.0
			.debug_aranges	101136	101136	0	0.0
			.debug_frame	341512	341512	0	0.0
			.debug_info	19609757	19609755	-2	-0.0
			.debug_line	`2666632`	`2666632`	0	0.0
			.debug_line_str	513	513	0	0.0
			.debug_loc	33340	33340	0	0.0
			.debug_loclists	1489225	1489225	0	0.0
			.debug_ranges	4984	4984	0	0.0
			.debug_rnglists	94315	94315	0	0.0
			.debug_str	3108982	3108982	0	0.0
			.ramVecs	780	780	0	0.0
			.resetVecs	64	64	0	0.0
			.rodata	104354	104354	0	0.0
			.shstrtab	265	265	0	0.0
			.stack	2048	2048	0	0.0
			.strtab	483384	483384	0	0.0
			.symtab	287328	287328	0	0.0
			.text	498612	498612	0	0.0

src/darwin/Framework/CHIP/MTRCertificates.h

src/darwin/Framework/CHIP/MTROperationalCredentialsDelegate.h

src/darwin/Framework/CHIP/MTROperationalCredentialsDelegate.mm

src/darwin/Framework/CHIPTests/MTRCertificateTests.m

github-actions · 2023-05-09T04:58:18Z

PR #26403: Size comparison from e5eb60d to be7dd8f

Increases (6 builds for bl602, bl702, cc32xx, qpg)

platform	target	config	section	`e5eb60d`	`be7dd8f`	change
bl602	lighting-app	bl602	(read/write)	1354990	1354998	8
			.text	1035974	`1035978`	4
		bl602+rpc	.text	`1067330`	1067332	2
bl702	lighting-app	bl702	.debug_info	40943087	40943088	1
			.text	965468	965470	2
		bl702+rpc	.debug_info	45848901	45848902	1
			.text	`1038094`	1038096	2
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_info	19674626	19674627	1
qpg	lighting-app	qpg6105+debug	(read/write)	1168224	1168232	8
			.text	615324	615332	8

Full report (11 builds for bl602, bl702, cc32xx, mbed, nrfconnect, qpg)

platform	target	config	section	`e5eb60d`	`be7dd8f`	change
bl602	lighting-app	bl602	(read/write)	1354990	1354998	8
			.bss	87886	87886	0
			.data	9648	9648	0
			.text	1035974	`1035978`	4
		bl602+rpc	(read/write)	`1401266`	`1401266`	0
			.bss	95934	95934	0
			.data	10040	10040	0
			.text	`1067330`	1067332	2
bl702	lighting-app	bl702		0	0	0
			(read only)	3358	3358	0
			(read/write)	1185759	1185759	0
			.bleromro	6342	6342	0
			.bleromrw	124	124	0
			.boot2	328	328	0
			.bss	67585	67585	0
			.bss_psram	24368	24368	0
			.comment	48	48	0
			.data	3952	3952	0
			.debug_abbrev	1550204	1550204	0
			.debug_aranges	132944	132944	0
			.debug_frame	488804	488804	0
			.debug_info	40943087	40943088	1
			.debug_line	5301455	5301455	0
			.debug_loc	3424613	3424613	0
			.debug_ranges	372344	372344	0
			.debug_str	3708223	3708223	0
			.hbn	536	536	0
			.hbn_noinit	260	260	0
			.init	342	342	0
			.init_array	140	140	0
			.psram	0	0	0
			.riscv.attributes	47	47	0
			.rodata	106304	106304	0
			.rsvd	4	4	0
			.sha_ocram	72	72	0
			.shstrtab	304	304	0
			.stack	2048	2048	0
			.strtab	580786	580786	0
			.symtab	175264	175264	0
			.tcm_data	28	28	0
			.tcmcode	3358	3358	0
			.text	965468	965470	2
		bl702+rpc		0	0	0
			(read only)	3358	3358	0
			(read/write)	1273555	1273555	0
			.bleromro	6342	6342	0
			.bleromrw	124	124	0
			.boot2	328	328	0
			.bss	75633	75633	0
			.bss_psram	24768	24768	0
			.comment	48	48	0
			.data	4504	4504	0
			.debug_abbrev	1706954	1706954	0
			.debug_aranges	141224	141224	0
			.debug_frame	516776	516776	0
			.debug_info	45848901	45848902	1
			.debug_line	`5716360`	`5716360`	0
			.debug_loc	3626917	3626917	0
			.debug_ranges	397648	397648	0
			.debug_str	4133328	4133328	0
			.hbn	536	536	0
			.hbn_noinit	260	260	0
			.init	342	342	0
			.init_array	156	156	0
			.psram	0	0	0
			.riscv.attributes	47	47	0
			.rodata	120144	120144	0
			.rsvd	4	4	0
			.sha_ocram	72	72	0
			.shstrtab	304	304	0
			.stack	2048	2048	0
			.strtab	641456	641456	0
			.symtab	193600	193600	0
			.tcm_data	28	28	0
			.tcmcode	3358	3358	0
			.text	`1038094`	1038096	2
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0
			(read only)	605002	605002	0
			(read/write)	204164	204164	0
			.ARM.attributes	44	44	0
			.ARM.exidx	8	8	0
			.bss	197576	197576	0
			.comment	206	206	0
			.data	1468	1468	0
			.debug_abbrev	957619	957619	0
			.debug_aranges	101232	101232	0
			.debug_frame	342080	342080	0
			.debug_info	19674626	19674627	1
			.debug_line	2671903	2671903	0
			.debug_line_str	513	513	0
			.debug_loc	33340	33340	0
			.debug_loclists	1491139	1491139	0
			.debug_ranges	4984	4984	0
			.debug_rnglists	94412	94412	0
			.debug_str	3131828	3131828	0
			.ramVecs	780	780	0
			.resetVecs	64	64	0
			.rodata	104314	104314	0
			.shstrtab	265	265	0
			.stack	2048	2048	0
			.strtab	483089	483089	0
			.symtab	287232	287232	0
			.text	498564	498564	0
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0
			(read/write)	2495056	2495056	0
			.bss	216304	216304	0
			.data	5144	5144	0
			.text	`1457740`	`1457740`	0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read only)	4	4	0
			(read/write)	1176352	1176352	0
			bss	155563	155563	0
			rodata	132752	132752	0
			text	807276	807276	0
	all-clusters-minimal-app	nrf52840dk_nrf52840	(read only)	4	4	0
			(read/write)	1123444	1123444	0
			bss	154757	154757	0
			rodata	109748	109748	0
			text	778212	778212	0
	all-clusters-app	nrf7002dk_nrf5340_cpuapp	(read only)	4	4	0
			(read/write)	`1436080`	`1436080`	0
			bss	135303	135303	0
			rodata	228768	228768	0
			text	777936	777936	0
qpg	lighting-app	qpg6105+debug	(read/write)	1168224	1168232	8
			.bss	99632	99632	0
			.data	856	856	0
			.text	615324	615332	8
	lock-app	qpg6105+debug	(read/write)	`1138076`	`1138076`	0
			.bss	94824	94824	0
			.data	856	856	0
			.text	585176	585176	0

Add a way to specify certificate validity period on Darwin.

e3f8d23

github-actions bot added the darwin label May 6, 2023

pullapprove bot requested review from selissia, sharadb-amazon, tecimovic, tehampson, turon, vijs, vivien-apple, woody-apple, xylophone21, younghak-hwang and yunhanw-google May 6, 2023 02:45

pullapprove bot added review - pending darwin and removed darwin labels May 6, 2023

bzbarsky-apple force-pushed the certificate-validity branch from 2cfe987 to e3f8d23 Compare May 6, 2023 03:53

ksperling-apple approved these changes May 7, 2023

View reviewed changes

andy31415 approved these changes May 8, 2023

View reviewed changes

pullapprove bot added review - approved and removed review - pending labels May 8, 2023

bzbarsky-apple added 3 commits May 8, 2023 14:19

Address review comments.

05623af

Address review comment.

d6e76dd

Address phrasing comment.

be7dd8f

bzbarsky-apple force-pushed the certificate-validity branch from 080b7a5 to be7dd8f Compare May 9, 2023 04:26

jmeg-sfy approved these changes May 9, 2023

View reviewed changes

bzbarsky-apple merged commit 2f70c89 into project-chip:master May 9, 2023

bzbarsky-apple deleted the certificate-validity branch May 9, 2023 15:41

bzbarsky-apple mentioned this pull request May 9, 2023

[BUG] Darwin: Try to use our own certificates failed during GenerateNOCChain - no nocSigner #26240

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a way to specify certificate validity period on Darwin. #26403

Add a way to specify certificate validity period on Darwin. #26403

bzbarsky-apple commented May 6, 2023

github-actions bot commented May 6, 2023

github-actions bot commented May 6, 2023

github-actions bot commented May 9, 2023

Add a way to specify certificate validity period on Darwin. #26403

Add a way to specify certificate validity period on Darwin. #26403

Conversation

bzbarsky-apple commented May 6, 2023

github-actions bot commented May 6, 2023

github-actions bot commented May 6, 2023

github-actions bot commented May 9, 2023