-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix generation of certificates without an expiration date. #26402
Merged
bzbarsky-apple
merged 3 commits into
project-chip:master
from
bzbarsky-apple:fix-cert-generation
May 9, 2023
Merged
Fix generation of certificates without an expiration date. #26402
bzbarsky-apple
merged 3 commits into
project-chip:master
from
bzbarsky-apple:fix-cert-generation
May 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Matter encodes "no expiration" as 0, we can't just check that notAfter >= notBefore; we have to check for the case when notAfter is "no expiration" separately.
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock,
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mlepage-google
May 6, 2023 02:43
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yufengwangca
May 6, 2023 02:43
silogramm
approved these changes
May 6, 2023
PR #26402: Size comparison from c8e453c to 254b2ec Full report (1 build for cc32xx)
|
PR #26402: Size comparison from c8e453c to 21d1bc7 Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
emargolis
approved these changes
May 6, 2023
ksperling-apple
approved these changes
May 7, 2023
bzbarsky-apple
force-pushed
the
fix-cert-generation
branch
from
May 8, 2023 18:23
cd3d2b5
to
103086e
Compare
PR #26402: Size comparison from a2d1596 to 103086e Full report (1 build for cc32xx)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Matter encodes "no expiration" as 0, we can't just check that notAfter >= notBefore; we have to check for the case when notAfter is "no expiration" separately.