time synchronization cluster XML update #26332

fessehaeve · 2023-05-02T14:55:26Z

Update to the Time Synchronisation cluster XML.
This is a break-down of #26082

src/app/zap-templates/zcl/data-model/chip/time-synchronization-cluster.xml

github-actions · 2023-05-02T17:26:11Z

PR #26332: Size comparison from 7be1954 to e9224ac

Increases above 0.2%:

platform	target	config	section	`7be1954`	`e9224ac`	change	% change
bl702	lighting-app	bl702	.debug_str	3645006	3666886	21880	0.6
		bl702+rpc	.debug_str	4069427	4091307	21880	0.5
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_frame	341168	342004	836	0.2
			.debug_info	19511285	19577605	66320	0.3
			.debug_line	2664965	2670692	5727	0.2
			.debug_str	3068127	`3090775`	22648	0.7
linux	chip-tool-ipv6only	arm64	(read only)	12215404	12261260	45856	0.4
			.data.rel.ro	688000	689384	1384	0.2
			.got	15672	15744	72	0.5
			.text	`9875524`	`9916772`	41248	0.4

Increases (15 builds for bl602, bl702, cc32xx, efr32, k32w, linux, qpg)

platform	target	config	section	`7be1954`	`e9224ac`	change	% change
bl602	lighting-app	bl602	(read/write)	`1354458`	1354482	24	0.0
			.text	1035448	`1035472`	24	0.0
		bl602+rpc	(read/write)	1400734	1400758	24	0.0
			.text	1066804	1066826	22	0.0
bl702	lighting-app	bl702	(read/write)	1184831	`1184847`	16	0.0
			.debug_aranges	132744	132920	176	0.1
			.debug_frame	487708	488564	856	0.2
			.debug_info	40736901	40806967	70066	0.2
			.debug_line	`5291774`	5298213	6439	0.1
			.debug_loc	3415797	3421002	5205	0.2
			.debug_ranges	371896	372192	296	0.1
			.debug_str	3645006	3666886	21880	0.6
			.text	964580	964604	24	0.0
		bl702+rpc	(read/write)	1272371	1272403	32	0.0
			.debug_aranges	140968	141144	176	0.1
			.debug_frame	515600	516456	856	0.2
			.debug_info	45431972	45502586	70614	0.2
			.debug_line	5701205	5707644	6439	0.1
			.debug_loc	3616850	3622071	5221	0.1
			.debug_ranges	396928	397224	296	0.1
			.debug_str	4069427	4091307	21880	0.5
			.text	1036974	`1036998`	24	0.0
cc32xx	lock	CC3235SF_LAUNCHXL	(read only)	604426	604458	32	0.0
			.debug_aranges	101056	101256	200	0.2
			.debug_frame	341168	342004	836	0.2
			.debug_info	19511285	19577605	66320	0.3
			.debug_line	2664965	2670692	5727	0.2
			.debug_loclists	1486884	1489200	2316	0.2
			.debug_rnglists	94239	94415	176	0.2
			.debug_str	3068127	`3090775`	22648	0.7
			.symtab	287024	287056	32	0.0
			.text	498004	498036	32	0.0
efr32	lighting-app	BRD4161A+rs9116	(read/write)	962556	962604	48	0.0
			.text	781528	781576	48	0.0
	lock-app	BRD4161A+wf200	(read/write)	1067820	`1067836`	16	0.0
			.text	892296	892312	16	0.0
	lighting-app	BRD4187C	(read/write)	1000464	`1000472`	8	0.0
			.text	838244	838252	8	0.0
	window-app	BRD4187C	(read/write)	1074952	`1074992`	40	0.0
			.text	928388	928428	40	0.0
k32w	contact	k32w0+release	(read only)	582932	582948	16	0.0
			.text	582396	582412	16	0.0
	light	k32w0+release	(read only)	581812	581828	16	0.0
			.text	581276	581292	16	0.0
linux	chip-tool-ipv6only	arm64	(read only)	12215404	12261260	45856	0.4
			(read/write)	746264	747720	1456	0.2
			.data.rel.ro	688000	689384	1384	0.2
			.got	15672	15744	72	0.5
			.rodata	568688	569696	1008	0.2
			.text	`9875524`	`9916772`	41248	0.4
	thermostat-no-ble	arm64	(read only)	2524324	2524372	48	0.0
			.text	2130112	2130160	48	0.0
qpg	lighting-app	qpg6105+debug	(read/write)	`1167616`	1167624	8	0.0
			.text	614716	614724	8	0.0
	lock-app	qpg6105+debug	(read/write)	1136984	`1136992`	8	0.0
			.text	584080	584088	8	0.0

Full report (17 builds for bl602, bl702, cc32xx, efr32, k32w, linux, mbed, qpg)

platform	target	config	section	`7be1954`	`e9224ac`	change	% change
bl602	lighting-app	bl602	(read/write)	`1354458`	1354482	24	0.0
			.bss	87886	87886	0	0.0
			.data	9648	9648	0	0.0
			.text	1035448	`1035472`	24	0.0
		bl602+rpc	(read/write)	1400734	1400758	24	0.0
			.bss	95934	95934	0	0.0
			.data	10040	10040	0	0.0
			.text	1066804	1066826	22	0.0
bl702	lighting-app	bl702		0	0	0	0.0
			(read only)	3358	3358	0	0.0
			(read/write)	1184831	`1184847`	16	0.0
			.bleromro	6342	6342	0	0.0
			.bleromrw	124	124	0	0.0
			.boot2	328	328	0	0.0
			.bss	67601	67601	0	0.0
			.bss_psram	24368	24368	0	0.0
			.comment	48	48	0	0.0
			.data	3952	3952	0	0.0
			.debug_abbrev	1549462	1549462	0	0.0
			.debug_aranges	132744	132920	176	0.1
			.debug_frame	487708	488564	856	0.2
			.debug_info	40736901	40806967	70066	0.2
			.debug_line	`5291774`	5298213	6439	0.1
			.debug_loc	3415797	3421002	5205	0.2
			.debug_ranges	371896	372192	296	0.1
			.debug_str	3645006	3666886	21880	0.6
			.hbn	536	536	0	0.0
			.hbn_noinit	260	260	0	0.0
			.init	342	342	0	0.0
			.init_array	140	140	0	0.0
			.psram	0	0	0	0.0
			.riscv.attributes	47	47	0	0.0
			.rodata	106240	106240	0	0.0
			.rsvd	4	4	0	0.0
			.sha_ocram	72	72	0	0.0
			.shstrtab	304	304	0	0.0
			.stack	2048	2048	0	0.0
			.strtab	579409	579409	0	0.0
			.symtab	175136	175136	0	0.0
			.tcm_data	28	28	0	0.0
			.tcmcode	3358	3358	0	0.0
			.text	964580	964604	24	0.0
		bl702+rpc		0	0	0	0.0
			(read only)	3358	3358	0	0.0
			(read/write)	1272371	1272403	32	0.0
			.bleromro	6342	6342	0	0.0
			.bleromrw	124	124	0	0.0
			.boot2	328	328	0	0.0
			.bss	75633	75633	0	0.0
			.bss_psram	24768	24768	0	0.0
			.comment	48	48	0	0.0
			.data	4504	4504	0	0.0
			.debug_abbrev	1702742	1702742	0	0.0
			.debug_aranges	140968	141144	176	0.1
			.debug_frame	515600	516456	856	0.2
			.debug_info	45431972	45502586	70614	0.2
			.debug_line	5701205	5707644	6439	0.1
			.debug_loc	3616850	3622071	5221	0.1
			.debug_ranges	396928	397224	296	0.1
			.debug_str	4069427	4091307	21880	0.5
			.hbn	536	536	0	0.0
			.hbn_noinit	260	260	0	0.0
			.init	342	342	0	0.0
			.init_array	156	156	0	0.0
			.psram	0	0	0	0.0
			.riscv.attributes	47	47	0	0.0
			.rodata	120080	120080	0	0.0
			.rsvd	4	4	0	0.0
			.sha_ocram	72	72	0	0.0
			.shstrtab	304	304	0	0.0
			.stack	2048	2048	0	0.0
			.strtab	639953	639953	0	0.0
			.symtab	193424	193424	0	0.0
			.tcm_data	28	28	0	0.0
			.tcmcode	3358	3358	0	0.0
			.text	1036974	`1036998`	24	0.0
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0	0.0
			(read only)	604426	604458	32	0.0
			(read/write)	204156	204156	0	0.0
			.ARM.attributes	44	44	0	0.0
			.ARM.exidx	8	8	0	0.0
			.bss	197568	197568	0	0.0
			.comment	206	206	0	0.0
			.data	1468	1468	0	0.0
			.debug_abbrev	956872	956872	0	0.0
			.debug_aranges	101056	101256	200	0.2
			.debug_frame	341168	342004	836	0.2
			.debug_info	19511285	19577605	66320	0.3
			.debug_line	2664965	2670692	5727	0.2
			.debug_line_str	513	513	0	0.0
			.debug_loc	33340	33340	0	0.0
			.debug_loclists	1486884	1489200	2316	0.2
			.debug_ranges	4984	4984	0	0.0
			.debug_rnglists	94239	94415	176	0.2
			.debug_str	3068127	`3090775`	22648	0.7
			.ramVecs	780	780	0	0.0
			.resetVecs	64	64	0	0.0
			.rodata	104298	104298	0	0.0
			.shstrtab	265	265	0	0.0
			.stack	2048	2048	0	0.0
			.strtab	480350	480350	0	0.0
			.symtab	287024	287056	32	0.0
			.text	498004	498036	32	0.0
efr32	lighting-app	BRD4161A+rs9116	(read/write)	962556	962604	48	0.0
			.bss	178880	178880	0	0.0
			.data	2128	2128	0	0.0
			.text	781528	781576	48	0.0
	lock-app	BRD4161A+wf200	(read/write)	1067820	`1067836`	16	0.0
			.bss	173360	173360	0	0.0
			.data	2144	2144	0	0.0
			.text	892296	892312	16	0.0
	lighting-app	BRD4187C	(read/write)	1000464	`1000472`	8	0.0
			.bss	159420	159420	0	0.0
			.data	2780	2780	0	0.0
			.text	838244	838252	8	0.0
	window-app	BRD4187C	(read/write)	1074952	`1074992`	40	0.0
			.bss	143876	143876	0	0.0
			.data	2668	2668	0	0.0
			.text	928388	928428	40	0.0
k32w	contact	k32w0+release	(read only)	582932	582948	16	0.0
			(read/write)	82704	82704	0	0.0
			.bss	65888	65888	0	0.0
			.data	2192	2192	0	0.0
			.text	582396	582412	16	0.0
	light	k32w0+release	(read only)	581812	581828	16	0.0
			(read/write)	82348	82348	0	0.0
			.bss	65544	65544	0	0.0
			.data	2180	2180	0	0.0
			.text	581276	581292	16	0.0
	lock	k32w0+release	(read only)	555316	555316	0	0.0
			(read/write)	80352	80352	0	0.0
			.bss	63624	63624	0	0.0
			.data	2104	2104	0	0.0
			.text	554780	554780	0	0.0
linux	chip-tool-ipv6only	arm64	(read only)	12215404	12261260	45856	0.4
			(read/write)	746264	747720	1456	0.2
			.bss	34392	34392	0	0.0
			.data	3008	3008	0	0.0
			.data.rel.ro	688000	689384	1384	0.2
			.dynamic	560	560	0	0.0
			.got	15672	15744	72	0.5
			.init	24	24	0	0.0
			.init_array	216	216	0	0.0
			.rodata	568688	569696	1008	0.2
			.text	`9875524`	`9916772`	41248	0.4
	thermostat-no-ble	arm64	(read only)	2524324	2524372	48	0.0
			(read/write)	145864	145864	0	0.0
			.bss	56376	56376	0	0.0
			.data	1784	1784	0	0.0
			.data.rel.ro	78168	78168	0	0.0
			.dynamic	560	560	0	0.0
			.got	5448	5448	0	0.0
			.init	24	24	0	0.0
			.init_array	432	432	0	0.0
			.rodata	129848	129848	0	0.0
			.text	2130112	2130160	48	0.0
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2496432	2496432	0	0.0
			.bss	216296	216296	0	0.0
			.data	5144	5144	0	0.0
			.text	1459116	1459116	0	0.0
qpg	lighting-app	qpg6105+debug	(read/write)	`1167616`	1167624	8	0.0
			.bss	99632	99632	0	0.0
			.data	856	856	0	0.0
			.text	614716	614724	8	0.0
	lock-app	qpg6105+debug	(read/write)	1136984	`1136992`	8	0.0
			.bss	94784	94784	0	0.0
			.data	852	852	0	0.0
			.text	584080	584088	8	0.0

github-actions · 2023-05-03T08:27:32Z

PR #26332: Size comparison from 3902c35 to 590c0b9

Increases above 0.2%:

platform	target	config	section	`3902c35`	`590c0b9`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_frame	341304	342140	836	0.2
			.debug_info	19518671	19584991	66320	0.3
			.debug_line	2665797	2671527	5730	0.2
			.debug_str	3069486	`3092126`	22640	0.7

Increases (1 build for cc32xx)

platform	target	config	section	`3902c35`	`590c0b9`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	(read only)	604450	604490	40	0.0
			.debug_aranges	101088	101288	200	0.2
			.debug_frame	341304	342140	836	0.2
			.debug_info	19518671	19584991	66320	0.3
			.debug_line	2665797	2671527	5730	0.2
			.debug_loclists	`1487495`	1489861	2366	0.2
			.debug_rnglists	94265	94440	175	0.2
			.debug_str	3069486	`3092126`	22640	0.7
			.symtab	287024	287056	32	0.0
			.text	498028	498068	40	0.0

Full report (1 build for cc32xx)

platform	target	config	section	`3902c35`	`590c0b9`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0	0.0
			(read only)	604450	604490	40	0.0
			(read/write)	204156	204156	0	0.0
			.ARM.attributes	44	44	0	0.0
			.ARM.exidx	8	8	0	0.0
			.bss	197568	197568	0	0.0
			.comment	206	206	0	0.0
			.data	1468	1468	0	0.0
			.debug_abbrev	956917	956917	0	0.0
			.debug_aranges	101088	101288	200	0.2
			.debug_frame	341304	342140	836	0.2
			.debug_info	19518671	19584991	66320	0.3
			.debug_line	2665797	2671527	5730	0.2
			.debug_line_str	513	513	0	0.0
			.debug_loc	33340	33340	0	0.0
			.debug_loclists	`1487495`	1489861	2366	0.2
			.debug_ranges	4984	4984	0	0.0
			.debug_rnglists	94265	94440	175	0.2
			.debug_str	3069486	`3092126`	22640	0.7
			.ramVecs	780	780	0	0.0
			.resetVecs	64	64	0	0.0
			.rodata	104298	104298	0	0.0
			.shstrtab	265	265	0	0.0
			.stack	2048	2048	0	0.0
			.strtab	480350	480350	0	0.0
			.symtab	287024	287056	32	0.0
			.text	498028	498068	40	0.0

src/app/zap-templates/zcl/data-model/chip/time-synchronization-cluster.xml

github-actions · 2023-05-03T14:32:44Z

PR #26332: Size comparison from 3902c35 to c52cc89

Increases above 0.2%:

platform	target	config	section	`3902c35`	`c52cc89`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_frame	341304	342140	836	0.2
			.debug_info	19518671	19584990	66319	0.3
			.debug_line	2665797	2671527	5730	0.2
			.debug_str	3069486	`3092126`	22640	0.7

Increases (1 build for cc32xx)

platform	target	config	section	`3902c35`	`c52cc89`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	(read only)	604450	604490	40	0.0
			.debug_aranges	101088	101288	200	0.2
			.debug_frame	341304	342140	836	0.2
			.debug_info	19518671	19584990	66319	0.3
			.debug_line	2665797	2671527	5730	0.2
			.debug_loclists	`1487495`	1489861	2366	0.2
			.debug_rnglists	94265	94440	175	0.2
			.debug_str	3069486	`3092126`	22640	0.7
			.symtab	287024	287056	32	0.0
			.text	498028	498068	40	0.0

Full report (1 build for cc32xx)

platform	target	config	section	`3902c35`	`c52cc89`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0	0.0
			(read only)	604450	604490	40	0.0
			(read/write)	204156	204156	0	0.0
			.ARM.attributes	44	44	0	0.0
			.ARM.exidx	8	8	0	0.0
			.bss	197568	197568	0	0.0
			.comment	206	206	0	0.0
			.data	1468	1468	0	0.0
			.debug_abbrev	956917	956917	0	0.0
			.debug_aranges	101088	101288	200	0.2
			.debug_frame	341304	342140	836	0.2
			.debug_info	19518671	19584990	66319	0.3
			.debug_line	2665797	2671527	5730	0.2
			.debug_line_str	513	513	0	0.0
			.debug_loc	33340	33340	0	0.0
			.debug_loclists	`1487495`	1489861	2366	0.2
			.debug_ranges	4984	4984	0	0.0
			.debug_rnglists	94265	94440	175	0.2
			.debug_str	3069486	`3092126`	22640	0.7
			.ramVecs	780	780	0	0.0
			.resetVecs	64	64	0	0.0
			.rodata	104298	104298	0	0.0
			.shstrtab	265	265	0	0.0
			.stack	2048	2048	0	0.0
			.strtab	480350	480350	0	0.0
			.symtab	287024	287056	32	0.0
			.text	498028	498068	40	0.0

src/app/zap-templates/zcl/zcl.json

added attribute access interface handled attributes GNSS Co-authored-by: Boris Zbarsky <[email protected]> TrustedTimeSource is optional with TSC feature Co-authored-by: Boris Zbarsky <[email protected]> SetUTCTime Co-authored-by: Boris Zbarsky <[email protected]> SetTrustedTimeSource is optional Co-authored-by: Boris Zbarsky <[email protected]> UTCTime Co-authored-by: Boris Zbarsky <[email protected]> TimeZoneDatabase default 2 (None) MissingTrustedTimeSource is optional regenerate code update default values

github-actions · 2023-05-05T12:58:18Z

PR #26332: Size comparison from 3d21708 to c843519

Increases above 0.2%:

platform	target	config	section	`3d21708`	`c843519`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_frame	341416	342252	836	0.2
			.debug_info	19603114	19669648	66534	0.3
			.debug_line	2666235	`2671963`	5728	0.2
			.debug_str	3108084	3131275	23191	0.7

Increases (1 build for cc32xx)

platform	target	config	section	`3d21708`	`c843519`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	(read only)	604866	604906	40	0.0
			.debug_aranges	101104	101304	200	0.2
			.debug_frame	341416	342252	836	0.2
			.debug_info	19603114	19669648	66534	0.3
			.debug_line	2666235	`2671963`	5728	0.2
			.debug_loclists	1488792	1491129	2337	0.2
			.debug_rnglists	94291	94466	175	0.2
			.debug_str	3108084	3131275	23191	0.7
			.symtab	287120	287152	32	0.0
			.text	498396	498436	40	0.0

Full report (1 build for cc32xx)

platform	target	config	section	`3d21708`	`c843519`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0	0.0
			(read only)	604866	604906	40	0.0
			(read/write)	204156	204156	0	0.0
			.ARM.attributes	44	44	0	0.0
			.ARM.exidx	8	8	0	0.0
			.bss	197568	197568	0	0.0
			.comment	206	206	0	0.0
			.data	1468	1468	0	0.0
			.debug_abbrev	957098	957098	0	0.0
			.debug_aranges	101104	101304	200	0.2
			.debug_frame	341416	342252	836	0.2
			.debug_info	19603114	19669648	66534	0.3
			.debug_line	2666235	`2671963`	5728	0.2
			.debug_line_str	513	513	0	0.0
			.debug_loc	33340	33340	0	0.0
			.debug_loclists	1488792	1491129	2337	0.2
			.debug_ranges	4984	4984	0	0.0
			.debug_rnglists	94291	94466	175	0.2
			.debug_str	3108084	3131275	23191	0.7
			.ramVecs	780	780	0	0.0
			.resetVecs	64	64	0	0.0
			.rodata	104346	104346	0	0.0
			.shstrtab	265	265	0	0.0
			.stack	2048	2048	0	0.0
			.strtab	482872	482872	0	0.0
			.symtab	287120	287152	32	0.0
			.text	498396	498436	40	0.0

src/app/zap-templates/zcl/data-model/chip/time-synchronization-cluster.xml

Signed-off-by: Fesseha <[email protected]>

This aims to as much as possible undo the changes from project-chip#26332 to Darwin generated code, by listing the set of renames and then marking almost all the new names provisional. The two exceptions are: 1) The attributes that got renamed, for which the codegen sets the old id constants equal to the new id constants, so we have to generate the new id constants. 2) The nullability change for validUntil in DSTOffsetStruct, which we have no way to make conditional based on availability.

…es. (#26436) This aims to as much as possible undo the changes from #26332 to Darwin generated code, by listing the set of renames and then marking almost all the new names provisional. The two exceptions are: 1) The attributes that got renamed, for which the codegen sets the old id constants equal to the new id constants, so we have to generate the new id constants. 2) The nullability change for validUntil in DSTOffsetStruct, which we have no way to make conditional based on availability.

github-actions bot added app controller darwin labels May 2, 2023

pullapprove bot requested a review from yunhanw-google May 2, 2023 14:55

fessehaeve requested a review from cecille May 2, 2023 15:18

fessehaeve force-pushed the pull-request/time-synchronization-xml branch from c18b8e4 to e9224ac Compare May 2, 2023 16:25

bzbarsky-apple reviewed May 2, 2023

View reviewed changes

fessehaeve force-pushed the pull-request/time-synchronization-xml branch from ebc26ff to 590c0b9 Compare May 3, 2023 08:17