-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
time synchronization cluster #26082
time synchronization cluster #26082
Conversation
1ad2c0a
to
6066ef3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(sorry, added some comments in the .matter file that actually relate to the xml since it's generated.)
examples/all-clusters-app/all-clusters-common/all-clusters-app.matter
Outdated
Show resolved
Hide resolved
examples/all-clusters-app/all-clusters-common/all-clusters-app.matter
Outdated
Show resolved
Hide resolved
src/app/clusters/time-synchronization-server/TimeSyncDataProvider.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/time-synchronization-server/TimeSyncDataProvider.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/time-synchronization-server/time-synchronization-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/time-synchronization-server/time-synchronization-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/time-synchronization-server/time-synchronization-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/time-synchronization-server/time-synchronization-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/time-synchronization-server/time-synchronization-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/time-synchronization-server/time-synchronization-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/time-synchronization-server/time-synchronization-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/time-synchronization-server/time-synchronization-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/time-synchronization-server/time-synchronization-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/time-synchronization-server/time-synchronization-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/time-synchronization-server/time-synchronization-server.h
Outdated
Show resolved
Hide resolved
src/app/clusters/time-synchronization-server/time-synchronization-server.h
Outdated
Show resolved
Hide resolved
src/app/clusters/time-synchronization-server/time-synchronization-server.h
Outdated
Show resolved
Hide resolved
src/app/clusters/time-synchronization-server/time-synchronization-server.h
Outdated
Show resolved
Hide resolved
src/app/clusters/time-synchronization-server/time-synchronization-server.h
Outdated
Show resolved
Hide resolved
c4268f1
to
01e7d5b
Compare
src/app/clusters/time-synchronization-server/TimeSyncManager.cpp
Outdated
Show resolved
Hide resolved
01e7d5b
to
f07c725
Compare
PR #26082: Size comparison from fa505f6 to f07c725 Increases above 0.2%:
Increases (1 build for cc32xx)
Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
PR #26082: Size comparison from fa505f6 to d31ca28 Increases above 0.2%:
Increases (1 build for cc32xx)
Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
PR #26082: Size comparison from fa505f6 to ac2f0c9 Increases above 0.2%:
Increases (1 build for cc32xx)
Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
PR #26082: Size comparison from fa505f6 to ada9180 Increases above 0.2%:
Increases (1 build for cc32xx)
Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
Co-authored-by: C Freeman <[email protected]>
src/app/clusters/time-synchronization-server/TimeSyncDataProvider.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/time-synchronization-server/TimeSyncDataProvider.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/time-synchronization-server/TimeSyncDataProvider.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/time-synchronization-server/TimeSyncDataProvider.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/time-synchronization-server/TimeSyncDataProvider.h
Outdated
Show resolved
Hide resolved
src/app/clusters/time-synchronization-server/time-synchronization-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/time-synchronization-server/time-synchronization-server.cpp
Show resolved
Hide resolved
src/app/clusters/time-synchronization-server/time-synchronization-delegate.h
Outdated
Show resolved
Hide resolved
src/app/clusters/time-synchronization-server/time-synchronization-delegate.h
Outdated
Show resolved
Hide resolved
src/app/clusters/time-synchronization-server/time-synchronization-server.cpp
Show resolved
Hide resolved
PR #26082: Size comparison from a7edf3d to 23dd47e Increases above 0.2%:
Increases (21 builds for cyw30739, esp32, linux, nrfconnect, psoc6, qpg, telink)
Decreases (9 builds for bl702, bl702l, cc32xx, psoc6, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #26082: Size comparison from a7edf3d to e57c01e Increases above 0.2%:
Increases (20 builds for bl702l, cyw30739, esp32, linux, nrfconnect, psoc6, qpg, telink)
Decreases (13 builds for bl602, bl702, bl702l, cc32xx, psoc6, qpg, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow up issues are tracked in #27575. I believe there is only one unresolved issue here:
#26082 (comment)
I am good with this going in now with followups later once that issue is resolved. I do think the linked issue is a blocker because the zap check ran before the matter file generation update - I want to make sure this doesn't cause a zap CI breaks on ToT.
…_r1240951613 Do not see a way to avoid reloading project-chip#26082 (comment)
…_r1240951613 Do not see a way to avoid reloading project-chip#26082 (comment)
time synchronisation cluster implementation