Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn off the Basic Information Reachable attribute in examples. #26331

Merged
merged 1 commit into from
May 5, 2023
Merged

Turn off the Basic Information Reachable attribute in examples. #26331

merged 1 commit into from
May 5, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

This is really only meant to be used for Bridged Device Basic Information, not the Basic Information cluster.

Fixes #18083

@pullapprove pullapprove bot removed the examples label May 2, 2023
@github-actions
Copy link

github-actions bot commented May 2, 2023

PR #26331: Size comparison from f587c34 to dcd7fe9

Decreases (1 build for cc32xx)
platform target config section f587c34 dcd7fe9 change % change
cc32xx lock CC3235SF_LAUNCHXL (read only) 604042 604034 -8 -0.0
.debug_info 19559511 19559509 -2 -0.0
.rodata 104282 104274 -8 -0.0
Full report (1 build for cc32xx)
platform target config section f587c34 dcd7fe9 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 604042 604034 -8 -0.0
(read/write) 204156 204156 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197568 197568 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 956764 956764 0 0.0
.debug_aranges 103240 103240 0 0.0
.debug_frame 349432 349432 0 0.0
.debug_info 19559511 19559509 -2 -0.0
.debug_line 2687404 2687404 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1515630 1515630 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 95966 95966 0 0.0
.debug_str 3082308 3082308 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104282 104274 -8 -0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 479192 479192 0 0.0
.symtab 286736 286736 0 0.0
.text 497636 497636 0 0.0

@github-actions
Copy link

github-actions bot commented May 2, 2023

PR #26331: Size comparison from 7be1954 to 907b39f

Decreases (1 build for cc32xx)
platform target config section 7be1954 907b39f change % change
cc32xx lock CC3235SF_LAUNCHXL (read only) 604426 604418 -8 -0.0
.rodata 104298 104290 -8 -0.0
Full report (1 build for cc32xx)
platform target config section 7be1954 907b39f change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 604426 604418 -8 -0.0
(read/write) 204156 204156 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197568 197568 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 956872 956872 0 0.0
.debug_aranges 101056 101056 0 0.0
.debug_frame 341168 341168 0 0.0
.debug_info 19511285 19511285 0 0.0
.debug_line 2664965 2664965 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1486884 1486884 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 94239 94239 0 0.0
.debug_str 3068127 3068127 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104298 104290 -8 -0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 480350 480350 0 0.0
.symtab 287024 287024 0 0.0
.text 498004 498004 0 0.0

@bzbarsky-apple
Turn off the Basic Information Reachable attribute in examples.
6086cab 
This is really only meant to be used for Bridged Device Basic Information, not
the Basic Information cluster.

Fixes project-chip#18083
@github-actions
Copy link

github-actions bot commented May 2, 2023

PR #26331: Size comparison from 7be1954 to 6086cab

Decreases (1 build for cc32xx)
platform target config section 7be1954 6086cab change % change
cc32xx lock CC3235SF_LAUNCHXL (read only) 604426 604418 -8 -0.0
.debug_info 19511285 19511284 -1 -0.0
.rodata 104298 104290 -8 -0.0
Full report (1 build for cc32xx)
platform target config section 7be1954 6086cab change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 604426 604418 -8 -0.0
(read/write) 204156 204156 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197568 197568 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 956872 956872 0 0.0
.debug_aranges 101056 101056 0 0.0
.debug_frame 341168 341168 0 0.0
.debug_info 19511285 19511284 -1 -0.0
.debug_line 2664965 2664965 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1486884 1486884 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 94239 94239 0 0.0
.debug_str 3068127 3068127 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104298 104290 -8 -0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 480350 480350 0 0.0
.symtab 287024 287024 0 0.0
.text 498004 498004 0 0.0

@andy31415 andy31415 merged commit 662a5e6 into project-chip:master May 5, 2023
@bzbarsky-apple bzbarsky-apple deleted the turn-off-reachable branch May 5, 2023 18:48
@erwinpan1 erwinpan1 mentioned this pull request May 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@andy31415 andy31415 Awaiting requested review from andy31415

@arkq arkq Awaiting requested review from arkq

Assignees
No one assigned
Labels
app examples review - approved tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable "Reachable" attribute in Basic Information clusters of example apps
3 participants
@bzbarsky-apple @andy31415 @arkq