Skip to content

Commit

Permalink
Turn off the Basic Information Reachable attribute in examples.
Browse files Browse the repository at this point in the history
This is really only meant to be used for Bridged Device Basic Information, not
the Basic Information cluster.

Fixes #18083
  • Loading branch information
bzbarsky-apple committed May 2, 2023
1 parent fa505f6 commit 06bb152
Show file tree
Hide file tree
Showing 50 changed files with 171 additions and 207 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -739,7 +739,6 @@ server cluster BasicInformation = 40 {
readonly attribute char_string<64> productLabel = 14;
readonly attribute char_string<32> serialNumber = 15;
attribute access(write: manage) boolean localConfigDisabled = 16;
readonly attribute boolean reachable = 17;
readonly attribute char_string<32> uniqueID = 18;
readonly attribute CapabilityMinimaStruct capabilityMinima = 19;
readonly attribute command_id generatedCommandList[] = 65528;
Expand Down Expand Up @@ -4641,7 +4640,6 @@ endpoint 0 {
callback attribute productLabel;
callback attribute serialNumber;
persist attribute localConfigDisabled default = 0;
ram attribute reachable default = 1;
callback attribute uniqueID;
callback attribute capabilityMinima;
ram attribute featureMap default = 0;
Expand Down
19 changes: 10 additions & 9 deletions examples/all-clusters-app/all-clusters-common/all-clusters-app.zap
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"featureLevel": 92,
"featureLevel": 96,
"creator": "zap",
"keyValuePairs": [
{
Expand All @@ -16,19 +16,19 @@
}
],
"package": [
{
"pathRelativity": "relativeToZap",
"path": "../../../src/app/zap-templates/app-templates.json",
"type": "gen-templates-json",
"version": "chip-v1"
},
{
"pathRelativity": "relativeToZap",
"path": "../../../src/app/zap-templates/zcl/zcl-with-test-extensions.json",
"type": "zcl-properties",
"category": "matter",
"version": 1,
"description": "Matter SDK ZCL data with some extensions"
},
{
"pathRelativity": "relativeToZap",
"path": "../../../src/app/zap-templates/app-templates.json",
"type": "gen-templates-json",
"version": "chip-v1"
}
],
"endpointTypes": [
Expand Down Expand Up @@ -1466,7 +1466,7 @@
"mfgCode": null,
"side": "server",
"type": "boolean",
"included": 1,
"included": 0,
"storageOption": "RAM",
"singleton": 1,
"bounded": 0,
Expand Down Expand Up @@ -25498,5 +25498,6 @@
"endpointVersion": 1,
"deviceIdentifier": 61442
}
]
],
"log": []
}
2 changes: 0 additions & 2 deletions examples/bridge-app/bridge-common/bridge-app.matter
Original file line number Diff line number Diff line change
Expand Up @@ -526,7 +526,6 @@ server cluster BasicInformation = 40 {
readonly attribute char_string<64> productLabel = 14;
readonly attribute char_string<32> serialNumber = 15;
attribute access(write: manage) boolean localConfigDisabled = 16;
readonly attribute boolean reachable = 17;
readonly attribute char_string<32> uniqueID = 18;
readonly attribute CapabilityMinimaStruct capabilityMinima = 19;
readonly attribute command_id generatedCommandList[] = 65528;
Expand Down Expand Up @@ -1622,7 +1621,6 @@ endpoint 0 {
callback attribute productLabel;
callback attribute serialNumber;
persist attribute localConfigDisabled default = 0;
ram attribute reachable default = 1;
callback attribute uniqueID;
callback attribute capabilityMinima;
callback attribute generatedCommandList;
Expand Down
7 changes: 4 additions & 3 deletions examples/bridge-app/bridge-common/bridge-app.zap
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"featureLevel": 92,
"featureLevel": 96,
"creator": "zap",
"keyValuePairs": [
{
Expand Down Expand Up @@ -783,7 +783,7 @@
"mfgCode": null,
"side": "server",
"type": "boolean",
"included": 1,
"included": 0,
"storageOption": "RAM",
"singleton": 1,
"bounded": 0,
Expand Down Expand Up @@ -7625,5 +7625,6 @@
"endpointVersion": 1,
"deviceIdentifier": 257
}
]
],
"log": []
}
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,6 @@ server cluster BasicInformation = 40 {
readonly attribute char_string<64> productLabel = 14;
readonly attribute char_string<32> serialNumber = 15;
attribute access(write: manage) boolean localConfigDisabled = 16;
readonly attribute boolean reachable = 17;
readonly attribute char_string<32> uniqueID = 18;
readonly attribute CapabilityMinimaStruct capabilityMinima = 19;
readonly attribute command_id generatedCommandList[] = 65528;
Expand Down Expand Up @@ -1480,7 +1479,6 @@ endpoint 0 {
callback attribute productLabel;
callback attribute serialNumber;
persist attribute localConfigDisabled default = 0;
ram attribute reachable default = 1;
callback attribute uniqueID;
callback attribute capabilityMinima;
ram attribute featureMap default = 0;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"featureLevel": 92,
"featureLevel": 96,
"creator": "zap",
"keyValuePairs": [
{
Expand Down Expand Up @@ -1460,7 +1460,7 @@
"mfgCode": null,
"side": "server",
"type": "boolean",
"included": 1,
"included": 0,
"storageOption": "RAM",
"singleton": 1,
"bounded": 0,
Expand Down Expand Up @@ -8785,5 +8785,6 @@
"endpointVersion": 1,
"deviceIdentifier": 21
}
]
],
"log": []
}
2 changes: 0 additions & 2 deletions examples/dynamic-bridge-app/bridge-common/bridge-app.matter
Original file line number Diff line number Diff line change
Expand Up @@ -526,7 +526,6 @@ server cluster BasicInformation = 40 {
readonly attribute char_string<64> productLabel = 14;
readonly attribute char_string<32> serialNumber = 15;
attribute access(write: manage) boolean localConfigDisabled = 16;
readonly attribute boolean reachable = 17;
readonly attribute char_string<32> uniqueID = 18;
readonly attribute CapabilityMinimaStruct capabilityMinima = 19;
readonly attribute command_id generatedCommandList[] = 65528;
Expand Down Expand Up @@ -1623,7 +1622,6 @@ endpoint 0 {
callback attribute productLabel;
callback attribute serialNumber;
persist attribute localConfigDisabled default = 0;
ram attribute reachable default = 1;
callback attribute uniqueID;
callback attribute capabilityMinima;
callback attribute generatedCommandList;
Expand Down
7 changes: 4 additions & 3 deletions examples/dynamic-bridge-app/bridge-common/bridge-app.zap
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"featureLevel": 92,
"featureLevel": 96,
"creator": "zap",
"keyValuePairs": [
{
Expand Down Expand Up @@ -790,7 +790,7 @@
"mfgCode": null,
"side": "server",
"type": "boolean",
"included": 1,
"included": 0,
"storageOption": "RAM",
"singleton": 1,
"bounded": 0,
Expand Down Expand Up @@ -7614,5 +7614,6 @@
"endpointVersion": 1,
"deviceIdentifier": 257
}
]
],
"log": []
}
Original file line number Diff line number Diff line change
Expand Up @@ -563,7 +563,6 @@ server cluster BasicInformation = 40 {
readonly attribute char_string<64> productLabel = 14;
readonly attribute char_string<32> serialNumber = 15;
attribute access(write: manage) boolean localConfigDisabled = 16;
readonly attribute boolean reachable = 17;
readonly attribute char_string<32> uniqueID = 18;
readonly attribute CapabilityMinimaStruct capabilityMinima = 19;
readonly attribute command_id generatedCommandList[] = 65528;
Expand Down Expand Up @@ -2113,7 +2112,6 @@ endpoint 0 {
callback attribute productLabel;
callback attribute serialNumber;
persist attribute localConfigDisabled default = 0;
ram attribute reachable default = 1;
callback attribute uniqueID;
callback attribute capabilityMinima;
ram attribute featureMap default = 0;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"featureLevel": 92,
"featureLevel": 96,
"creator": "zap",
"keyValuePairs": [
{
Expand Down Expand Up @@ -1508,7 +1508,7 @@
"mfgCode": null,
"side": "server",
"type": "boolean",
"included": 1,
"included": 0,
"storageOption": "RAM",
"singleton": 1,
"bounded": 0,
Expand Down Expand Up @@ -9556,5 +9556,6 @@
"endpointVersion": 1,
"deviceIdentifier": 15
}
]
],
"log": []
}
Original file line number Diff line number Diff line change
Expand Up @@ -425,7 +425,6 @@ server cluster BasicInformation = 40 {
readonly attribute char_string<64> productLabel = 14;
readonly attribute char_string<32> serialNumber = 15;
attribute access(write: manage) boolean localConfigDisabled = 16;
readonly attribute boolean reachable = 17;
readonly attribute char_string<32> uniqueID = 18;
readonly attribute CapabilityMinimaStruct capabilityMinima = 19;
readonly attribute command_id generatedCommandList[] = 65528;
Expand Down Expand Up @@ -1859,7 +1858,6 @@ endpoint 0 {
callback attribute productLabel;
callback attribute serialNumber;
persist attribute localConfigDisabled default = 0;
ram attribute reachable default = 1;
callback attribute uniqueID;
callback attribute capabilityMinima;
ram attribute featureMap default = 0;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"featureLevel": 95,
"featureLevel": 96,
"creator": "zap",
"keyValuePairs": [
{
Expand Down Expand Up @@ -1460,7 +1460,7 @@
"mfgCode": null,
"side": "server",
"type": "boolean",
"included": 1,
"included": 0,
"storageOption": "RAM",
"singleton": 1,
"bounded": 0,
Expand Down Expand Up @@ -8343,4 +8343,4 @@
}
],
"log": []
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -425,7 +425,6 @@ server cluster BasicInformation = 40 {
readonly attribute char_string<64> productLabel = 14;
readonly attribute char_string<32> serialNumber = 15;
attribute access(write: manage) boolean localConfigDisabled = 16;
readonly attribute boolean reachable = 17;
readonly attribute char_string<32> uniqueID = 18;
readonly attribute CapabilityMinimaStruct capabilityMinima = 19;
readonly attribute command_id generatedCommandList[] = 65528;
Expand Down Expand Up @@ -1768,7 +1767,6 @@ endpoint 0 {
callback attribute productLabel;
callback attribute serialNumber;
persist attribute localConfigDisabled default = 0;
ram attribute reachable default = 1;
callback attribute uniqueID;
callback attribute capabilityMinima;
ram attribute featureMap default = 0;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"featureLevel": 95,
"featureLevel": 96,
"creator": "zap",
"keyValuePairs": [
{
Expand Down Expand Up @@ -1460,7 +1460,7 @@
"mfgCode": null,
"side": "server",
"type": "boolean",
"included": 1,
"included": 0,
"storageOption": "RAM",
"singleton": 1,
"bounded": 0,
Expand Down Expand Up @@ -8343,4 +8343,4 @@
}
],
"log": []
}
}
2 changes: 0 additions & 2 deletions examples/lighting-app/lighting-common/lighting-app.matter
Original file line number Diff line number Diff line change
Expand Up @@ -425,7 +425,6 @@ server cluster BasicInformation = 40 {
readonly attribute char_string<64> productLabel = 14;
readonly attribute char_string<32> serialNumber = 15;
attribute access(write: manage) boolean localConfigDisabled = 16;
readonly attribute boolean reachable = 17;
readonly attribute char_string<32> uniqueID = 18;
readonly attribute CapabilityMinimaStruct capabilityMinima = 19;
readonly attribute command_id generatedCommandList[] = 65528;
Expand Down Expand Up @@ -1955,7 +1954,6 @@ endpoint 0 {
callback attribute productLabel;
callback attribute serialNumber;
persist attribute localConfigDisabled default = 0;
ram attribute reachable default = 1;
callback attribute uniqueID;
callback attribute capabilityMinima;
ram attribute featureMap default = 0;
Expand Down
9 changes: 5 additions & 4 deletions examples/lighting-app/lighting-common/lighting-app.zap
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"featureLevel": 92,
"featureLevel": 96,
"creator": "zap",
"keyValuePairs": [
{
Expand Down Expand Up @@ -1460,7 +1460,7 @@
"mfgCode": null,
"side": "server",
"type": "boolean",
"included": 1,
"included": 0,
"storageOption": "RAM",
"singleton": 1,
"bounded": 0,
Expand Down Expand Up @@ -7041,7 +7041,7 @@
"mfgCode": null,
"side": "server",
"type": "boolean",
"included": 1,
"included": 0,
"storageOption": "RAM",
"singleton": 1,
"bounded": 0,
Expand Down Expand Up @@ -8341,5 +8341,6 @@
"endpointVersion": 1,
"deviceIdentifier": 257
}
]
],
"log": []
}
2 changes: 0 additions & 2 deletions examples/lighting-app/qpg/zap/light.matter
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,6 @@ server cluster BasicInformation = 40 {
readonly attribute char_string<64> productLabel = 14;
readonly attribute char_string<32> serialNumber = 15;
attribute access(write: manage) boolean localConfigDisabled = 16;
readonly attribute boolean reachable = 17;
readonly attribute char_string<32> uniqueID = 18;
readonly attribute CapabilityMinimaStruct capabilityMinima = 19;
readonly attribute command_id generatedCommandList[] = 65528;
Expand Down Expand Up @@ -1720,7 +1719,6 @@ endpoint 0 {
callback attribute productLabel;
callback attribute serialNumber;
persist attribute localConfigDisabled default = 0;
ram attribute reachable default = 1;
callback attribute uniqueID;
callback attribute capabilityMinima;
callback attribute generatedCommandList;
Expand Down
4 changes: 2 additions & 2 deletions examples/lighting-app/qpg/zap/light.zap
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"featureLevel": 92,
"featureLevel": 96,
"creator": "zap",
"keyValuePairs": [
{
Expand Down Expand Up @@ -1572,7 +1572,7 @@
"mfgCode": null,
"side": "server",
"type": "boolean",
"included": 1,
"included": 0,
"storageOption": "RAM",
"singleton": 1,
"bounded": 0,
Expand Down
Loading

0 comments on commit 06bb152

Please sign in to comment.