-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs] Fix compilation issues with gcc 12.2 #26090
Merged
andy31415
merged 4 commits into
project-chip:master
from
jmartinez-silabs:fix/array-parameter
Apr 13, 2023
Merged
[Silabs] Fix compilation issues with gcc 12.2 #26090
andy31415
merged 4 commits into
project-chip:master
from
jmartinez-silabs:fix/array-parameter
Apr 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kkasperczyk-no
April 13, 2023 18:44
pullapprove
bot
requested review from
mlepage-google,
mrjerryjohns,
msandstedt,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
April 13, 2023 18:44
PR #26090: Size comparison from a235160 to 2220dd6 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
bzbarsky-apple
approved these changes
Apr 13, 2023
PR #26090: Size comparison from a235160 to 52c8a85 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
jmartinez-silabs
force-pushed
the
fix/array-parameter
branch
from
April 13, 2023 19:55
52c8a85
to
3988557
Compare
PR #26090: Size comparison from e1f306f to 3988557 Increases (3 builds for bl702, cc13x2_26x2, psoc6)
Decreases (9 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, psoc6)
Full report (26 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, k32w, linux, psoc6, qpg)
|
andy31415
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also deactivate the error flag on the array parameter warning "-Wno-error=array-parameter" until this can be fixed on a silabs GSDK release
EDIT: the flags disabling is commented out for now as they do not exist in the current gcc version used. Uncomment those two when pw update rolls out