Skip to content

Commit

Permalink
Align Data Model and Interaction Model revisions with spec. (#28645)
Browse files Browse the repository at this point in the history
  • Loading branch information
bzbarsky-apple authored and pull[bot] committed Oct 17, 2023
1 parent 03bb022 commit 1559880
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 8 deletions.
5 changes: 4 additions & 1 deletion src/app/DataModelRevision.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,10 @@
*
* A monotonic number identifying the revision number of the Data Model against
* which the Node is certified.
*
* See section 7.1.1. "Revision History" in the "Data Model Specification"
* chapter of the core Matter specification.
*/
#ifndef CHIP_DEVICE_DATA_MODEL_REVISION
#define CHIP_DEVICE_DATA_MODEL_REVISION 1
#define CHIP_DEVICE_DATA_MODEL_REVISION 17
#endif
5 changes: 4 additions & 1 deletion src/app/InteractionModelRevision.h
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,12 @@
* CHIP_DEVICE_INTERACTION_MODEL_REVISION
*
* A monothonic number identifying the interaction model revision.
*
* See section 8.1.1. "Revision History" in the "Interaction Model
* Specification" chapter of the core Matter specification.
*/
#ifndef CHIP_DEVICE_INTERACTION_MODEL_REVISION
#define CHIP_DEVICE_INTERACTION_MODEL_REVISION 1
#define CHIP_DEVICE_INTERACTION_MODEL_REVISION 10
#endif

constexpr uint8_t kInteractionModelRevisionTag = 0xFF;
4 changes: 2 additions & 2 deletions src/app/tests/suites/TestCASERecovery.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ tests:
command: "readAttribute"
attribute: "DataModelRevision"
response:
value: 1
value: 17

- label: "Reboot the server"
cluster: "SystemCommands"
Expand Down Expand Up @@ -72,4 +72,4 @@ tests:
command: "readAttribute"
attribute: "DataModelRevision"
response:
value: 1
value: 17
4 changes: 2 additions & 2 deletions zzz_generated/chip-tool/zap-generated/test/Commands.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 1559880

Please sign in to comment.