-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable_fuzz_test_targets should default to false if chip_build_tests is false. #26067
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:fuzz_test_targets_no_tests
Apr 14, 2023
Merged
enable_fuzz_test_targets should default to false if chip_build_tests is false. #26067
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:fuzz_test_targets_no_tests
Apr 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #26067: Size comparison from 00e5976 to 89fe368 Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
89fe368
to
0394a27
Compare
…is false. When enable_fuzz_test_targets is true, we end up pulling in things that assert chip_build_tests is true.
0394a27
to
36dc086
Compare
PR #26067: Size comparison from 2ce04b5 to 36dc086 Full report (3 builds for cc32xx, qpg)
|
vivien-apple
approved these changes
Apr 13, 2023
andy31415
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When enable_fuzz_test_targets is true, we end up pulling in things that assert chip_build_tests is true.