Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable_fuzz_test_targets should default to false if chip_build_tests is false. #26067

Merged

Conversation

bzbarsky-apple
Copy link
Contributor

When enable_fuzz_test_targets is true, we end up pulling in things that assert chip_build_tests is true.

@github-actions github-actions bot added the gn label Apr 12, 2023
@github-actions
Copy link

PR #26067: Size comparison from 00e5976 to 89fe368

Decreases (1 build for cc32xx)
platform target config section 00e5976 89fe368 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20303347 20303346 -1 -0.0
Full report (1 build for cc32xx)
platform target config section 00e5976 89fe368 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642953 642953 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933129 933129 0 0.0
.debug_aranges 87616 87616 0 0.0
.debug_frame 301352 301352 0 0.0
.debug_info 20303347 20303346 -1 -0.0
.debug_line 2679969 2679969 0 0.0
.debug_loc 2824782 2824782 0 0.0
.debug_ranges 286208 286208 0 0.0
.debug_str 3039567 3039567 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104353 104353 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377533 377533 0 0.0
.symtab 256800 256800 0 0.0
.text 536480 536480 0 0.0

…is false.

When enable_fuzz_test_targets is true, we end up pulling in things that assert
chip_build_tests is true.
@bzbarsky-apple bzbarsky-apple force-pushed the fuzz_test_targets_no_tests branch from 0394a27 to 36dc086 Compare April 12, 2023 16:50
@github-actions
Copy link

PR #26067: Size comparison from 2ce04b5 to 36dc086

Full report (3 builds for cc32xx, qpg)
platform target config section 2ce04b5 36dc086 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642953 642953 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933129 933129 0 0.0
.debug_aranges 87616 87616 0 0.0
.debug_frame 301352 301352 0 0.0
.debug_info 20303348 20303348 0 0.0
.debug_line 2679969 2679969 0 0.0
.debug_loc 2824782 2824782 0 0.0
.debug_ranges 286208 286208 0 0.0
.debug_str 3039567 3039567 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104353 104353 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377533 377533 0 0.0
.symtab 256800 256800 0 0.0
.text 536480 536480 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1154764 1154764 0 0.0
.bss 97404 97404 0 0.0
.data 836 836 0 0.0
.text 601860 601860 0 0.0
lock-app qpg6105+debug (read/write) 1124844 1124844 0 0.0
.bss 92548 92548 0 0.0
.data 840 840 0 0.0
.text 571944 571944 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit 617ed43 into project-chip:master Apr 14, 2023
@bzbarsky-apple bzbarsky-apple deleted the fuzz_test_targets_no_tests branch April 14, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants