Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[darwin-framework-tool] Add is_asan proper supports #26014

Merged

Conversation

vivien-apple
Copy link
Contributor

Problem

When darwin-framework-tool is built with is_asan=true or is_tsan=true those are not properly carried over to the framework build.

@github-actions
Copy link

github-actions bot commented Apr 7, 2023

PR #26014: Size comparison from 6eded52 to 9ece407

Decreases (1 build for cc32xx)
platform target config section 6eded52 9ece407 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20302992 20302990 -2 -0.0
Full report (1 build for cc32xx)
platform target config section 6eded52 9ece407 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642745 642745 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933119 933119 0 0.0
.debug_aranges 87608 87608 0 0.0
.debug_frame 301328 301328 0 0.0
.debug_info 20302992 20302990 -2 -0.0
.debug_line 2679759 2679759 0 0.0
.debug_loc 2824679 2824679 0 0.0
.debug_ranges 286200 286200 0 0.0
.debug_str 3039406 3039406 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104289 104289 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377422 377422 0 0.0
.symtab 256768 256768 0 0.0
.text 536336 536336 0 0.0

@vivien-apple vivien-apple force-pushed the DFT_asan_tsan_proper_supports branch from 9ece407 to 94a77e8 Compare April 7, 2023 14:00
scripts/build/build_darwin_framework.py Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Apr 7, 2023

PR #26014: Size comparison from 6eded52 to 6b519f9

Full report (1 build for cc32xx)
platform target config section 6eded52 6b519f9 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642745 642745 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933119 933119 0 0.0
.debug_aranges 87608 87608 0 0.0
.debug_frame 301328 301328 0 0.0
.debug_info 20302992 20302992 0 0.0
.debug_line 2679759 2679759 0 0.0
.debug_loc 2824679 2824679 0 0.0
.debug_ranges 286200 286200 0 0.0
.debug_str 3039406 3039406 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104289 104289 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377422 377422 0 0.0
.symtab 256768 256768 0 0.0
.text 536336 536336 0 0.0

@vivien-apple vivien-apple force-pushed the DFT_asan_tsan_proper_supports branch 2 times, most recently from 4ee478a to 9b3f66c Compare April 11, 2023 14:43
@github-actions
Copy link

PR #26014: Size comparison from 00a2dcc to 9b3f66c

Full report (1 build for cc32xx)
platform target config section 00a2dcc 9b3f66c change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642953 642953 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933129 933129 0 0.0
.debug_aranges 87616 87616 0 0.0
.debug_frame 301352 301352 0 0.0
.debug_info 20303347 20303347 0 0.0
.debug_line 2679969 2679969 0 0.0
.debug_loc 2824782 2824782 0 0.0
.debug_ranges 286208 286208 0 0.0
.debug_str 3039557 3039557 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104353 104353 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377533 377533 0 0.0
.symtab 256800 256800 0 0.0
.text 536480 536480 0 0.0

scripts/build/build_darwin_framework.py Outdated Show resolved Hide resolved
@vivien-apple
Copy link
Contributor Author

It seems like the Darwin Tests / Test Suites - Darwin (no-ble-asan-clang) has an issue. In fact there are various things going on.
This is because of is_clang=true which is not forwarded properly and the resulting binary build/links fine but crash when runned. I am currently investigating.

@vivien-apple
Copy link
Contributor Author

I finally got the Matter.framework to be built with the clang provided by pigweed when is_clang=true is specified. I am not particularly happy with the fact that I need to get the path of clang++, libc++.a and libclang_rt.asan_osx_dynamic.dylib from the pigweed environment and add a few other options to get it to build.

@vivien-apple vivien-apple changed the title [darwin-framework-tool] Add is_asan and is_tsan proper supports [darwin-framework-tool] Add is_asan proper supports Apr 13, 2023
@vivien-apple vivien-apple force-pushed the DFT_asan_tsan_proper_supports branch from 9739360 to 10bf850 Compare April 13, 2023 17:20
scripts/build/build_darwin_framework.py Outdated Show resolved Hide resolved
@github-actions
Copy link

PR #26014: Size comparison from a235160 to 10bf850

Increases (1 build for cc32xx)
platform target config section a235160 10bf850 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20326060 20326061 1 0.0
Full report (1 build for cc32xx)
platform target config section a235160 10bf850 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 643081 643081 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933224 933224 0 0.0
.debug_aranges 87760 87760 0 0.0
.debug_frame 302028 302028 0 0.0
.debug_info 20326060 20326061 1 0.0
.debug_line 2687403 2687403 0 0.0
.debug_loc 2838361 2838361 0 0.0
.debug_ranges 288040 288040 0 0.0
.debug_str 3042379 3042379 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104393 104393 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377626 377626 0 0.0
.symtab 256832 256832 0 0.0
.text 536568 536568 0 0.0

@vivien-apple vivien-apple force-pushed the DFT_asan_tsan_proper_supports branch 2 times, most recently from ecd5c15 to 89d82e3 Compare April 13, 2023 18:12
@vivien-apple
Copy link
Contributor Author

For what it worth, I add to add enable_fuzz_test_targets=false to the Matter.framework build. That may not be necessary with #26067

@github-actions
Copy link

PR #26014: Size comparison from a235160 to 89d82e3

Full report (2 builds for cc32xx, mbed)
platform target config section a235160 89d82e30 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 643081 643081 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933224 933224 0 0.0
.debug_aranges 87760 87760 0 0.0
.debug_frame 302028 302028 0 0.0
.debug_info 20326060 20326060 0 0.0
.debug_line 2687403 2687403 0 0.0
.debug_loc 2838361 2838361 0 0.0
.debug_ranges 288040 288040 0 0.0
.debug_str 3042379 3042379 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104393 104393 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377626 377626 0 0.0
.symtab 256832 256832 0 0.0
.text 536568 536568 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2466272 2466272 0 0.0
.bss 215960 215960 0 0.0
.data 5888 5888 0 0.0
.text 1428916 1428916 0 0.0

@vivien-apple
Copy link
Contributor Author

Ok, it does compile and run properly now. The darwin job still fails because of the use-after-free reported in #26000 that is properly detected.

@github-actions
Copy link

PR #26014: Size comparison from c5216d1 to 0d34d96

Full report (1 build for cc32xx)
platform target config section c5216d1 0d34d96 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 643249 643249 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933224 933224 0 0.0
.debug_aranges 87792 87792 0 0.0
.debug_frame 302140 302140 0 0.0
.debug_info 20328411 20328411 0 0.0
.debug_line 2687890 2687890 0 0.0
.debug_loc 2838930 2838930 0 0.0
.debug_ranges 288072 288072 0 0.0
.debug_str 3042155 3042155 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104401 104401 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377963 377963 0 0.0
.symtab 256976 256976 0 0.0
.text 536728 536728 0 0.0

@bzbarsky-apple bzbarsky-apple force-pushed the DFT_asan_tsan_proper_supports branch from 0d34d96 to dc8ebd9 Compare April 14, 2023 20:30
@bzbarsky-apple bzbarsky-apple enabled auto-merge (squash) April 14, 2023 20:30
@github-actions
Copy link

PR #26014: Size comparison from 533f84c to dc8ebd9

Increases (1 build for cc32xx)
platform target config section 533f84c dc8ebd9 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20328411 20328412 1 0.0
Full report (1 build for cc32xx)
platform target config section 533f84c dc8ebd9 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 643249 643249 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933224 933224 0 0.0
.debug_aranges 87792 87792 0 0.0
.debug_frame 302140 302140 0 0.0
.debug_info 20328411 20328412 1 0.0
.debug_line 2687890 2687890 0 0.0
.debug_loc 2838930 2838930 0 0.0
.debug_ranges 288072 288072 0 0.0
.debug_str 3042155 3042155 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104401 104401 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377963 377963 0 0.0
.symtab 256976 256976 0 0.0
.text 536728 536728 0 0.0

@vivien-apple
Copy link
Contributor Author

/rebase

@bzbarsky-apple bzbarsky-apple merged commit 2e4064e into project-chip:master Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants