Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing for CHIP_DEVICE_CONFIG_MAX_DISCOVERED_IP_ADDRESSES to be set in build args #25994

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

sharadb-amazon
Copy link
Contributor

Fixes #25993

Change summary

The CHIP_DEVICE_CONFIG_MAX_DISCOVERED_IP_ADDRESSES should be configurable per app, add a configuration that allows for this to be specified.

Testing

Tested by verifying the ninja file was filled in with the right arguments when building both chip tool as well as the tv-casting-app

build args

The CHIP_DEVICE_CONFIG_MAX_DISCOVERED_IP_ADDRESSES should be
configurable per app, add a configuration that allows for this to be
specified.

Tested by verifying the ninja file was filled in with the right
arguments when building both chip tool as well as the tv-casting-app
@github-actions
Copy link

github-actions bot commented Apr 5, 2023

PR #25994: Size comparison from 6d35975 to a65c240

Increases (1 build for cc32xx)
platform target config section 6d35975 a65c240 change % change
cc32xx lock CC3235SF_LAUNCHXL (read only) 642737 642745 8 0.0
.text 536328 536336 8 0.0
Full report (4 builds for cc32xx, mbed, qpg)
platform target config section 6d35975 a65c240 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642737 642745 8 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933099 933099 0 0.0
.debug_aranges 87608 87608 0 0.0
.debug_frame 301328 301328 0 0.0
.debug_info 20302986 20302986 0 0.0
.debug_line 2679748 2679748 0 0.0
.debug_loc 2824679 2824679 0 0.0
.debug_ranges 286200 286200 0 0.0
.debug_str 3039406 3039406 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104289 104289 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377422 377422 0 0.0
.symtab 256768 256768 0 0.0
.text 536328 536336 8 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2465472 2465472 0 0.0
.bss 215964 215964 0 0.0
.data 5880 5880 0 0.0
.text 1428116 1428116 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1153432 1153432 0 0.0
.bss 97404 97404 0 0.0
.data 852 852 0 0.0
.text 600528 600528 0 0.0
lock-app qpg6105+debug (read/write) 1122048 1122048 0 0.0
.bss 92540 92540 0 0.0
.data 856 856 0 0.0
.text 569148 569148 0 0.0

@sharadb-amazon sharadb-amazon merged commit e2fa6ba into project-chip:master Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] darwin/tv-casting-app: Missing IP Addresses in Commissioner discovery results
3 participants