-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding in build step to strip debug symbols #25669
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock,
kkasperczyk-no and
ksperling-apple
March 13, 2023 21:18
pullapprove
bot
requested review from
msandstedt,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yunhanw-google
March 13, 2023 21:18
sharadb-amazon
approved these changes
Mar 13, 2023
yunhanw-google
approved these changes
Mar 13, 2023
PR #25669: Size comparison from d04e396 to 037f98b Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
The libTvCastingApp.a file was ~110mb prior to this strip operation, afterwards it dropped to ~21mb. I also added a new TvCasting Release scheme The release scheme strips out debug targets, the standard one doesn't. Tested this by seeing the drop on an XCode build and also verifying the TVapp still functions as before
bzbarsky-apple
approved these changes
Mar 13, 2023
PR #25669: Size comparison from d04e396 to 5f1c919 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
The libTvCastingApp.a file was ~110mb prior to this strip operation, afterwards it dropped to ~21mb. I also added a new TvCasting Release scheme The release scheme strips out debug targets, the standard one doesn't. Tested this by seeing the drop on an XCode build and also verifying the TVapp still functions as before
mwswartwout
pushed a commit
to mwswartwout/connectedhomeip
that referenced
this pull request
Mar 27, 2023
The libTvCastingApp.a file was ~110mb prior to this strip operation, afterwards it dropped to ~21mb. I also added a new TvCasting Release scheme The release scheme strips out debug targets, the standard one doesn't. Tested this by seeing the drop on an XCode build and also verifying the TVapp still functions as before
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The libTvCastingApp.a file was ~110mb prior to this strip operation, afterwards it dropped to ~21mb.
I also added a new TvCasting Release scheme
The release scheme strips out debug targets, the standard one doesn't.
Tested this by seeing the drop on an XCode build and also verifying the TVapp still functions as before