Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipv4 build arg moved and update data modal for lighting app #25591

Merged
merged 2 commits into from
Mar 10, 2023
Merged

ipv4 build arg moved and update data modal for lighting app #25591

merged 2 commits into from
Mar 10, 2023

Conversation

Thirsrin
Copy link
Contributor

@Thirsrin Thirsrin commented Mar 9, 2023

added in this PR:

  • Ipv4 build arg moved to gni files
  • lighting app data model update for wifi

Tested:

  • Builds done successfully
  • sanity on one combo (mg24+wf200)

jmartinez-silabs
jmartinez-silabs reviewed Mar 9, 2023
View reviewed changes
third_party/silabs/efr32_sdk.gni Outdated Show resolved Hide resolved
third_party/silabs/silabs_board.gni Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Mar 9, 2023 •
edited
Loading

PR #25591: Size comparison from 82da16f to 95386f2

Increases (5 builds for bl602, cc13x2_26x2, psoc6, qpg)
platform target config section 82da16f 95386f2 change % change
bl602 lighting-app bl602+rpc .text 1058636 1058638 2 0.0
cc13x2_26x2 all-clusters-minimal-app LP_CC2652R7 (read only) 644567 644575 8 0.0
.text 565848 565856 8 0.0
lock-mtd LP_CC2652R7 (read/write) 179348 179356 8 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27985261 27985262 1 0.0
qpg lighting-app qpg6105+debug (read/write) 1153012 1153020 8 0.0
.text 600108 600116 8 0.0
Decreases (5 builds for bl702, cc13x2_26x2, efr32)
platform target config section 82da16f 95386f2 change % change
bl702 lighting-app bl702 .debug_info 40861234 40861233 -1 -0.0
.text 958516 958514 -2 -0.0
cc13x2_26x2 lock-mtd LP_CC2652R7 (read only) 664371 664363 -8 -0.0
.text 560368 560360 -8 -0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1031012 1027396 -3616 -0.4
.bss 179276 179196 -80 -0.0
.data 2060 2052 -8 -0.4
.text 849656 846128 -3528 -0.4
BRD4187C (read/write) 1013852 1013844 -8 -0.0
.text 838384 838376 -8 -0.0
lock-app BRD4161A+wf200 (read/write) 1056852 1056844 -8 -0.0
.text 904192 904184 -8 -0.0
Full report (34 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
platform target config section 82da16f 95386f2 change % change
bl602 lighting-app bl602 (read/write) 1352006 1352006 0 0.0
.bss 94690 94690 0 0.0
.data 9744 9744 0 0.0
.text 1027958 1027958 0 0.0
bl602+rpc (read/write) 1397190 1397190 0 0.0
.bss 102738 102738 0 0.0
.data 10136 10136 0 0.0
.text 1058636 1058638 2 0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1191803 1191803 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 69793 69793 0 0.0
.bss_psram 30160 30160 0 0.0
.comment 48 48 0 0.0
.data 4072 4072 0 0.0
.debug_abbrev 1556816 1556816 0 0.0
.debug_aranges 134592 134592 0 0.0
.debug_frame 493440 493440 0 0.0
.debug_info 40861234 40861233 -1 -0.0
.debug_line 5294017 5294017 0 0.0
.debug_loc 3424650 3424650 0 0.0
.debug_ranges 373184 373184 0 0.0
.debug_str 3585256 3585256 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 108160 108160 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 576349 576349 0 0.0
.symtab 174160 174160 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
958516 958514 -2 -0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1282471 1282471 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 77841 77841 0 0.0
.bss_psram 30432 30432 0 0.0
.comment 48 48 0 0.0
.data 4616 4616 0 0.0
.debug_abbrev 1708931 1708931 0 0.0
.debug_aranges 142920 142920 0 0.0
.debug_frame 521384 521384 0 0.0
.debug_info 45488093 45488093 0 0.0
.debug_line 5699360 5699360 0 0.0
.debug_loc 3622665 3622665 0 0.0
.debug_ranges 397184 397184 0 0.0
.debug_str 3989452 3989452 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 122368 122368 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 637674 637674 0 0.0
.symtab 192656 192656 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1033858 1033858 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 681303 681303 0 0.0
(read/write) 169792 169792 0 0.0
.bss 80788 80788 0 0.0
.data 3352 3352 0 0.0
.rodata 88527 88527 0 0.0
.text 592460 592460 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 644567 644575 8 0.0
(read/write) 157456 157456 0 0.0
.bss 79988 79988 0 0.0
.data 3352 3352 0 0.0
.rodata 78399 78399 0 0.0
.text 565848 565856 8 0.0
lock-ftd LP_CC2652R7 (read only) 678375 678375 0 0.0
(read/write) 170184 170184 0 0.0
.bss 78340 78340 0 0.0
.data 3316 3316 0 0.0
.rodata 76711 76711 0 0.0
.text 601184 601184 0 0.0
lock-mtd LP_CC2652R7 (read only) 664371 664363 -8 -0.0
(read/write) 179348 179356 8 0.0
.bss 73500 73500 0 0.0
.data 3316 3316 0 0.0
.rodata 103523 103523 0 0.0
.text 560368 560360 -8 -0.0
pump-app LP_CC2652R7 (read only) 691611 691611 0 0.0
(read/write) 157692 157692 0 0.0
.bss 78316 78316 0 0.0
.data 3280 3280 0 0.0
.rodata 91083 91083 0 0.0
.text 600048 600048 0 0.0
pump-controller-app LP_CC2652R7 (read only) 676563 676563 0 0.0
(read/write) 172876 172876 0 0.0
.bss 78452 78452 0 0.0
.data 3304 3304 0 0.0
.rodata 86971 86971 0 0.0
.text 589112 589112 0 0.0
shell LP_CC2652R7 (read only) 672742 672742 0 0.0
(read/write) 180424 180424 0 0.0
.bss 82860 82860 0 0.0
.data 3348 3348 0 0.0
.rodata 85430 85430 0 0.0
.text 587000 587000 0 0.0
cc32xx lock CC3235SF_LAUNCHXL (read only) 644425 644425 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930235 930235 0 0.0
.debug_aranges 87344 87344 0 0.0
.debug_frame 300044 300044 0 0.0
.debug_info 20267469 20267469 0 0.0
.debug_line 2659770 2659770 0 0.0
.debug_loc 2802853 2802853 0 0.0
.debug_ranges 282960 282960 0 0.0
.debug_str 3024079 3024079 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 105929 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378571 378571 0 0.0
.symtab 256624 256624 0 0.0
.text 0 0 0 0.0
536372 536372 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 587730 587730 0 0.0
.app_xip_area 464500 464500 0 0.0
.bss 65672 65672 0 0.0
.data 740 740 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 591866 591866 0 0.0
.app_xip_area 463340 463340 0 0.0
.bss 70960 70960 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 552254 552254 0 0.0
.app_xip_area 434616 434616 0 0.0
.bss 60120 60120 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1031012 1027396 -3616 -0.4
.bss 179276 179196 -80 -0.0
.data 2060 2052 -8 -0.4
.text 849656 846128 -3528 -0.4
BRD4187C (read/write) 1013852 1013844 -8 -0.0
.bss 148176 148176 0 0.0
.data 2696 2696 0 0.0
.text 838384 838376 -8 -0.0
lock-app BRD4161A+wf200 (read/write) 1056852 1056844 -8 -0.0
.bss 150572 150572 0 0.0
.data 2068 2068 0 0.0
.text 904192 904184 -8 -0.0
window-app BRD4187C (read/write) 1130532 1130532 0 0.0
.bss 132600 132600 0 0.0
.data 2588 2588 0 0.0
.text 970748 970748 0 0.0
k32w contact k32w0+release (read/write) 673704 673704 0 0.0
.bss 65372 65372 0 0.0
.data 2224 2224 0 0.0
.text 574708 574708 0 0.0
light k32w0+release (read/write) 672748 672748 0 0.0
.bss 65036 65036 0 0.0
.data 2212 2212 0 0.0
.text 574100 574100 0 0.0
lock k32w0+release (read/write) 627164 627164 0 0.0
.bss 63108 63108 0 0.0
.data 2136 2136 0 0.0
.text 546904 546904 0 0.0
linux chip-tool-ipv6only arm64 (read only) 12164036 12164036 0 0.0
(read/write) 733448 733448 0 0.0
.bss 34296 34296 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 675552 675552 0 0.0
.dynamic 560 560 0 0.0
.got 15384 15384 0 0.0
.init 24 24 0 0.0
.init_array 216 216 0 0.0
.rodata 588516 588516 0 0.0
.text 9834884 9834884 0 0.0
thermostat-no-ble arm64 (read only) 2522036 2522036 0 0.0
(read/write) 145256 145256 0 0.0
.bss 56344 56344 0 0.0
.data 1784 1784 0 0.0
.data.rel.ro 77712 77712 0 0.0
.dynamic 560 560 0 0.0
.got 5368 5368 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 150960 150960 0 0.0
.text 2108640 2108640 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2467664 2467664 0 0.0
.bss 215804 215804 0 0.0
.data 5880 5880 0 0.0
.text 1430308 1430308 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1172904 1172904 0 0.0
bss 155397 155397 0 0.0
rodata 132600 132600 0 0.0
text 804112 804112 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1432716 1432716 0 0.0
bss 135137 135137 0 0.0
rodata 228652 228652 0 0.0
text 774872 774872 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1118104 1118104 0 0.0
bss 154553 154553 0 0.0
rodata 109416 109416 0 0.0
text 773464 773464 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841000 841000 0 0.0
(read/write) 1762924 1762924 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189704 189704 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2640 2640 0 0.0
.debug_abbrev 1253642 1253642 0 0.0
.debug_aranges 111480 111480 0 0.0
.debug_frame 374760 374760 0 0.0
.debug_info 27985261 27985262 1 0.0
.debug_line 3794862 3794862 0 0.0
.debug_loc 3699842 3699842 0 0.0
.debug_ranges 364808 364808 0 0.0
.debug_str 3533724 3533724 0 0.0
.heap 841000 841000 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 581819 581819 0 0.0
.symtab 426112 426112 0 0.0
.text 1562192 1562192 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 841808 841808 0 0.0
(read/write) 1703220 1703220 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188904 188904 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2632 2632 0 0.0
.debug_abbrev 1238975 1238975 0 0.0
.debug_aranges 110712 110712 0 0.0
.debug_frame 377096 377096 0 0.0
.debug_info 27529726 27529726 0 0.0
.debug_line 3802361 3802361 0 0.0
.debug_loc 3683043 3683043 0 0.0
.debug_ranges 362744 362744 0 0.0
.debug_str 3520846 3520846 0 0.0
.heap 841808 841808 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 541411 541411 0 0.0
.symtab 410960 410960 0 0.0
.text 1503296 1503296 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850072 850072 0 0.0
(read/write) 1616860 1616860 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180808 180808 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1074312 1074312 0 0.0
.debug_aranges 102920 102920 0 0.0
.debug_frame 347380 347380 0 0.0
.debug_info 22871194 22871194 0 0.0
.debug_line 3355089 3355089 0 0.0
.debug_loc 3358232 3358232 0 0.0
.debug_ranges 321304 321304 0 0.0
.debug_str 3319617 3319617 0 0.0
.heap 850072 850072 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 477245 477245 0 0.0
.symtab 379008 379008 0 0.0
.text 1425200 1425200 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 822296 822296 0 0.0
(read/write) 1673604 1673604 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 208568 208568 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2480 2480 0 0.0
.debug_abbrev 1076276 1076276 0 0.0
.debug_aranges 103312 103312 0 0.0
.debug_frame 349088 349088 0 0.0
.debug_info 23122946 23122946 0 0.0
.debug_line 3357133 3357133 0 0.0
.debug_loc 3381646 3381646 0 0.0
.debug_ranges 323872 323872 0 0.0
.debug_str 3338170 3338170 0 0.0
.heap 822296 822296 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 480942 480942 0 0.0
.symtab 381152 381152 0 0.0
.text 1454168 1454168 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1153012 1153020 8 0.0
.bss 99916 99916 0 0.0
.data 852 852 0 0.0
.text 600108 600116 8 0.0
lock-app qpg6105+debug (read/write) 1119524 1119524 0 0.0
.bss 96308 96308 0 0.0
.data 864 864 0 0.0
.text 566624 566624 0 0.0

@github-actions
Copy link

github-actions bot commented Mar 9, 2023

PR #25591: Size comparison from 82da16f to dc516e9

Decreases (1 build for cc32xx)
platform target config section 82da16f dc516e9 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20267469 20267468 -1 -0.0
Full report (1 build for cc32xx)
platform target config section 82da16f dc516e9 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 644425 644425 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930235 930235 0 0.0
.debug_aranges 87344 87344 0 0.0
.debug_frame 300044 300044 0 0.0
.debug_info 20267469 20267468 -1 -0.0
.debug_line 2659770 2659770 0 0.0
.debug_loc 2802853 2802853 0 0.0
.debug_ranges 282960 282960 0 0.0
.debug_str 3024079 3024079 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 105929 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378571 378571 0 0.0
.symtab 256624 256624 0 0.0
.text 536372 536372 0 0.0

@github-actions
Copy link

PR #25591: Size comparison from 52b1e62 to 78d801d

Increases (1 build for cc32xx)
platform target config section 52b1e62 78d801d change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20268460 20268461 1 0.0
Full report (2 builds for cc32xx, mbed)
platform target config section 52b1e62 78d801d change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 644465 644465 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930280 930280 0 0.0
.debug_aranges 87344 87344 0 0.0
.debug_frame 300048 300048 0 0.0
.debug_info 20268460 20268461 1 0.0
.debug_line 2659917 2659917 0 0.0
.debug_loc 2802993 2802993 0 0.0
.debug_ranges 282936 282936 0 0.0
.debug_str 3023875 3023875 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 105929 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378571 378571 0 0.0
.symtab 256624 256624 0 0.0
.text 536412 536412 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2467664 2467664 0 0.0
.bss 215804 215804 0 0.0
.data 5880 5880 0 0.0
.text 1430308 1430308 0 0.0

@Thirsrin Thirsrin force-pushed the feature/wifi_ipv4_build_arg_and_data_model_update_for_lighting branch from 78d801d to 5b89672 Compare March 10, 2023 06:31
@github-actions
Copy link

PR #25591: Size comparison from 8afc1f5 to 5b89672

Increases (1 build for cc32xx)
platform target config section 8afc1f5 5b89672 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20275028 20275029 1 0.0
Full report (2 builds for cc32xx, mbed)
platform target config section 8afc1f5 5b89672 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 644945 644945 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930293 930293 0 0.0
.debug_aranges 87376 87376 0 0.0
.debug_frame 300236 300236 0 0.0
.debug_info 20275028 20275029 1 0.0
.debug_line 2660914 2660914 0 0.0
.debug_loc 2804674 2804674 0 0.0
.debug_ranges 283248 283248 0 0.0
.debug_str 3026077 3026077 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105921 105921 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 379152 379152 0 0.0
.symtab 256848 256848 0 0.0
.text 536904 536904 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2467904 2467904 0 0.0
.bss 215964 215964 0 0.0
.data 5880 5880 0 0.0
.text 1430548 1430548 0 0.0

@yufengwangca yufengwangca merged commit 624ce71 into project-chip:master Mar 10, 2023
@jmartinez-silabs jmartinez-silabs mentioned this pull request Mar 14, 2023
Merged
@Thirsrin Thirsrin deleted the feature/wifi_ipv4_build_arg_and_data_model_update_for_lighting branch March 14, 2023 04:36
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@Thirsrin
ipv4 build arg moved and update data modal for lighting app (project-…
d1173fe 
…chip#25591)

* ipv4 build arg moved and update data modal for lighting app

* review comments
mwswartwout pushed a commit to mwswartwout/connectedhomeip that referenced this pull request Mar 27, 2023
@Thirsrin @mwswartwout
ipv4 build arg moved and update data modal for lighting app (project-…
1453ff7 
…chip#25591)

* ipv4 build arg moved and update data modal for lighting app

* review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

Assignees
No one assigned
Labels
examples platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Thirsrin @bzbarsky-apple @jmartinez-silabs @cliffamzn @yufengwangca