review comments

project-chip · Mar 10, 2023 · 5b89672 · 5b89672
1 parent 7be0a1b
commit 5b89672
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/third_party/silabs/SiWx917_sdk.gni b/third_party/silabs/SiWx917_sdk.gni
@@ -40,6 +40,9 @@ declare_args() {
 
   # Enable Segger System View
   use_system_view = false
+
+  # Argument to Disable IPv4 for wifi(rs911)
+  chip_enable_wifi_ipv4 = false
 }
 
 assert(efr32_sdk_root != "", "efr32_sdk_root must be specified")
@@ -141,7 +144,7 @@ template("efr32_sdk") {
 
     defines += board_defines
 
-    if (invoker.chip_enable_wifi_ipv4) {
+    if (chip_enable_wifi_ipv4) {
       defines += [ "CHIP_DEVICE_CONFIG_ENABLE_IPV4=1" ]
     }
 

diff --git a/third_party/silabs/efr32_sdk.gni b/third_party/silabs/efr32_sdk.gni
@@ -46,6 +46,9 @@ declare_args() {
 
   # Enable Sleepy end device
   enable_sleepy_device = false
+
+  # Argument to Disable IPv4 for wifi(rs911)
+  chip_enable_wifi_ipv4 = false
 }
 
 assert(efr32_sdk_root != "", "efr32_sdk_root must be specified")
@@ -197,7 +200,7 @@ template("efr32_sdk") {
     }
 
     if (defined(invoker.chip_enable_wifi) && invoker.chip_enable_wifi) {
-      if (invoker.chip_enable_wifi_ipv4) {
+      if (chip_enable_wifi_ipv4) {
         defines += [ "CHIP_DEVICE_CONFIG_ENABLE_IPV4=1" ]
       }
       if (use_rs9116 || use_SiWx917) {

diff --git a/third_party/silabs/silabs_board.gni b/third_party/silabs/silabs_board.gni
@@ -36,9 +36,6 @@ declare_args() {
   use_SiWx917 = false
   use_rs911x_sockets = false
   chip_enable_ble_rs911x = false
-
-  # Argument to Disable IPv4 for wifi(rs911)
-  chip_enable_wifi_ipv4 = false
 }
 
 declare_args() {