Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset the wrong code retry attempts if a valid credential is presented #25536

Merged
merged 8 commits into from
Mar 10, 2023
Merged

Reset the wrong code retry attempts if a valid credential is presented #25536

merged 8 commits into from
Mar 10, 2023

Conversation

nivi-apple
Copy link
Contributor

  • Provide a ResetWrongCodeEntryAttempts for apps to use to reset the wrong entry attempts

  • Update DL_LockUnlock.yaml to test resetting the wrong code retry attempts

Fixes #23782

@nivi-apple nivi-apple force-pushed the fix_door_lock_reset_retry_counter branch from 82dee1a to f41610c Compare March 7, 2023 19:22
@github-actions
Copy link

github-actions bot commented Mar 7, 2023

PR #25536: Size comparison from c14b011 to f41610c

Increases (1 build for cc32xx)
platform target config section c14b011 f41610c change % change
cc32xx lock CC3235SF_LAUNCHXL (read only) 644425 644593 168 0.0
.debug_info 20267066 20267489 423 0.0
.debug_line 2659698 2659839 141 0.0
.debug_loc 2802749 2802936 187 0.0
.debug_ranges 282952 282976 24 0.0
.debug_str 3023892 3023973 81 0.0
.rodata 105929 106001 72 0.1
.strtab 378514 378515 1 0.0
.symtab 256624 256656 32 0.0
.text 536372 536468 96 0.0
Full report (1 build for cc32xx)
platform target config section c14b011 f41610c change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 644425 644593 168 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930235 930235 0 0.0
.debug_aranges 87336 87336 0 0.0
.debug_frame 300028 300028 0 0.0
.debug_info 20267066 20267489 423 0.0
.debug_line 2659698 2659839 141 0.0
.debug_loc 2802749 2802936 187 0.0
.debug_ranges 282952 282976 24 0.0
.debug_str 3023892 3023973 81 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 106001 72 0.1
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378514 378515 1 0.0
.symtab 256624 256656 32 0.0
.text 536372 536468 96 0.0

@nivi-apple nivi-apple force-pushed the fix_door_lock_reset_retry_counter branch from f41610c to 0b3d168 Compare March 9, 2023 22:31
@nivi-apple
Reset the wrong code retry attempts if a valid credential is presented
363c1ac 
- Provide a ResetWrongCodeEntryAttempts for apps to use to reset the wrong entry attempts

- Update DL_LockUnlock.yaml to test resetting the wrong code retry attempts
@nivi-apple nivi-apple force-pushed the fix_door_lock_reset_retry_counter branch from 0b3d168 to 363c1ac Compare March 9, 2023 22:34
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

PR #25536: Size comparison from 99cbba0 to 363c1ac

Increases (2 builds for cc32xx, mbed)
platform target config section 99cbba0 363c1ac change % change
cc32xx lock CC3235SF_LAUNCHXL (read only) 644465 644617 152 0.0
.debug_aranges 87344 87352 8 0.0
.debug_frame 300048 300072 24 0.0
.debug_info 20268460 20269015 555 0.0
.debug_line 2659917 2660118 201 0.0
.debug_loc 2802993 2803219 226 0.0
.debug_ranges 282936 282968 32 0.0
.debug_str 3023875 3023956 81 0.0
.rodata 105929 106001 72 0.1
.strtab 378571 378623 52 0.0
.symtab 256624 256688 64 0.0
.text 536412 536492 80 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2467664 2467864 200 0.0
.text 1430308 1430508 200 0.0
Full report (2 builds for cc32xx, mbed)
platform target config section 99cbba0 363c1ac change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 644465 644617 152 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930280 930280 0 0.0
.debug_aranges 87344 87352 8 0.0
.debug_frame 300048 300072 24 0.0
.debug_info 20268460 20269015 555 0.0
.debug_line 2659917 2660118 201 0.0
.debug_loc 2802993 2803219 226 0.0
.debug_ranges 282936 282968 32 0.0
.debug_str 3023875 3023956 81 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 106001 72 0.1
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378571 378623 52 0.0
.symtab 256624 256688 64 0.0
.text 536412 536492 80 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2467664 2467864 200 0.0
.bss 215804 215804 0 0.0
.data 5880 5880 0 0.0
.text 1430308 1430508 200 0.0

@github-actions
Copy link

PR #25536: Size comparison from 99cbba0 to e8cd39e

Increases (1 build for cc32xx)
platform target config section 99cbba0 e8cd39e change % change
cc32xx lock CC3235SF_LAUNCHXL (read only) 644465 644617 152 0.0
.debug_aranges 87344 87352 8 0.0
.debug_frame 300048 300072 24 0.0
.debug_info 20268460 20269016 556 0.0
.debug_line 2659917 2660118 201 0.0
.debug_loc 2802993 2803219 226 0.0
.debug_ranges 282936 282968 32 0.0
.debug_str 3023875 3023956 81 0.0
.rodata 105929 106001 72 0.1
.strtab 378571 378623 52 0.0
.symtab 256624 256688 64 0.0
.text 536412 536492 80 0.0
Full report (1 build for cc32xx)
platform target config section 99cbba0 e8cd39e change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 644465 644617 152 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930280 930280 0 0.0
.debug_aranges 87344 87352 8 0.0
.debug_frame 300048 300072 24 0.0
.debug_info 20268460 20269016 556 0.0
.debug_line 2659917 2660118 201 0.0
.debug_loc 2802993 2803219 226 0.0
.debug_ranges 282936 282968 32 0.0
.debug_str 3023875 3023956 81 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 106001 72 0.1
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378571 378623 52 0.0
.symtab 256624 256688 64 0.0
.text 536412 536492 80 0.0

@github-actions
Copy link

PR #25536: Size comparison from 99cbba0 to 4eda846

Increases (1 build for cc32xx)
platform target config section 99cbba0 4eda846 change % change
cc32xx lock CC3235SF_LAUNCHXL (read only) 644465 644617 152 0.0
.debug_aranges 87344 87352 8 0.0
.debug_frame 300048 300072 24 0.0
.debug_info 20268460 20269015 555 0.0
.debug_line 2659917 2660118 201 0.0
.debug_loc 2802993 2803219 226 0.0
.debug_ranges 282936 282968 32 0.0
.debug_str 3023875 3023956 81 0.0
.rodata 105929 106001 72 0.1
.strtab 378571 378623 52 0.0
.symtab 256624 256688 64 0.0
.text 536412 536492 80 0.0
Full report (1 build for cc32xx)
platform target config section 99cbba0 4eda846 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 644465 644617 152 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930280 930280 0 0.0
.debug_aranges 87344 87352 8 0.0
.debug_frame 300048 300072 24 0.0
.debug_info 20268460 20269015 555 0.0
.debug_line 2659917 2660118 201 0.0
.debug_loc 2802993 2803219 226 0.0
.debug_ranges 282936 282968 32 0.0
.debug_str 3023875 3023956 81 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 106001 72 0.1
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378571 378623 52 0.0
.symtab 256624 256688 64 0.0
.text 536412 536492 80 0.0

@yufengwangca yufengwangca merged commit be24854 into project-chip:master Mar 10, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@nivi-apple @bzbarsky-apple
Reset the wrong code retry attempts if a valid credential is presented (
84acb9b 
project-chip#25536)

* Reset the wrong code retry attempts if a valid credential is presented

- Provide a ResetWrongCodeEntryAttempts for apps to use to reset the wrong entry attempts

- Update DL_LockUnlock.yaml to test resetting the wrong code retry attempts

* Update src/app/clusters/door-lock-server/door-lock-server.cpp

Co-authored-by: Boris Zbarsky <[email protected]>

* Update src/app/clusters/door-lock-server/door-lock-server.cpp

Co-authored-by: Boris Zbarsky <[email protected]>

* Update src/app/clusters/door-lock-server/door-lock-server.h

Co-authored-by: Boris Zbarsky <[email protected]>

* Update src/app/clusters/door-lock-server/door-lock-server.h

Co-authored-by: Boris Zbarsky <[email protected]>

* Update src/app/clusters/door-lock-server/door-lock-server.cpp

Co-authored-by: Boris Zbarsky <[email protected]>

* Address review comment - fix YAML to lock door before unlocking again. Restyle changes

---------

Co-authored-by: Boris Zbarsky <[email protected]>
mwswartwout pushed a commit to mwswartwout/connectedhomeip that referenced this pull request Mar 27, 2023
@nivi-apple @bzbarsky-apple @mwswartwout
Reset the wrong code retry attempts if a valid credential is presented (
2f74f4b 
project-chip#25536)

* Reset the wrong code retry attempts if a valid credential is presented

- Provide a ResetWrongCodeEntryAttempts for apps to use to reset the wrong entry attempts

- Update DL_LockUnlock.yaml to test resetting the wrong code retry attempts

* Update src/app/clusters/door-lock-server/door-lock-server.cpp

Co-authored-by: Boris Zbarsky <[email protected]>

* Update src/app/clusters/door-lock-server/door-lock-server.cpp

Co-authored-by: Boris Zbarsky <[email protected]>

* Update src/app/clusters/door-lock-server/door-lock-server.h

Co-authored-by: Boris Zbarsky <[email protected]>

* Update src/app/clusters/door-lock-server/door-lock-server.h

Co-authored-by: Boris Zbarsky <[email protected]>

* Update src/app/clusters/door-lock-server/door-lock-server.cpp

Co-authored-by: Boris Zbarsky <[email protected]>

* Address review comment - fix YAML to lock door before unlocking again. Restyle changes

---------

Co-authored-by: Boris Zbarsky <[email protected]>
@nivi-apple nivi-apple deleted the fix_door_lock_reset_retry_counter branch March 5, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@yufengwangca yufengwangca yufengwangca approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

Assignees
No one assigned
Labels
app review - approved tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Door lock WrongCodeEntryLimit should have the counter reset on correct PIN entry
3 participants
@nivi-apple @yufengwangca @bzbarsky-apple