-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Fallback to BLE Notification when Indication unsupported #25444
Merged
andy31415
merged 2 commits into
project-chip:master
from
swan-amazon:ble-notification-fallback-support
Mar 3, 2023
Merged
[Android] Fallback to BLE Notification when Indication unsupported #25444
andy31415
merged 2 commits into
project-chip:master
from
swan-amazon:ble-notification-fallback-support
Mar 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To support devices based on older revisions of the SDK that did not include the GATT Server Characteristic property change (from Notification to Indication), the GATT Characteristic properties are queried to determine if Indication and/or Notification is supported. When available, Indication is preferred.
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
kcoppock,
kkasperczyk-no,
ksperling-apple and
lazarkov
March 2, 2023 23:12
pullapprove
bot
requested review from
lpbeliveau-silabs,
LuDuda,
mrjerryjohns,
msandstedt,
mspang,
nivi-apple,
pjzander-signify,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
yufengwangca
March 2, 2023 23:12
cliffamzn
approved these changes
Mar 3, 2023
PR #25444: Size comparison from be20fb0 to 1f5c3a6 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
yufengwangca
approved these changes
Mar 3, 2023
PR #25444: Size comparison from af3fdc5 to 43f3cfd Full report (1 build for cc32xx)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…roject-chip#25444) To support devices based on older revisions of the SDK that did not include the GATT Server Characteristic property change (from Notification to Indication), the GATT Characteristic properties are queried to determine if Indication and/or Notification is supported. When available, Indication is preferred.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support devices based on older revisions of the SDK that did not include the GATT Server Characteristic property change (from Notification to Indication), the GATT Characteristic properties are queried to determine if Indication and/or Notification is supported. When available, Indication is preferred.
Fixes #25442
Example logs from device supporting only Notifications:
Example logs from device supporting Indications:
device-notifications-enabled-patch-export.txt
rpi-indications-enabled-patch-export.txt