-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Platform] Android failed to commission when BLE Indication not supported by Device #25442
Comments
No, initially the spec said to use Indications. Then there was an attempt to change to Notifications, that attempt failed to get uptake and actually become certifiable, as I understand it, and it was reverted. |
And that change was months before SVE. How did something from before that change get certified? @swan-amazon |
In particular, the device being described would not, as I understand it, work with any 1.0-SDK-based controller. Why are we fixing one specific controller to work with such a device? |
Please feel free to reach out to me or James for specific details on this. The problem has impacted many platforms since not all picked up the change in June, and I believe there are devices on the market with firmware today which do not have the change. I don't believe iOS commissioners were impacted, but Android commissioners which use the SDK's android port are impacted. The problem has easily caused hundreds of hours of dev/debug time to date, hence the motivation for this change which is intended to make commissioners backward compatible with devices which do not have the fix. |
@chrisdecenzo could you provide some specific examples here? We could fix the debugging issue without introducing non-spec behavior if that is all that we would prioritize. So questions:
A change that landed in June and release finished in November seems like sufficient time for things to get picked up. There are a lot of other deltas between june and november which likely would need to be picked up. |
For |
Reproduction steps
[Device] device launch firmware was based an old copy of the SDK, which did not support enabling BLE Indications. When the command is sent to the device to enable BLE Indications, the device returns an unsupported error and the command times out. As seen below.
Platform
android
Platform Version(s)
1.0
Type
Manually tested with SDK, Hardware validated
(Optional) If manually tested please explain why this is only manually tested
No response
Anything else?
Initially the spec specified that the BLE characteristics should operate using BLE Notifications, but was changed to specify that BLE Indications should be used. The device was built and certified using the older SDK revision.
#19051
Logs:
device-failure-btsnoop_hci.log
device-failure-export.txt
The text was updated successfully, but these errors were encountered: