Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable -Wconversion for ESP32 platform bits. #25373

Merged
merged 2 commits into from
Mar 1, 2023
Merged

Enable -Wconversion for ESP32 platform bits. #25373

merged 2 commits into from
Mar 1, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

No description provided.

@github-actions
Copy link

PR #25373: Size comparison from 5cd8726 to 5546c9e

Increases (6 builds for bl602, bl702, esp32)
platform target config section 5cd8726 5546c9e change % change
bl602 lighting-app bl602 (read/write) 1350178 1350186 8 0.0
.text 1026272 1026274 2 0.0
bl602+rpc (read/write) 1395626 1395634 8 0.0
.text 1057208 1057210 2 0.0
bl702 lighting-app bl702 .debug_info 40600320 40600321 1 0.0
.text 955558 955560 2 0.0
bl702+rpc .debug_info 45012352 45012354 2 0.0
.text 1030330 1030334 4 0.0
esp32 all-clusters-app c3devkit (read only) 1050704 1050732 28 0.0
.flash.text 1050704 1050732 28 0.0
m5stack (read only) 1102259 1102295 36 0.0
.flash.text 1096875 1096911 36 0.0
Decreases (6 builds for efr32, nrfconnect, psoc6)
platform target config section 5cd8726 5546c9e change % change
efr32 lock-app BRD4161A+wf200 (read/write) 1057848 1057840 -8 -0.0
.text 903000 902992 -8 -0.0
lighting-app BRD4187C (read/write) 1014592 1014584 -8 -0.0
.text 837184 837176 -8 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1167648 1167632 -16 -0.0
text 808064 808060 -4 -0.0
nrf7002dk_nrf5340_cpuapp text 767640 767636 -4 -0.0
psoc6 all-clusters-minimal cy8ckit_062s2_43012 .debug_info 27523875 27523874 -1 -0.0
light cy8ckit_062s2_43012 .debug_info 22865345 22865343 -2 -0.0
Full report (36 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
platform target config section 5cd8726 5546c9e change % change
bl602 lighting-app bl602 (read/write) 1350178 1350186 8 0.0
.bss 94690 94690 0 0.0
.data 9744 9744 0 0.0
.text 1026272 1026274 2 0.0
bl602+rpc (read/write) 1395626 1395634 8 0.0
.bss 102738 102738 0 0.0
.data 10136 10136 0 0.0
.text 1057208 1057210 2 0.0
bl702 lighting-app bl702 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1188451 1188451 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 69785 69785 0 0.0
.bss_psram 30064 30064 0 0.0
.comment 48 48 0 0.0
.data 4072 4072 0 0.0
.debug_abbrev 1551824 1551824 0 0.0
.debug_aranges 134256 134256 0 0.0
.debug_frame 492252 492252 0 0.0
.debug_info 40600320 40600321 1 0.0
.debug_line 5278709 5278709 0 0.0
.debug_loc 3417680 3417680 0 0.0
.debug_ranges 372408 372408 0 0.0
.debug_str 3580020 3580020 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 107872 107872 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 574284 574284 0 0.0
.symtab 173632 173632 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 955558 955560 2 0.0
bl702+rpc 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1278415 1278415 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 77833 77833 0 0.0
.bss_psram 30320 30320 0 0.0
.comment 48 48 0 0.0
.data 4616 4616 0 0.0
.debug_abbrev 1700019 1700019 0 0.0
.debug_aranges 142496 142496 0 0.0
.debug_frame 519940 519940 0 0.0
.debug_info 45012352 45012354 2 0.0
.debug_line 5677471 5677471 0 0.0
.debug_loc 3614359 3614359 0 0.0
.debug_ranges 396184 396184 0 0.0
.debug_str 3983557 3983557 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121968 121968 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 635301 635301 0 0.0
.symtab 191968 191968 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 1030330 1030334 4 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 680567 680567 0 0.0
(read/write) 170504 170504 0 0.0
.bss 80764 80764 0 0.0
.data 3352 3352 0 0.0
.rodata 88487 88487 0 0.0
.text 591764 591764 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 643711 643711 0 0.0
(read/write) 157432 157432 0 0.0
.bss 79964 79964 0 0.0
.data 3352 3352 0 0.0
.rodata 78359 78359 0 0.0
.text 565032 565032 0 0.0
lock-ftd LP_CC2652R7 (read only) 676807 676807 0 0.0
(read/write) 171632 171632 0 0.0
.bss 78220 78220 0 0.0
.data 3316 3316 0 0.0
.rodata 76679 76679 0 0.0
.text 599648 599648 0 0.0
lock-mtd LP_CC2652R7 (read only) 663555 663555 0 0.0
(read/write) 180140 180140 0 0.0
.bss 73476 73476 0 0.0
.data 3316 3316 0 0.0
.rodata 103491 103491 0 0.0
.text 559584 559584 0 0.0
pump-app LP_CC2652R7 (read only) 690011 690011 0 0.0
(read/write) 159172 159172 0 0.0
.bss 78196 78196 0 0.0
.data 3280 3280 0 0.0
.rodata 91051 91051 0 0.0
.text 598480 598480 0 0.0
pump-controller-app LP_CC2652R7 (read only) 674955 674955 0 0.0
(read/write) 174364 174364 0 0.0
.bss 78332 78332 0 0.0
.data 3304 3304 0 0.0
.rodata 86931 86931 0 0.0
.text 587544 587544 0 0.0
shell LP_CC2652R7 (read only) 672014 672014 0 0.0
(read/write) 181128 181128 0 0.0
.bss 82836 82836 0 0.0
.data 3348 3348 0 0.0
.rodata 85398 85398 0 0.0
.text 586304 586304 0 0.0
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 643001 643001 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930167 930167 0 0.0
.debug_aranges 87288 87288 0 0.0
.debug_frame 299852 299852 0 0.0
.debug_info 20262098 20262098 0 0.0
.debug_line 2656903 2656903 0 0.0
.debug_loc 2799508 2799508 0 0.0
.debug_ranges 282192 282192 0 0.0
.debug_str 3023403 3023403 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105889 105889 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377932 377932 0 0.0
.symtab 256272 256272 0 0.0
.text 534988 534988 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586242 586242 0 0.0
.app_xip_area 463132 463132 0 0.0
.bss 65552 65552 0 0.0
.data 740 740 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 590202 590202 0 0.0
.app_xip_area 461796 461796 0 0.0
.bss 70840 70840 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 551494 551494 0 0.0
.app_xip_area 433880 433880 0 0.0
.bss 60096 60096 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1031008 1031008 0 0.0
.bss 181236 181236 0 0.0
.data 2048 2048 0 0.0
.text 847704 847704 0 0.0
lock-app BRD4161A+wf200 (read/write) 1057848 1057840 -8 -0.0
.bss 152772 152772 0 0.0
.data 2056 2056 0 0.0
.text 903000 902992 -8 -0.0
lighting-app BRD4187C (read/write) 1014592 1014584 -8 -0.0
.bss 150128 150128 0 0.0
.data 2684 2684 0 0.0
.text 837184 837176 -8 -0.0
window-app BRD4187C (read/write) 1129944 1129944 0 0.0
.bss 134552 134552 0 0.0
.data 2576 2576 0 0.0
.text 968220 968220 0 0.0
esp32 all-clusters-app c3devkit (read only) 1050704 1050732 28 0.0
(read/write) 1585650 1585650 0 0.0
.dram0.bss 77824 77824 0 0.0
.dram0.data 13752 13752 0 0.0
.flash.rodata 222312 222312 0 0.0
.flash.text 1050704 1050732 28 0.0
.iram0.text 72896 72896 0 0.0
m5stack (read only) 1102259 1102295 36 0.0
(read/write) 501723 501723 0 0.0
.dram0.bss 82864 82864 0 0.0
.dram0.data 34040 34040 0 0.0
.flash.rodata 251048 251048 0 0.0
.flash.text 1096875 1096911 36 0.0
.iram0.text 124855 124855 0 0.0
k32w contact k32w0+release (read/write) 670312 670312 0 0.0
.bss 77556 77556 0 0.0
.data 2204 2204 0 0.0
.text 571440 571440 0 0.0
light k32w0+release (read/write) 669380 669380 0 0.0
.bss 77236 77236 0 0.0
.data 2192 2192 0 0.0
.text 570840 570840 0 0.0
lock k32w0+release (read/write) 626008 626008 0 0.0
.bss 75364 75364 0 0.0
.data 2136 2136 0 0.0
.text 545780 545780 0 0.0
linux chip-tool-ipv6only arm64 (read only) 12130724 12130724 0 0.0
(read/write) 733416 733416 0 0.0
.bss 34296 34296 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 675528 675528 0 0.0
.dynamic 560 560 0 0.0
.got 15376 15376 0 0.0
.init 24 24 0 0.0
.init_array 216 216 0 0.0
.rodata 587076 587076 0 0.0
.text 9803108 9803108 0 0.0
thermostat-no-ble arm64 (read only) 2516724 2516724 0 0.0
(read/write) 145128 145128 0 0.0
.bss 56344 56344 0 0.0
.data 1784 1784 0 0.0
.data.rel.ro 77616 77616 0 0.0
.dynamic 560 560 0 0.0
.got 5336 5336 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 150704 150704 0 0.0
.text 2103872 2103872 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2467344 2467344 0 0.0
.bss 215804 215804 0 0.0
.data 5880 5880 0 0.0
.text 1429988 1429988 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1167648 1167632 -16 -0.0
bss 143423 143423 0 0.0
rodata 136316 136316 0 0.0
text 808064 808060 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1112668 1112668 0 0.0
bss 142579 142579 0 0.0
rodata 113160 113160 0 0.0
text 777212 777212 0 0.0
all-clusters-app nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1372732 1372732 0 0.0
bss 105902 105902 0 0.0
rodata 213704 213704 0 0.0
text 767640 767636 -4 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 0 0 0 0.0
(read only) 841000 841000 0 0.0
(read/write) 1761508 1761508 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189704 189704 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2640 2640 0 0.0
.debug_abbrev 1253515 1253515 0 0.0
.debug_aranges 111408 111408 0 0.0
.debug_frame 374452 374452 0 0.0
.debug_info 27979409 27979409 0 0.0
.debug_line 3791937 3791937 0 0.0
.debug_loc 3695399 3695399 0 0.0
.debug_ranges 364088 364088 0 0.0
.debug_str 3532596 3532596 0 0.0
.heap 841000 841000 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 580998 580998 0 0.0
.symtab 425648 425648 0 0.0
.text 1560776 1560776 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 0 0 0 0.0
(read only) 841808 841808 0 0.0
(read/write) 1701708 1701708 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188904 188904 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2632 2632 0 0.0
.debug_abbrev 1238848 1238848 0 0.0
.debug_aranges 110640 110640 0 0.0
.debug_frame 376788 376788 0 0.0
.debug_info 27523875 27523874 -1 -0.0
.debug_line 3799436 3799436 0 0.0
.debug_loc 3678601 3678601 0 0.0
.debug_ranges 362024 362024 0 0.0
.debug_str 3519718 3519718 0 0.0
.heap 841808 841808 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 540707 540707 0 0.0
.symtab 410560 410560 0 0.0
.text 1501784 1501784 0 0.0
.zero.table 8 8 0 0.0
light cy8ckit_062s2_43012 0 0 0 0.0
(read only) 850072 850072 0 0.0
(read/write) 1615420 1615420 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180808 180808 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1074203 1074203 0 0.0
.debug_aranges 102848 102848 0 0.0
.debug_frame 347076 347076 0 0.0
.debug_info 22865345 22865343 -2 -0.0
.debug_line 3352205 3352205 0 0.0
.debug_loc 3353886 3353886 0 0.0
.debug_ranges 320544 320544 0 0.0
.debug_str 3318480 3318480 0 0.0
.heap 850072 850072 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 476424 476424 0 0.0
.symtab 378544 378544 0 0.0
.text 1423760 1423760 0 0.0
.zero.table 8 8 0 0.0
lock cy8ckit_062s2_43012 0 0 0 0.0
(read only) 845096 845096 0 0.0
(read/write) 1649292 1649292 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 185768 185768 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2480 2480 0 0.0
.debug_abbrev 1076147 1076147 0 0.0
.debug_aranges 103248 103248 0 0.0
.debug_frame 348836 348836 0 0.0
.debug_info 23117294 23117294 0 0.0
.debug_line 3354463 3354463 0 0.0
.debug_loc 3378569 3378569 0 0.0
.debug_ranges 323096 323096 0 0.0
.debug_str 3337291 3337291 0 0.0
.heap 845096 845096 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 480148 480148 0 0.0
.symtab 380720 380720 0 0.0
.text 1452656 1452656 0 0.0
.zero.table 8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1151508 1151508 0 0.0
.bss 99804 99804 0 0.0
.data 852 852 0 0.0
.text 598604 598604 0 0.0
lock-app qpg6105+debug (read/write) 1118724 1118724 0 0.0
.bss 96292 96292 0 0.0
.data 864 864 0 0.0
.text 565824 565824 0 0.0

@pullapprove pullapprove bot requested a review from cliffamzn February 28, 2023 19:21
shubhamdp
shubhamdp approved these changes Mar 1, 2023
View reviewed changes
src/platform/ESP32/route_hook/ESP32RouteHook.c Outdated Show resolved Hide resolved
@bzbarsky-apple bzbarsky-apple enabled auto-merge (squash) March 1, 2023 15:36
@bzbarsky-apple bzbarsky-apple merged commit 3957377 into project-chip:master Mar 1, 2023
@bzbarsky-apple bzbarsky-apple deleted the esp32-conversion branch March 1, 2023 16:26
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@bzbarsky-apple
Enable -Wconversion for ESP32 platform bits. (project-chip#25373)
752ac0f 
* Enable -Wconversion for ESP32 platform bits.

* Address review comment.
Jerry-ESP added a commit to Jerry-ESP/connectedhomeip that referenced this pull request Mar 24, 2023
@Jerry-ESP
fix compile error for -Wconversion added from PR project-chip#25373
824aaba
@Jerry-ESP Jerry-ESP mentioned this pull request Mar 24, 2023
Merged
Jerry-ESP added a commit to Jerry-ESP/connectedhomeip that referenced this pull request Mar 28, 2023
@Jerry-ESP
fix compile error for -Wconversion added from PR project-chip#25373
61e4c5f
Jerry-ESP added a commit to Jerry-ESP/connectedhomeip that referenced this pull request Mar 28, 2023
@Jerry-ESP
fix compile error for -Wconversion added from PR project-chip#25373
6484203
bzbarsky-apple pushed a commit that referenced this pull request Mar 28, 2023
@Jerry-ESP
fix compile error for -Wconversion added from PR #25373 (#25822)
1f7e4a1
mwswartwout pushed a commit to mwswartwout/connectedhomeip that referenced this pull request Mar 28, 2023
@Jerry-ESP @mwswartwout
fix compile error for -Wconversion added from PR project-chip#25373 (p…
a7044a0 
…roject-chip#25822)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubhamdp shubhamdp shubhamdp approved these changes

@dhrishi dhrishi dhrishi approved these changes

@andy31415 andy31415 andy31415 approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

Assignees
No one assigned
Labels
esp32 platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bzbarsky-apple @andy31415 @dhrishi @shubhamdp