Skip to content

Commit

Permalink
Align naming in Account Login cluster XML with the spec. (#24397)
Browse files Browse the repository at this point in the history
* Align naming in Account Login cluster XML with the spec.

* Regenerate generated code.
  • Loading branch information
bzbarsky-apple authored and pull[bot] committed Sep 25, 2023
1 parent 760fd28 commit 1026274
Show file tree
Hide file tree
Showing 7 changed files with 19 additions and 19 deletions.
8 changes: 4 additions & 4 deletions src/app/tests/suites/TV_AccountLoginCluster.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,20 +33,20 @@ tests:
timedInteractionTimeoutMs: 10000
arguments:
values:
- name: "tempAccountIdentifier"
- name: "TempAccountIdentifier"
value: "asdf"
response:
values:
- name: "setupPIN"
- name: "SetupPIN"
value: "tempPin123"
- label: "Login Command"
command: "login"
timedInteractionTimeoutMs: 10000
arguments:
values:
- name: "tempAccountIdentifier"
- name: "TempAccountIdentifier"
value: "asdf"
- name: "setupPIN"
- name: "SetupPIN"
value: "tempPin123"

- label: "Logout Command"
Expand Down
6 changes: 3 additions & 3 deletions src/app/tests/suites/certification/Test_TC_ALOGIN_12_1.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ tests:
value: TempAccountIdentifier
response:
values:
- name: "setupPIN"
- name: "SetupPIN"
saveAs: setupPIN

- label:
Expand All @@ -83,9 +83,9 @@ tests:
timedInteractionTimeoutMs: 10000
arguments:
values:
- name: "tempAccountIdentifier"
- name: "TempAccountIdentifier"
value: TempAccountIdentifier
- name: "setupPIN"
- name: "SetupPIN"
value: setupPIN

- label:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,13 @@ limitations under the License.

<command source="client" code="0x00" name="GetSetupPIN" response="GetSetupPINResponse" mustUseTimedInvoke="true" optional="false">
<description>Upon receipt, the Content App checks if the account associated with the client Temp Account Identifier Rotating ID is the same acount that is active on the given Content App. If the accounts are the same, then the Content App includes the Setup PIN in the GetSetupPIN Response.</description>
<arg name="tempAccountIdentifier" minLength="16" length="100" type="CHAR_STRING"/>
<arg name="TempAccountIdentifier" minLength="16" length="100" type="CHAR_STRING"/>
</command>

<command source="client" code="0x02" name="Login" mustUseTimedInvoke="true" optional="false">
<description>Upon receipt, the Content App checks if the account associated with the client’s Temp Account Identifier (Rotating ID) has a current active Setup PIN with the given value. If the Setup PIN is valid for the user account associated with the Temp Account Identifier, then the Content App MAY make that user account active.</description>
<arg name="tempAccountIdentifier" minLength="16" length="100" type="CHAR_STRING"/>
<arg name="setupPIN" minLength="11" type="CHAR_STRING"/>
<arg name="TempAccountIdentifier" minLength="16" length="100" type="CHAR_STRING"/>
<arg name="SetupPIN" minLength="11" type="CHAR_STRING"/>
</command>

<command source="client" code="0x03" name="Logout" mustUseTimedInvoke="true" optional="false">
Expand All @@ -42,7 +42,7 @@ limitations under the License.

<command source="server" code="0x01" name="GetSetupPINResponse" optional="false" disableDefaultResponse="true">
<description>This message is sent in response to the GetSetupPIN Request, and contains the Setup PIN code, or null when the accounts identified in the request does not match the active account of the running Content App.</description>
<arg name="setupPIN" type="CHAR_STRING"/>
<arg name="SetupPIN" type="CHAR_STRING"/>
</command>

</cluster>
Expand Down
6 changes: 3 additions & 3 deletions src/controller/java/zap-generated/CHIPInvokeCallbacks.cpp

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 1026274

Please sign in to comment.