Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESP32: Handle RIO with lifetime over LWIP_UINT32_MAX/(4 * 1000) #25074

Merged
merged 4 commits into from
Feb 16, 2023
Merged

ESP32: Handle RIO with lifetime over LWIP_UINT32_MAX/(4 * 1000) #25074

merged 4 commits into from
Feb 16, 2023

Conversation

wqx6
Copy link
Contributor

@wqx6 wqx6 commented Feb 15, 2023 •
edited
Loading

Fixes #25058

Use the route_option struct defined in LwIP instead of the user defined rio_header struct.

Also fixes compiling error of lighting app on ESP32-C3.

@github-actions
Copy link

PR #25074: Size comparison from 83dd188 to 1e5406c

Increases (1 build for cc32xx)
platform target config section 83dd188 1e5406c change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20338085 20338086 1 0.0
Full report (1 build for cc32xx)
platform target config section 83dd188 1e5406c change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 641857 641857 0 0.0
(read/write) 204124 204124 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197528 197528 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 931515 931515 0 0.0
.debug_aranges 87432 87432 0 0.0
.debug_frame 300120 300120 0 0.0
.debug_info 20338085 20338086 1 0.0
.debug_line 2657824 2657824 0 0.0
.debug_loc 2790649 2790649 0 0.0
.debug_ranges 281568 281568 0 0.0
.debug_str 3003658 3003658 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105697 105697 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 376514 376514 0 0.0
.symtab 256016 256016 0 0.0
.text 534036 534036 0 0.0

@bzbarsky-apple bzbarsky-apple marked this pull request as draft February 16, 2023 04:03
@bzbarsky-apple bzbarsky-apple marked this pull request as ready for review February 16, 2023 04:03
@bzbarsky-apple
Copy link
Contributor

@wqx6 I have no idea why pullapprove thinks this PR is draft...

@andy31415 andy31415 marked this pull request as draft February 16, 2023 14:17
@andy31415 andy31415 marked this pull request as ready for review February 16, 2023 14:17
@andy31415
Copy link
Contributor

Tried to move it draft -> back to ready for review. Not sure if that will do anything...

@andy31415
Copy link
Contributor

Bot still thinks it is in draft ... but it is not. I will just merge it based on checkmarks and passing CI.

@andy31415 andy31415 merged commit e744367 into project-chip:master Feb 16, 2023
@HomeACcessoryKid HomeACcessoryKid mentioned this pull request Feb 16, 2023
Closed
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@wqx6 @bzbarsky-apple
ESP32: Handle RIO with lifetime over LWIP_UINT32_MAX/(4 * 1000) (proj…
0658cef 
…ect-chip#25074)

* ESP32: Handle RIO with lifetime over LWIP_UINT32_MAX/(4 * 1000)

* ESP32: Remove the rio_header struct and use route_option struct defined in LwIP

---------

Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@chshu chshu chshu approved these changes

@andy31415 andy31415 andy31415 approved these changes

Assignees
No one assigned
Labels
esp32 examples platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not ignore real-life IPv6 RouteAdvertisements with lifetime over 12.42 days
4 participants
@wqx6 @bzbarsky-apple @andy31415 @chshu