Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not ignore real-life IPv6 RouteAdvertisements with lifetime over 12.42 days #25058

Closed
HomeACcessoryKid opened this issue Feb 14, 2023 · 1 comment · Fixed by #25074
Closed
Labels

Comments

@HomeACcessoryKid
Copy link

The MasterBranch has this line of code that will ignore the long lived routes.

if (route_entry == NULL || (route_entry->lifetime_seconds > MAX_RIO_TIMEOUT && route_entry->lifetime_seconds != UINT32_MAX))

In real life, there are valid RAs with e.g. 14 days or 30 days, as reported in the espressif GitHub issues. espressif/esp-matter#217

To avoid problems, the timer concept needs to be expanded to cover these longer timeouts.
Just brainstorming, the route_timeout_handler could read the life_time attribute and we encode some knowledge how often to repeat the timer at maximum length before actually removing the entry.

@bzbarsky-apple
Copy link
Contributor

@shubhamdp @dhrishi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants