Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Lock App ZAP File #25047

Merged
merged 2 commits into from
Feb 15, 2023
Merged

Fixed Lock App ZAP File #25047

merged 2 commits into from
Feb 15, 2023

Conversation

emargolis
Copy link
Contributor

  • Removed BatFaultChange event from the Power Source Cluster, which is not implemented for this app.
  • Removed Software Diagnostics Cluster event, which is only implemented in the All Clusters App example.
  • Removed all Thread Network Diagnostics Cluster events, which are currently not implemented in the SDK at all.

@github-actions
Copy link

PR #25047: Size comparison from 6ce0f90 to 8d3888b

Decreases (1 build for cc32xx)
platform target config section 6ce0f90 8d3888b change % change
cc32xx lock CC3235SF_LAUNCHXL (read only) 640361 640345 -16 -0.0
.debug_info 20180781 20180766 -15 -0.0
.rodata 105633 105617 -16 -0.0
Full report (1 build for cc32xx)
platform target config section 6ce0f90 8d3888b change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 640361 640345 -16 -0.0
(read/write) 204084 204084 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197488 197488 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 928461 928461 0 0.0
.debug_aranges 87352 87352 0 0.0
.debug_frame 299840 299840 0 0.0
.debug_info 20180781 20180766 -15 -0.0
.debug_line 2649926 2649926 0 0.0
.debug_loc 2786017 2786017 0 0.0
.debug_ranges 280728 280728 0 0.0
.debug_str 3005287 3005287 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105633 105617 -16 -0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 375902 375902 0 0.0
.symtab 255856 255856 0 0.0
.text 532604 532604 0 0.0

@andy31415 andy31415 mentioned this pull request Feb 14, 2023
Merged
@woody-apple woody-apple enabled auto-merge (squash) February 14, 2023 16:54
@emargolis
Fixed Lock App ZAP File
6b7ee33 
  - Removed BatFaultChange event from the Power Source Cluster,
    which is not implemented for this app.
  - Removed Software Diagnostics Cluster event, which is only
    implemented in the All Clusters App example.
  - Removed all Thread Network Diagnostics Cluster events, which are currently
    not implemented in the SDK at all.
@emargolis
ZAP REGEN
d6622ed
@emargolis emargolis force-pushed the emargolis/feature/fix-lock-app-zap-events branch from 8d3888b to d6622ed Compare February 14, 2023 18:16
@pullapprove pullapprove bot requested a review from kkasperczyk-no February 14, 2023 18:16
@github-actions
Copy link

PR #25047: Size comparison from 2bba35a to d6622ed

Decreases (1 build for cc32xx)
platform target config section 2bba35a d6622ed change % change
cc32xx lock CC3235SF_LAUNCHXL (read only) 640545 640529 -16 -0.0
.debug_info 20251000 20250983 -17 -0.0
.rodata 105665 105649 -16 -0.0
Full report (1 build for cc32xx)
platform target config section 2bba35a d6622ed change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 640545 640529 -16 -0.0
(read/write) 204092 204092 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197496 197496 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 929366 929366 0 0.0
.debug_aranges 87360 87360 0 0.0
.debug_frame 299868 299868 0 0.0
.debug_info 20251000 20250983 -17 -0.0
.debug_line 2652227 2652227 0 0.0
.debug_loc 2786303 2786303 0 0.0
.debug_ranges 280856 280856 0 0.0
.debug_str 3005403 3005403 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105665 105649 -16 -0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 375952 375952 0 0.0
.symtab 255888 255888 0 0.0
.text 532760 532760 0 0.0

auto-merge was automatically disabled February 15, 2023 13:42

Merge queue setting changed

@yufengwangca yufengwangca merged commit f6d4925 into project-chip:master Feb 15, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@emargolis
Fixed Lock App ZAP File (project-chip#25047)
00c2f89 
* Fixed Lock App ZAP File

  - Removed BatFaultChange event from the Power Source Cluster,
    which is not implemented for this app.
  - Removed Software Diagnostics Cluster event, which is only
    implemented in the All Clusters App example.
  - Removed all Thread Network Diagnostics Cluster events, which are currently
    not implemented in the SDK at all.

* ZAP REGEN
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@andy31415 andy31415 Awaiting requested review from andy31415

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

Assignees
No one assigned
Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emargolis @andy31415 @bzbarsky-apple @yufengwangca