Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed All Clusters App ZAP Test Script File #25045

Merged
merged 3 commits into from
Feb 15, 2023
Merged

Fixed All Clusters App ZAP Test Script File #25045

merged 3 commits into from
Feb 15, 2023

Conversation

emargolis
Copy link
Contributor

  • Removed all Thread Network Diagnostics Cluster events, which are currently not implemented in the SDK at all.
  • Removed all Actions Cluster events, which are currently not implemented in the SDK.
  • Removed BatFaultChange event of the Power Source Cluster, which is not implemented in the SDK..
  • Removed StateChange event of the Boolean State Cluster, which is not implemented for the All Clusters App.
  • Removed all events of the Pump Configuration and Control Cluster, which are currently not implemented in the SDK.

@emargolis
Fixed All Clusters App ZAP Test Script File
00b365b 
  - Removed all Thread Network Diagnostics Cluster events, which are currently
    not implemented in the SDK at all.
  - Removed all Actions Cluster events, which are currently not implemented
    in the SDK.
  - Removed BatFaultChange event of the Power Source Cluster, which is not implemented
    in the SDK..
  - Removed StateChange event of the Boolean State Cluster, which is not implemented
    for the All Clusters App.
  - Removed all events of the Pump Configuration and Control Cluster, which are currently
    not implemented in the SDK.
@emargolis
ZAP REGEN
ad5bc0d
@andy31415
Copy link
Contributor

@emargolis could you update this and #25046 , #25047 to master since it includes #24991?

I hope that event list changes will start showing up in matter files.

@woody-apple woody-apple enabled auto-merge (squash) February 14, 2023 16:54
@pullapprove pullapprove bot requested a review from kkasperczyk-no February 14, 2023 18:23
@andy31415
Copy link
Contributor

@emargolis why do we need to change the test file? The test file is not building any apps and just ensures we know what deltas occur when we alter zapt or zap versions.

@emargolis
Copy link
Contributor Author

@emargolis why do we need to change the test file? The test file is not building any apps and just ensures we know what deltas occur when we alter zapt or zap versions.

Yes, I agree that there is no strong reason to update this test script but still wanted to have it aligned with the actual example zap file.

@woody-apple woody-apple disabled auto-merge February 14, 2023 20:53
@github-actions
Copy link

PR #25045: Size comparison from 1d6a958 to a5468b5

Increases (6 builds for bl602, cc32xx, psoc6, telink)
platform target config section 1d6a958 a5468b5 change % change
bl602 lighting-app bl602 .text 1023524 1023526 2 0.0
bl602+rpc .text 1054458 1054460 2 0.0
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20307077 20307079 2 0.0
psoc6 lock cy8ckit_062s2_43012 .debug_info 23144484 23144485 1 0.0
telink all-clusters-app tlsr9518adk80d text 684660 684664 4 0.0
lighting-app tlsr9518adk80d (read/write) 948036 948044 8 0.0
text 657284 657286 2 0.0
Decreases (6 builds for bl702, efr32, psoc6, telink)
platform target config section 1d6a958 a5468b5 change % change
bl702 lighting-app bl702+rpc .debug_info 45033171 45033170 -1 -0.0
.text 1030320 1030318 -2 -0.0
efr32 lock-app BRD4161A+wf200 (read/write) 1066416 1066408 -8 -0.0
.text 911236 911228 -8 -0.0
psoc6 light cy8ckit_062s2_43012 .debug_info 22913747 22913745 -2 -0.0
telink contact-sensor-app tlsr9518adk80d text 577840 577838 -2 -0.0
ota-requestor-app tlsr9518adk80d text 601630 601628 -2 -0.0
thermostat tlsr9518adk80d text 593464 593462 -2 -0.0
Full report (35 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, linux, mbed, psoc6, qpg, telink)
platform target config section 1d6a958 a5468b5 change % change
bl602 lighting-app bl602 (read/write) 1347010 1347010 0 0.0
.bss 94810 94810 0 0.0
.data 9736 9736 0 0.0
.text 1023524 1023526 2 0.0
bl602+rpc (read/write) 1392458 1392458 0 0.0
.bss 102858 102858 0 0.0
.data 10128 10128 0 0.0
.text 1054458 1054460 2 0.0
bl702 lighting-app bl702 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1185363 1185363 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 69913 69913 0 0.0
.bss_psram 30064 30064 0 0.0
.comment 48 48 0 0.0
.data 4056 4056 0 0.0
.debug_abbrev 1551885 1551885 0 0.0
.debug_aranges 134280 134280 0 0.0
.debug_frame 491764 491764 0 0.0
.debug_info 40624237 40624237 0 0.0
.debug_line 5277493 5277493 0 0.0
.debug_loc 3409452 3409452 0 0.0
.debug_ranges 371744 371744 0 0.0
.debug_str 3559730 3559730 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 107328 107328 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 572957 572957 0 0.0
.symtab 173536 173536 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 952922 952922 0 0.0
bl702+rpc 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1278519 1278519 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 77961 77961 0 0.0
.bss_psram 30320 30320 0 0.0
.comment 48 48 0 0.0
.data 4608 4608 0 0.0
.debug_abbrev 1700393 1700393 0 0.0
.debug_aranges 142512 142512 0 0.0
.debug_frame 519512 519512 0 0.0
.debug_info 45033171 45033170 -1 -0.0
.debug_line 5676500 5676500 0 0.0
.debug_loc 3606370 3606370 0 0.0
.debug_ranges 395512 395512 0 0.0
.debug_str 3963222 3963222 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121968 121968 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 634016 634016 0 0.0
.symtab 192000 192000 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 1030320 1030318 -2 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 678395 678395 0 0.0
(read/write) 172796 172796 0 0.0
.bss 80884 80884 0 0.0
.data 3384 3384 0 0.0
.rodata 88403 88403 0 0.0
.text 589676 589676 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 642219 642219 0 0.0
(read/write) 157576 157576 0 0.0
.bss 80076 80076 0 0.0
.data 3384 3384 0 0.0
.rodata 78195 78195 0 0.0
.text 563704 563704 0 0.0
lock-ftd LP_CC2652R7 (read only) 675279 675279 0 0.0
(read/write) 173264 173264 0 0.0
.bss 78324 78324 0 0.0
.data 3312 3312 0 0.0
.rodata 76703 76703 0 0.0
.text 598096 598096 0 0.0
lock-mtd LP_CC2652R7 (read only) 661707 661707 0 0.0
(read/write) 182092 182092 0 0.0
.bss 73580 73580 0 0.0
.data 3312 3312 0 0.0
.rodata 103291 103291 0 0.0
.text 557936 557936 0 0.0
pump-app LP_CC2652R7 (read only) 688339 688339 0 0.0
(read/write) 160940 160940 0 0.0
.bss 78292 78292 0 0.0
.data 3276 3276 0 0.0
.rodata 90827 90827 0 0.0
.text 597032 597032 0 0.0
pump-controller-app LP_CC2652R7 (read only) 673715 673715 0 0.0
(read/write) 175676 175676 0 0.0
.bss 78404 78404 0 0.0
.data 3300 3300 0 0.0
.rodata 86867 86867 0 0.0
.text 586368 586368 0 0.0
shell LP_CC2652R7 (read only) 669658 669658 0 0.0
(read/write) 183604 183604 0 0.0
.bss 82956 82956 0 0.0
.data 3380 3380 0 0.0
.rodata 85154 85154 0 0.0
.text 584192 584192 0 0.0
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 640577 640577 0 0.0
(read/write) 204100 204100 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197504 197504 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 930806 930806 0 0.0
.debug_aranges 87360 87360 0 0.0
.debug_frame 299864 299864 0 0.0
.debug_info 20307077 20307079 2 0.0
.debug_line 2654650 2654650 0 0.0
.debug_loc 2787110 2787110 0 0.0
.debug_ranges 280904 280904 0 0.0
.debug_str 3001983 3001983 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105665 105665 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 375952 375952 0 0.0
.symtab 255888 255888 0 0.0
.text 532792 532792 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 585014 585014 0 0.0
.app_xip_area 461800 461800 0 0.0
.bss 65656 65656 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 588986 588986 0 0.0
.app_xip_area 460476 460476 0 0.0
.bss 70944 70944 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 550202 550202 0 0.0
.app_xip_area 432492 432492 0 0.0
.bss 60200 60200 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1038816 1038816 0 0.0
.bss 181584 181584 0 0.0
.data 2044 2044 0 0.0
.text 855164 855164 0 0.0
lock-app BRD4161A+wf200 (read/write) 1066416 1066408 -8 -0.0
.bss 153104 153104 0 0.0
.data 2052 2052 0 0.0
.text 911236 911228 -8 -0.0
lighting-app BRD4187C (read/write) 1135744 1135744 0 0.0
.bss 133264 133264 0 0.0
.data 2532 2532 0 0.0
.text 975352 975352 0 0.0
window-app BRD4187C (read/write) 1137360 1137360 0 0.0
.bss 134856 134856 0 0.0
.data 2572 2572 0 0.0
.text 975336 975336 0 0.0
linux chip-tool-ipv6only arm64 (read only) 12001540 12001540 0 0.0
(read/write) 727720 727720 0 0.0
.bss 34248 34248 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 670008 670008 0 0.0
.dynamic 560 560 0 0.0
.got 15256 15256 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 584148 584148 0 0.0
.text 9690628 9690628 0 0.0
thermostat-no-ble arm64 (read only) 2512388 2512388 0 0.0
(read/write) 145256 145256 0 0.0
.bss 56472 56472 0 0.0
.data 1824 1824 0 0.0
.data.rel.ro 77496 77496 0 0.0
.dynamic 560 560 0 0.0
.got 5408 5408 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 151136 151136 0 0.0
.text 2099136 2099136 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2464912 2464912 0 0.0
.bss 215908 215908 0 0.0
.data 5880 5880 0 0.0
.text 1427556 1427556 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 0 0 0 0.0
(read only) 840856 840856 0 0.0
(read/write) 1757956 1757956 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189816 189816 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2672 2672 0 0.0
.debug_abbrev 1254352 1254352 0 0.0
.debug_aranges 111416 111416 0 0.0
.debug_frame 374040 374040 0 0.0
.debug_info 28027823 28027823 0 0.0
.debug_line 3789424 3789424 0 0.0
.debug_loc 3682009 3682009 0 0.0
.debug_ranges 362608 362608 0 0.0
.debug_str 3509822 3509822 0 0.0
.heap 840856 840856 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 578434 578434 0 0.0
.symtab 425104 425104 0 0.0
.text 1557080 1557080 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 0 0 0 0.0
(read only) 841672 841672 0 0.0
(read/write) 1699540 1699540 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189008 189008 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1239987 1239987 0 0.0
.debug_aranges 110680 110680 0 0.0
.debug_frame 376484 376484 0 0.0
.debug_info 27574459 27574459 0 0.0
.debug_line 3797920 3797920 0 0.0
.debug_loc 3665740 3665740 0 0.0
.debug_ranges 360576 360576 0 0.0
.debug_str 3495575 3495575 0 0.0
.heap 841672 841672 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 539642 539642 0 0.0
.symtab 410384 410384 0 0.0
.text 1499480 1499480 0 0.0
.zero.table 8 8 0 0.0
light cy8ckit_062s2_43012 0 0 0 0.0
(read only) 849984 849984 0 0.0
(read/write) 1612596 1612596 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180896 180896 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1074285 1074285 0 0.0
.debug_aranges 102888 102888 0 0.0
.debug_frame 346900 346900 0 0.0
.debug_info 22913747 22913745 -2 -0.0
.debug_line 3350067 3350067 0 0.0
.debug_loc 3343673 3343673 0 0.0
.debug_ranges 319752 319752 0 0.0
.debug_str 3298532 3298532 0 0.0
.heap 849984 849984 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 474810 474810 0 0.0
.symtab 378128 378128 0 0.0
.text 1420848 1420848 0 0.0
.zero.table 8 8 0 0.0
lock cy8ckit_062s2_43012 0 0 0 0.0
(read only) 845008 845008 0 0.0
(read/write) 1646852 1646852 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 185864 185864 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1076025 1076025 0 0.0
.debug_aranges 103328 103328 0 0.0
.debug_frame 348860 348860 0 0.0
.debug_info 23144484 23144485 1 0.0
.debug_line 3351827 3351827 0 0.0
.debug_loc 3366614 3366614 0 0.0
.debug_ranges 321664 321664 0 0.0
.debug_str 3315820 3315820 0 0.0
.heap 845008 845008 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 478223 478223 0 0.0
.symtab 380320 380320 0 0.0
.text 1450128 1450128 0 0.0
.zero.table 8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1149220 1149220 0 0.0
.bss 99908 99908 0 0.0
.data 848 848 0 0.0
.text 596320 596320 0 0.0
lock-app qpg6105+debug (read/write) 1116964 1116964 0 0.0
.bss 96404 96404 0 0.0
.data 860 860 0 0.0
.text 564060 564060 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1013700 1013700 0 0.0
bss 97912 97912 0 0.0
text 684660 684664 4 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 950084 950084 0 0.0
bss 96964 96964 0 0.0
text 646936 646936 0 0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 854952 854952 0 0.0
bss 89084 89084 0 0.0
text 577840 577838 -2 -0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 870700 870700 0 0.0
bss 89168 89168 0 0.0
text 591882 591882 0 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 948036 948044 8 0.0
bss 97320 97320 0 0.0
text 657284 657286 2 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 882036 882036 0 0.0
bss 90120 90120 0 0.0
text 601630 601628 -2 -0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 874904 874904 0 0.0
bss 90560 90560 0 0.0
text 593464 593462 -2 -0.0

@emargolis
Copy link
Contributor Author

@emargolis could you update this and #25046 , #25047 to master since it includes #24991?

I hope that event list changes will start showing up in matter files.

All mentioned and other PR were updated accordingly

@woody-apple woody-apple added this pull request to the merge queue Feb 15, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 15, 2023
@emargolis emargolis added this pull request to the merge queue Feb 15, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 15, 2023
@yufengwangca yufengwangca merged commit 0e4bf1f into project-chip:master Feb 15, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@emargolis
Fixed All Clusters App ZAP Test Script File (project-chip#25045)
f188505 
* Fixed All Clusters App ZAP Test Script File

  - Removed all Thread Network Diagnostics Cluster events, which are currently
    not implemented in the SDK at all.
  - Removed all Actions Cluster events, which are currently not implemented
    in the SDK.
  - Removed BatFaultChange event of the Power Source Cluster, which is not implemented
    in the SDK..
  - Removed StateChange event of the Boolean State Cluster, which is not implemented
    for the All Clusters App.
  - Removed all events of the Pump Configuration and Control Cluster, which are currently
    not implemented in the SDK.

* ZAP REGEN
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@yufengwangca yufengwangca yufengwangca approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

Assignees
No one assigned
Labels
review - approved scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emargolis @andy31415 @yufengwangca @bzbarsky-apple