[Silabs] [SiWx917] Added the platform chip_crypto to SiWx917 platform #25019

chirag-silabs · 2023-02-13T16:04:30Z

Added the tinycrypt in chip crypto to the platform specific
Adding the required files for the CHIPCryptoPal*

Tested commissioning locally

github-actions · 2023-02-13T17:48:01Z

PR #25019: Size comparison from b04c8ca to 38c5875

Increases (1 build for cc32xx)

platform	target	config	section	`b04c8ca`	`38c5875`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_info	20188403	20188405	2	0.0

Full report (3 builds for cc32xx, qpg)

platform	target	config	section	`b04c8ca`	`38c5875`	change
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0
			(read only)	640361	640361	0
			(read/write)	204084	204084	0
			.ARM.attributes	44	44	0
			.ARM.exidx	8	8	0
			.bss	197488	197488	0
			.comment	194	194	0
			.data	1476	1476	0
			.debug_abbrev	928461	928461	0
			.debug_aranges	87352	87352	0
			.debug_frame	299840	299840	0
			.debug_info	20188403	20188405	2
			.debug_line	2649926	2649926	0
			.debug_loc	2786018	2786018	0
			.debug_ranges	280728	280728	0
			.debug_str	3002856	3002856	0
			.ramVecs	780	780	0
			.resetVecs	64	64	0
			.rodata	105633	105633	0
			.shstrtab	232	232	0
			.stab	204	204	0
			.stabstr	441	441	0
			.stack	2048	2048	0
			.strtab	375840	375840	0
			.symtab	255856	255856	0
			.text	532604	532604	0
qpg	lighting-app	qpg6105+debug	(read/write)	1149152	1149152	0
			.bss	99900	99900	0
			.data	848	848	0
			.text	596252	596252	0
	lock-app	qpg6105+debug	(read/write)	1116896	1116896	0
			.bss	96396	96396	0
			.data	860	860	0
			.text	563992	563992	0

jmartinez-silabs

Rubber stamping, build files are ok. I did a quick overview of the crypto files. They are the tinycrypt implementation right?

The CLA part of the pull approve seem t to have failesld. You will probably have to rebase or make a bother plus to the pr to force a rerun

github-actions · 2023-02-14T04:34:30Z

PR #25019: Size comparison from 6ce0f90 to 24ff23d

Increases (1 build for cc32xx)

platform	target	config	section	`6ce0f90`	`24ff23d`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_info	20180781	20180782	1	0.0

Full report (1 build for cc32xx)

platform	target	config	section	`6ce0f90`	`24ff23d`	change
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0
			(read only)	640361	640361	0
			(read/write)	204084	204084	0
			.ARM.attributes	44	44	0
			.ARM.exidx	8	8	0
			.bss	197488	197488	0
			.comment	194	194	0
			.data	1476	1476	0
			.debug_abbrev	928461	928461	0
			.debug_aranges	87352	87352	0
			.debug_frame	299840	299840	0
			.debug_info	20180781	20180782	1
			.debug_line	2649926	2649926	0
			.debug_loc	2786017	2786017	0
			.debug_ranges	280728	280728	0
			.debug_str	3005287	3005287	0
			.ramVecs	780	780	0
			.resetVecs	64	64	0
			.rodata	105633	105633	0
			.shstrtab	232	232	0
			.stab	204	204	0
			.stabstr	441	441	0
			.stack	2048	2048	0
			.strtab	375902	375902	0
			.symtab	255856	255856	0
			.text	532604	532604	0

github-actions · 2023-02-20T12:55:55Z

PR #25019: Size comparison from 04adc52 to 620a354

Increases (1 build for cc32xx)

platform	target	config	section	`04adc52`	`620a354`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_info	20360287	20360288	1	0.0

Full report (1 build for cc32xx)

platform	target	config	section	`04adc52`	`620a354`	change
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0
			(read only)	642209	642209	0
			(read/write)	203696	203696	0
			.ARM.attributes	44	44	0
			.ARM.exidx	8	8	0
			.bss	197096	197096	0
			.comment	194	194	0
			.data	1480	1480	0
			.debug_abbrev	934242	934242	0
			.debug_aranges	87448	87448	0
			.debug_frame	300212	300212	0
			.debug_info	20360287	20360288	1
			.debug_line	`2661052`	`2661052`	0
			.debug_loc	`2797120`	`2797120`	0
			.debug_ranges	281744	281744	0
			.debug_str	3019502	3019502	0
			.ramVecs	780	780	0
			.resetVecs	64	64	0
			.rodata	105713	105713	0
			.shstrtab	232	232	0
			.stab	204	204	0
			.stabstr	441	441	0
			.stack	2048	2048	0
			.strtab	377379	377379	0
			.symtab	256048	256048	0
			.text	534376	534376	0

jmartinez-silabs · 2023-02-20T19:01:12Z

@rcasallas-silabs Can you take a look at this one. The CHIPCryptoPal file mostly

chirag-silabs · 2023-02-20T19:06:57Z

mostly

Actually need to update this a bit, due to the changes done on this PR #23792
Will update with the AES key modifications

src/platform/silabs/SiWx917/CHIPCryptoPAL.h

rcasallas-silabs

Add common changes to src/crypto/CHIPCryptoPAL.h, and extend platform-specific features from the common code.

github-actions · 2023-02-20T20:31:11Z

PR #25019: Size comparison from 04adc52 to 893616e

Increases (1 build for cc32xx)

platform	target	config	section	`04adc52`	`893616e`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	(read only)	642209	642545	336	0.1
			.rodata	105713	105817	104	0.1
			.strtab	377379	377598	219	0.1
			.symtab	256048	256144	96	0.0
			.text	534376	534604	228	0.0

Decreases (1 build for cc32xx)

platform	target	config	section	`04adc52`	`893616e`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	(read/write)	203696	203664	-32	-0.0
			.bss	197096	197064	-32	-0.0
			.debug_abbrev	934242	930168	-4074	-0.4
			.debug_aranges	87448	87272	-176	-0.2
			.debug_frame	300212	299752	-460	-0.2
			.debug_info	20360287	20254059	-106228	-0.5
			.debug_line	`2661052`	2655143	-5909	-0.2
			.debug_loc	`2797120`	2795383	-1737	-0.1
			.debug_ranges	281744	281592	-152	-0.1
			.debug_str	3019502	`3017470`	-2032	-0.1

Full report (1 build for cc32xx)

platform	target	config	section	`04adc52`	`893616e`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0	0.0
			(read only)	642209	642545	336	0.1
			(read/write)	203696	203664	-32	-0.0
			.ARM.attributes	44	44	0	0.0
			.ARM.exidx	8	8	0	0.0
			.bss	197096	197064	-32	-0.0
			.comment	194	194	0	0.0
			.data	1480	1480	0	0.0
			.debug_abbrev	934242	930168	-4074	-0.4
			.debug_aranges	87448	87272	-176	-0.2
			.debug_frame	300212	299752	-460	-0.2
			.debug_info	20360287	20254059	-106228	-0.5
			.debug_line	`2661052`	2655143	-5909	-0.2
			.debug_loc	`2797120`	2795383	-1737	-0.1
			.debug_ranges	281744	281592	-152	-0.1
			.debug_str	3019502	`3017470`	-2032	-0.1
			.ramVecs	780	780	0	0.0
			.resetVecs	64	64	0	0.0
			.rodata	105713	105817	104	0.1
			.shstrtab	232	232	0	0.0
			.stab	204	204	0	0.0
			.stabstr	441	441	0	0.0
			.stack	2048	2048	0	0.0
			.strtab	377379	377598	219	0.1
			.symtab	256048	256144	96	0.0
			.text	534376	534604	228	0.0

…project-chip#25019) * Added the platform chip_crypto to SiWx917 platform * Restyled by gn * removed chipcryptopal.h and modified Aes128KeyHandle which was missed * Restyled by clang-format * Restyled by gn * result was added twice, removed one --------- Co-authored-by: Restyled.io <[email protected]>

chirag-silabs and others added 2 commits February 13, 2023 21:32

Added the platform chip_crypto to SiWx917 platform

237017f

Restyled by gn

38c5875

github-actions bot added the platform label Feb 13, 2023

jmartinez-silabs approved these changes Feb 14, 2023

View reviewed changes

Merge branch 'master' into bugfix/chip_crypto

24ff23d

pullapprove bot requested review from vijs, vivien-apple, woody-apple, xylophone21, yufengwangca and yunhanw-google February 14, 2023 04:25

pullapprove bot added the review - pending label Feb 14, 2023

woody-apple enabled auto-merge February 14, 2023 20:49

pullapprove bot requested a review from kkasperczyk-no February 14, 2023 20:49

auto-merge was automatically disabled February 15, 2023 13:42
Merge queue setting changed

Merge branch 'master' into bugfix/chip_crypto

620a354

rcasallas-silabs reviewed Feb 20, 2023

View reviewed changes

src/platform/silabs/SiWx917/CHIPCryptoPAL.h Outdated Show resolved Hide resolved

rcasallas-silabs requested changes Feb 20, 2023

View reviewed changes

chirag-silabs and others added 3 commits February 21, 2023 01:35

removed chipcryptopal.h and modified Aes128KeyHandle which was missed

d40a2c3

Restyled by clang-format

71305cb

Restyled by gn

c761c43

pullapprove bot requested a review from nivi-apple February 20, 2023 20:08

result was added twice, removed one

893616e

rcasallas-silabs approved these changes Feb 21, 2023

View reviewed changes

yufengwangca approved these changes Feb 27, 2023

View reviewed changes

pullapprove bot added review - approved and removed review - pending labels Feb 27, 2023

yufengwangca merged commit 083623e into project-chip:master Feb 27, 2023

rosahay-silabs deleted the bugfix/chip_crypto branch May 15, 2023 09:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Silabs] [SiWx917] Added the platform chip_crypto to SiWx917 platform #25019

[Silabs] [SiWx917] Added the platform chip_crypto to SiWx917 platform #25019

chirag-silabs commented Feb 13, 2023 •

edited

Loading

github-actions bot commented Feb 13, 2023

jmartinez-silabs left a comment •

edited

Loading

github-actions bot commented Feb 14, 2023

github-actions bot commented Feb 20, 2023

jmartinez-silabs commented Feb 20, 2023

chirag-silabs commented Feb 20, 2023

rcasallas-silabs left a comment

github-actions bot commented Feb 20, 2023

[Silabs] [SiWx917] Added the platform chip_crypto to SiWx917 platform #25019

[Silabs] [SiWx917] Added the platform chip_crypto to SiWx917 platform #25019

Conversation

chirag-silabs commented Feb 13, 2023 • edited Loading

github-actions bot commented Feb 13, 2023

jmartinez-silabs left a comment • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Feb 14, 2023

github-actions bot commented Feb 20, 2023

jmartinez-silabs commented Feb 20, 2023

chirag-silabs commented Feb 20, 2023

rcasallas-silabs left a comment

Choose a reason for hiding this comment

github-actions bot commented Feb 20, 2023

chirag-silabs commented Feb 13, 2023 •

edited

Loading

jmartinez-silabs left a comment •

edited

Loading