[crypto] Introduce AES key abstraction #23792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda,
mlepage-google,
msandstedt,
mspang and
rgoliver
bzbarsky-apple
approved these changes
Jan 20, 2023
Damian-Nordic
force-pushed
the
psa-aes-upstream
branch
from
2fbda3f to
79457a2
Compare
|
PR #23792: Size comparison from 811ab2b to 79457a2 Increases above 0.2%:
Increases (51 builds for bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (52 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tcarmelveilleux
approved these changes
Feb 13, 2023
Add Aes128KeyHandle class that represents a platform-specific AES key, either in the form of raw key material or key reference. Also add SessionKeystore interface for managing the lifetime of symmetric keys. This is needed to enable more secure key management for crypto backends that support invoking crypto operations using key references, such as PSA crypto API. Thanks to this class the session can only hold key references while having the actual keys stored securely. Group key management is still to be improved though.
1. Align AES key handle as uintptr_t instead of size_t. 2. Replace temporary implementation of PSA key derivation with a proper one that does not reveal derived keys. 3. Do not use DefaultSessionKeystore in controllers.
Damian-Nordic
force-pushed
the
psa-aes-upstream
branch
from
79457a2 to
b3daf09
Compare
|
PR #23792: Size comparison from 9913fc8 to b3daf09 Increases above 0.2%:
Increases (1 build for cc32xx)
Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
|
PR #23792: Size comparison from 9913fc8 to a8860b3 Increases above 0.2%:
Increases (1 build for cc32xx)
Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
* [crypto] Introduce AES key abstraction Add Aes128KeyHandle class that represents a platform-specific AES key, either in the form of raw key material or key reference. Also add SessionKeystore interface for managing the lifetime of symmetric keys. This is needed to enable more secure key management for crypto backends that support invoking crypto operations using key references, such as PSA crypto API. Thanks to this class the session can only hold key references while having the actual keys stored securely. Group key management is still to be improved though. * Update PSA implementation * Code review p.2 * Code review p.3 1. Align AES key handle as uintptr_t instead of size_t. 2. Replace temporary implementation of PSA key derivation with a proper one that does not reveal derived keys. 3. Do not use DefaultSessionKeystore in controllers. * Fix build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add AesKey class that represents a platform-specific AES key, either in the form of raw key material or key reference. This is needed to enable more secure key management for crypto backends that support invoking crypto operations using key references, such as PSA crypto API.
Thanks to this class the session can only hold key references while having the actual keys stored securely. Group key management is still to be improved though.
Fixes #23189