Clean up the code that sends the query image response from the provider #24933

nivi-apple · 2023-02-09T00:20:47Z

Fixes #24859

src/darwin/Framework/CHIP/MTROTAProviderDelegateBridge.mm

github-actions · 2023-02-23T22:56:17Z

PR #24933: Size comparison from 7775bec to 240484e

Full report (1 build for cc32xx)

platform	target	config	section	`7775bec`	`240484e`
cc32xx	lock	CC3235SF_LAUNCHXL		0	0
			(read only)	642681	642681
			(read/write)	203672	203672
			.ARM.attributes	44	44
			.ARM.exidx	8	8
			.bss	197072	197072
			.comment	194	194
			.data	1480	1480
			.debug_abbrev	930133	930133
			.debug_aranges	87304	87304
			.debug_frame	299872	299872
			.debug_info	20257010	20257010
			.debug_line	2656183	2656183
			.debug_loc	`2797535`	`2797535`
			.debug_ranges	281792	281792
			.debug_str	3023459	3023459
			.ramVecs	780	780
			.resetVecs	64	64
			.rodata	105769	105769
			.shstrtab	232	232
			.stab	204	204
			.stabstr	441	441
			.stack	2048	2048
			.strtab	377825	377825
			.symtab	256256	256256
			.text	534788	534788

github-actions · 2023-02-24T00:33:54Z

PR #24933: Size comparison from 7775bec to f6bcf17

Increases (1 build for nrfconnect)

platform	target	config	section	`7775bec`	`f6bcf17`	change	% change
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	text	807248	807252	4	0.0

Full report (7 builds for cc32xx, mbed, nrfconnect, qpg)

platform	target	config	section	`7775bec`	`f6bcf17`	change
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0
			(read only)	642681	642681	0
			(read/write)	203672	203672	0
			.ARM.attributes	44	44	0
			.ARM.exidx	8	8	0
			.bss	197072	197072	0
			.comment	194	194	0
			.data	1480	1480	0
			.debug_abbrev	930133	930133	0
			.debug_aranges	87304	87304	0
			.debug_frame	299872	299872	0
			.debug_info	20257010	20257010	0
			.debug_line	2656183	2656183	0
			.debug_loc	`2797535`	`2797535`	0
			.debug_ranges	281792	281792	0
			.debug_str	3023459	3023459	0
			.ramVecs	780	780	0
			.resetVecs	64	64	0
			.rodata	105769	105769	0
			.shstrtab	232	232	0
			.stab	204	204	0
			.stabstr	441	441	0
			.stack	2048	2048	0
			.strtab	377825	377825	0
			.symtab	256256	256256	0
			.text	534788	534788	0
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0
			(read/write)	2467168	2467168	0
			.bss	215788	215788	0
			.data	5880	5880	0
			.text	1429812	1429812	0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read only)	4	4	0
			(read/write)	1165520	1165520	0
			bss	143423	143423	0
			rodata	135004	135004	0
			text	807248	807252	4
	all-clusters-minimal-app	nrf52840dk_nrf52840	(read only)	4	4	0
			(read/write)	1110532	1110532	0
			bss	142579	142579	0
			rodata	111856	111856	0
			text	776384	776384	0
	all-clusters-app	nrf7002dk_nrf5340_cpuapp	(read only)	4	4	0
			(read/write)	1370708	1370708	0
			bss	105886	105886	0
			rodata	212400	212400	0
			text	766912	766912	0
qpg	lighting-app	qpg6105+debug	(read/write)	`1151340`	`1151340`	0
			.bss	99804	99804	0
			.data	852	852	0
			.text	598436	598436	0
	lock-app	qpg6105+debug	(read/write)	1118540	1118540	0
			.bss	96292	96292	0
			.data	864	864	0
			.text	565640	565640	0

Co-authored-by: Boris Zbarsky <[email protected]>

src/darwin/Framework/CHIP/MTROTAProviderDelegateBridge.mm

Co-authored-by: Boris Zbarsky <[email protected]>

github-actions · 2023-02-24T21:47:40Z

PR #24933: Size comparison from 31da720 to 8bcc23b

Decreases (1 build for cc32xx)

platform	target	config	section	`31da720`	`8bcc23b`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_info	20256908	20256907	-1	-0.0

Full report (1 build for cc32xx)

platform	target	config	section	`31da720`	`8bcc23b`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0	0.0
			(read only)	642681	642681	0	0.0
			(read/write)	203672	203672	0	0.0
			.ARM.attributes	44	44	0	0.0
			.ARM.exidx	8	8	0	0.0
			.bss	197072	197072	0	0.0
			.comment	194	194	0	0.0
			.data	1480	1480	0	0.0
			.debug_abbrev	930077	930077	0	0.0
			.debug_aranges	87280	87280	0	0.0
			.debug_frame	299816	299816	0	0.0
			.debug_info	20256908	20256907	-1	-0.0
			.debug_line	2656086	2656086	0	0.0
			.debug_loc	`2797535`	`2797535`	0	0.0
			.debug_ranges	281768	281768	0	0.0
			.debug_str	`3023369`	`3023369`	0	0.0
			.ramVecs	780	780	0	0.0
			.resetVecs	64	64	0	0.0
			.rodata	105769	105769	0	0.0
			.shstrtab	232	232	0	0.0
			.stab	204	204	0	0.0
			.stabstr	441	441	0	0.0
			.stack	2048	2048	0	0.0
			.strtab	377825	377825	0	0.0
			.symtab	256256	256256	0	0.0
			.text	534788	534788	0	0.0

…onfigure State

bzbarsky-apple · 2023-02-24T22:04:18Z

Fast-tracking platform-specific change with platform owner review.

github-actions · 2023-02-24T22:06:20Z

PR #24933: Size comparison from 31da720 to b9faa4e

Decreases (1 build for cc32xx)

platform	target	config	section	`31da720`	`b9faa4e`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_info	20256908	20256906	-2	-0.0

Full report (1 build for cc32xx)

platform	target	config	section	`31da720`	`b9faa4e`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0	0.0
			(read only)	642681	642681	0	0.0
			(read/write)	203672	203672	0	0.0
			.ARM.attributes	44	44	0	0.0
			.ARM.exidx	8	8	0	0.0
			.bss	197072	197072	0	0.0
			.comment	194	194	0	0.0
			.data	1480	1480	0	0.0
			.debug_abbrev	930077	930077	0	0.0
			.debug_aranges	87280	87280	0	0.0
			.debug_frame	299816	299816	0	0.0
			.debug_info	20256908	20256906	-2	-0.0
			.debug_line	2656086	2656086	0	0.0
			.debug_loc	`2797535`	`2797535`	0	0.0
			.debug_ranges	281768	281768	0	0.0
			.debug_str	`3023369`	`3023369`	0	0.0
			.ramVecs	780	780	0	0.0
			.resetVecs	64	64	0	0.0
			.rodata	105769	105769	0	0.0
			.shstrtab	232	232	0	0.0
			.stab	204	204	0	0.0
			.stabstr	441	441	0	0.0
			.stack	2048	2048	0	0.0
			.strtab	377825	377825	0	0.0
			.symtab	256256	256256	0	0.0
			.text	534788	534788	0	0.0

…er (project-chip#24933) * Clean up the code that sends the query image response from the provider * Update src/darwin/Framework/CHIP/MTROTAProviderDelegateBridge.mm Co-authored-by: Boris Zbarsky <[email protected]> * Update src/darwin/Framework/CHIP/MTROTAProviderDelegateBridge.mm Co-authored-by: Boris Zbarsky <[email protected]> * Update src/darwin/Framework/CHIP/MTROTAProviderDelegateBridge.mm Co-authored-by: Boris Zbarsky <[email protected]> * Update src/darwin/Framework/CHIP/MTROTAProviderDelegateBridge.mm Co-authored-by: Boris Zbarsky <[email protected]> * Address review comments * Update src/darwin/Framework/CHIP/MTROTAProviderDelegateBridge.mm Co-authored-by: Boris Zbarsky <[email protected]> * Add comments for why we do not reset state when we return busy from Configure State --------- Co-authored-by: Boris Zbarsky <[email protected]>

nivi-apple requested a review from bzbarsky-apple February 9, 2023 00:20

github-actions bot added the darwin label Feb 9, 2023

nivi-apple force-pushed the ota_cleanup branch from 783bf2b to 07667b2 Compare February 9, 2023 00:23

nivi-apple closed this Feb 23, 2023

nivi-apple force-pushed the ota_cleanup branch from e58687a to 7775bec Compare February 23, 2023 22:37

github-actions bot removed the darwin label Feb 23, 2023

nivi-apple reopened this Feb 23, 2023

github-actions bot added the darwin label Feb 23, 2023

bzbarsky-apple reviewed Feb 23, 2023

View reviewed changes

nivi-apple and others added 5 commits February 24, 2023 10:55

Clean up the code that sends the query image response from the provider

be2f7fb

Update src/darwin/Framework/CHIP/MTROTAProviderDelegateBridge.mm

214b7bc

Co-authored-by: Boris Zbarsky <[email protected]>

Update src/darwin/Framework/CHIP/MTROTAProviderDelegateBridge.mm

e2a2f08

Co-authored-by: Boris Zbarsky <[email protected]>

Update src/darwin/Framework/CHIP/MTROTAProviderDelegateBridge.mm

8f980ea

Co-authored-by: Boris Zbarsky <[email protected]>

Update src/darwin/Framework/CHIP/MTROTAProviderDelegateBridge.mm

920c904

Co-authored-by: Boris Zbarsky <[email protected]>

nivi-apple force-pushed the ota_cleanup branch from f6bcf17 to f5e1ce7 Compare February 24, 2023 18:57

Address review comments

43bba83

nivi-apple force-pushed the ota_cleanup branch from f5e1ce7 to 43bba83 Compare February 24, 2023 18:59

bzbarsky-apple reviewed Feb 24, 2023

View reviewed changes

src/darwin/Framework/CHIP/MTROTAProviderDelegateBridge.mm Outdated Show resolved Hide resolved

src/darwin/Framework/CHIP/MTROTAProviderDelegateBridge.mm Outdated Show resolved Hide resolved

Update src/darwin/Framework/CHIP/MTROTAProviderDelegateBridge.mm

b23b0ed

Co-authored-by: Boris Zbarsky <[email protected]>

nivi-apple force-pushed the ota_cleanup branch from 8bcc23b to f7cd68f Compare February 24, 2023 21:54

Add comments for why we do not reset state when we return busy from C…

b9faa4e

…onfigure State

nivi-apple force-pushed the ota_cleanup branch from f7cd68f to b9faa4e Compare February 24, 2023 21:56

bzbarsky-apple approved these changes Feb 24, 2023

View reviewed changes

bzbarsky-apple added the fast track label Feb 24, 2023

bzbarsky-apple merged commit 265d55c into project-chip:master Feb 25, 2023

nivi-apple mentioned this pull request Jul 11, 2023

Map the chip error in MTROTAProviderDelegateBridge.mm to the correct Protocols::InteractionModel::Status code #24838

Closed

nivi-apple deleted the ota_cleanup branch March 5, 2024 00:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clean up the code that sends the query image response from the provider #24933

Clean up the code that sends the query image response from the provider #24933

nivi-apple commented Feb 9, 2023

github-actions bot commented Feb 23, 2023

github-actions bot commented Feb 24, 2023

github-actions bot commented Feb 24, 2023

bzbarsky-apple commented Feb 24, 2023

github-actions bot commented Feb 24, 2023

Clean up the code that sends the query image response from the provider #24933

Clean up the code that sends the query image response from the provider #24933

Conversation

nivi-apple commented Feb 9, 2023

github-actions bot commented Feb 23, 2023

github-actions bot commented Feb 24, 2023

github-actions bot commented Feb 24, 2023

bzbarsky-apple commented Feb 24, 2023

github-actions bot commented Feb 24, 2023