Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map the chip error in MTROTAProviderDelegateBridge.mm to the correct Protocols::InteractionModel::Status code #24838

Closed
nivi-apple opened this issue Feb 2, 2023 · 2 comments
Assignees
Labels
Milestone

Comments

@nivi-apple
Copy link
Contributor

In the provider delegate bridge on the sdk we send a general failure as the handler status rather than mapping the chip error we get to the right error code. Need to add mapping for the same.

Below is the snippet of code -

err = bdx::MakeURI(targetNodeId.GetNodeId(), AsCharSpan(data.imageURI), uri);
if (CHIP_NO_ERROR != err) {
LogErrorOnFailure(err);
handler->AddStatus(cachedCommandPath, Protocols::InteractionModel::Status::Failure);

@woody-apple
Copy link
Contributor

@nivi-apple ?

@nivi-apple
Copy link
Contributor Author

Fixed by PR - #24933

@github-project-automation github-project-automation bot moved this from Todo to Done in [Platform] Darwin Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

3 participants