Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PICS] Update PICS.yaml with the latest PICS from the test plan, upda… #24923

Merged
merged 2 commits into from
Feb 8, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions src/app/tests/suites/TestDiscovery.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ tests:
# Find a way to validate the service type and the service domain

- label: "Check Hostname"
PICS: "(WIFI || ETH) && !THREAD"
PICS: "(MCORE.COM.WIFI || MCORE.COM.ETH) && !MCORE.COM.THR"
# On macOS the hostname is the device name and because of it this test is disabled for now.
disabled: true
cluster: "DiscoveryCommands"
Expand All @@ -119,7 +119,7 @@ tests:
isHexString: true

- label: "Check Hostname"
PICS: "(!WIFI && !ETH) && THREAD"
PICS: "(!MCORE.COM.WIFI && !MCORE.COM.ETH) && MCORE.COM.THR"
# On macOS the hostname is the device name and because of it this test is disabled for now.
disabled: true
cluster: "DiscoveryCommands"
Expand Down Expand Up @@ -156,7 +156,7 @@ tests:
command: "FindCommissionableByCommissioningMode"

- label: "Check Vendor ID (_V)"
PICS: VENDOR_SUBTYPE
PICS: MCORE.SC.VENDOR_SUBTYPE
cluster: "DiscoveryCommands"
command: "FindCommissionableByVendorId"
arguments:
Expand All @@ -167,7 +167,7 @@ tests:
- label: "Check Device Type ID (_T)"
# The device type is not broadcasted by the accessory under CI.
disabled: true
PICS: DEVTYPE_SUBTYPE
PICS: MCORE.SC.DEVTYPE_SUBTYPE
cluster: "DiscoveryCommands"
command: "FindCommissionableByDeviceType"
arguments:
Expand All @@ -189,7 +189,7 @@ tests:
maxValue: 4096

- label: "TXT key for Vendor ID and Product ID (VP)"
PICS: VP_KEY
PICS: MCORE.SC.VP_KEY
cluster: "DiscoveryCommands"
command: "FindCommissionable"
response:
Expand All @@ -200,7 +200,7 @@ tests:
# Maybe it should be a PICS code to differentiate between manufacturer that wants to broadcast the
# product id ?
- label: "TXT key for Vendor ID and Product ID (VP)"
PICS: VP_KEY
PICS: MCORE.SC.VP_KEY
optional: true
cluster: "DiscoveryCommands"
command: "FindCommissionable"
Expand All @@ -209,8 +209,8 @@ tests:
- name: "productId"
value: productId

- label: "Optional TXT key for MRP Retry Interval Idle (CRI)"
PICS: CRI_COMM_DISCOVERY_KEY
- label: "Optional TXT key for MRP Sleepy Idle Interval (SII)"
PICS: MCORE.SC.SII_COMM_DISCOVERY_KEY
cluster: "DiscoveryCommands"
command: "FindCommissionable"
response:
Expand All @@ -219,8 +219,8 @@ tests:
constraints:
maxValue: 3600000

- label: "Optional TXT key for MRP Retry Interval Active (CRA)"
PICS: CRA_COMM_DISCOVERY_KEY
- label: "Optional TXT key for MRP Sleepy Active Interval (SAI)"
PICS: MCORE.SC.SAI_COMM_DISCOVERY_KEY
cluster: "DiscoveryCommands"
command: "FindCommissionable"
response:
Expand All @@ -239,7 +239,7 @@ tests:

- label: "Optional TXT key for device type (DT)"
disabled: true
PICS: DT_KEY
PICS: MCORE.SC.DT_KEY
cluster: "DiscoveryCommands"
command: "FindCommissionable"
response:
Expand All @@ -252,7 +252,7 @@ tests:
maxValue: 999

- label: "Optional TXT key for device name (DN)"
PICS: DN_KEY
PICS: MCORE.SC.DN_KEY
cluster: "DiscoveryCommands"
command: "FindCommissionable"
response:
Expand All @@ -262,7 +262,7 @@ tests:
maxLength: 32

- label: "Optional TXT key for rotating device identifier (RI)"
PICS: RI_KEY
PICS: MCORE.SC.RI_KEY
cluster: "DiscoveryCommands"
command: "FindCommissionable"
response:
Expand All @@ -272,7 +272,7 @@ tests:
maxValue: 100

- label: "Optional TXT key for pairing hint (PH)"
PICS: PH_KEY
PICS: MCORE.SC.PH_KEY
cluster: "DiscoveryCommands"
command: "FindCommissionable"
response:
Expand All @@ -282,7 +282,7 @@ tests:
notValue: 0

- label: "Optional TXT key for pairing instructions (PI)"
PICS: PI_KEY
PICS: MCORE.SC.PI_KEY
cluster: "DiscoveryCommands"
command: "FindCommissionable"
response:
Expand Down
Loading