Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PICS] Update PICS.yaml with the latest PICS from the test plan, upda… #24923

Merged
merged 2 commits into from
Feb 8, 2023

Conversation

vivien-apple
Copy link
Contributor

…te ci-pics-values accordingly and add many missing keys, remove some unknown keys, fix some mistype keys and apply the relevant changes to the related testcases

Problem

I initially found that PICS_MCORE_UI_FACTORYRESET and MCORE.FACTORY_RESET coexists in our YAML tests.
I then tried to update the PICS.yaml file that is the reference for our default CI PICS configuration at src/app/tests/suites/certification/ci-pics-values

It appears that they were a lot of differences between the latest PICS database and ours. I have updated PICS.yaml and ci-pics-values to reflect that. I have also updated out tests suites to reflect that.

The test plan database was missing some keys as well. I have opened https://github.com/CHIP-Specifications/chip-test-plans/pull/2427 for that...

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

PR #24923: Size comparison from c49ee00 to 09bb896

Increases (1 build for cc32xx)
platform target config section c49ee00 09bb896 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20141926 20141927 1 0.0
Full report (1 build for cc32xx)
platform target config section c49ee00 09bb896 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 640249 640249 0 0.0
(read/write) 204084 204084 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197488 197488 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 928439 928439 0 0.0
.debug_aranges 87352 87352 0 0.0
.debug_frame 299840 299840 0 0.0
.debug_info 20141926 20141927 1 0.0
.debug_line 2649806 2649806 0 0.0
.debug_loc 2785917 2785917 0 0.0
.debug_ranges 280720 280720 0 0.0
.debug_str 2979174 2979174 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105601 105601 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 375840 375840 0 0.0
.symtab 255856 255856 0 0.0
.text 532524 532524 0 0.0

Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this ends up running/skipping the same set of tests as before, looks good.

…te ci-pics-values accordingly and add many missing keys, remove some unknown keys, fix some mistype keys and apply the relevant changes to the related testcases
@github-actions
Copy link

github-actions bot commented Feb 8, 2023

PR #24923: Size comparison from c49ee00 to 18db7cc

Increases (2 builds for cc32xx, nrfconnect)
platform target config section c49ee00 18db7cc change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20141926 20141928 2 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1162340 1162356 16 0.0
text 804540 804544 4 0.0
Full report (10 builds for cc32xx, k32w, mbed, nrfconnect, qpg)
platform target config section c49ee00 18db7cc change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 640249 640249 0 0.0
(read/write) 204084 204084 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197488 197488 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 928439 928439 0 0.0
.debug_aranges 87352 87352 0 0.0
.debug_frame 299840 299840 0 0.0
.debug_info 20141926 20141928 2 0.0
.debug_line 2649806 2649806 0 0.0
.debug_loc 2785917 2785917 0 0.0
.debug_ranges 280720 280720 0 0.0
.debug_str 2979174 2979174 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105601 105601 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 375840 375840 0 0.0
.symtab 255856 255856 0 0.0
.text 532524 532524 0 0.0
k32w contact k32w0+release (read/write) 660108 660108 0 0.0
.bss 76560 76560 0 0.0
.data 2112 2112 0 0.0
.text 562324 562324 0 0.0
light k32w0+release (read/write) 672368 672368 0 0.0
.bss 74344 74344 0 0.0
.data 2064 2064 0 0.0
.text 593232 593232 0 0.0
lock k32w0+release (read/write) 631760 631760 0 0.0
.bss 75112 75112 0 0.0
.data 2084 2084 0 0.0
.text 551836 551836 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2464592 2464592 0 0.0
.bss 215892 215892 0 0.0
.data 5880 5880 0 0.0
.text 1427236 1427236 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1162340 1162356 16 0.0
bss 143531 143531 0 0.0
rodata 134384 134384 0 0.0
text 804540 804544 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1108360 1108360 0 0.0
bss 142687 142687 0 0.0
rodata 111364 111364 0 0.0
text 774540 774540 0 0.0
all-clusters-app nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1367608 1367608 0 0.0
bss 105990 105990 0 0.0
rodata 211816 211816 0 0.0
text 764276 764276 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1148688 1148688 0 0.0
.bss 99876 99876 0 0.0
.data 848 848 0 0.0
.text 595788 595788 0 0.0
lock-app qpg6105+debug (read/write) 1116752 1116752 0 0.0
.bss 96396 96396 0 0.0
.data 860 860 0 0.0
.text 563848 563848 0 0.0

@vivien-apple
Copy link
Contributor Author

I looked at how many steps are skipped before and after this change. In both cases the CI is skipping 666 steps at the moment.

@vivien-apple vivien-apple enabled auto-merge (squash) February 8, 2023 20:16
@vivien-apple vivien-apple merged commit c6dab5e into project-chip:master Feb 8, 2023
lpbeliveau-silabs pushed a commit to lpbeliveau-silabs/connectedhomeip that referenced this pull request Feb 13, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants