Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rpc: Make DeviceInfo SerialNumber field optional #24851

Merged
merged 1 commit into from
Feb 4, 2023
Merged

Rpc: Make DeviceInfo SerialNumber field optional #24851

merged 1 commit into from
Feb 4, 2023

Conversation

rgoliver
Copy link

@rgoliver rgoliver commented Feb 3, 2023

Problem:
The Device.DeviceInfo RPC currently returns an error if the serial number is not available:

>>> rpcs.chip.rpc.Device.GetDeviceInfo()
(Status.INTERNAL, chip.rpc.DeviceInfo(vendor_id=65521, product_id=32774, software_version=1, pairing_info=chip.rpc.PairingInfo(discriminator=3840), software_version_string='1.0'))

After #24346 Efr32 lock app does not provide a serial number.

Change:
SerialNumber field now just not set if it is not available and returns OK.

Test:
Tested on EFR32 lock rpc build:

>>> rpcs.chip.rpc.Device.GetDeviceInfo()
(Status.OK, chip.rpc.DeviceInfo(vendor_id=65521, product_id=32774, software_version=1, pairing_info=chip.rpc.PairingInfo(discriminator=3840, qr_code='MT:8IXS142C00KA0648G00', qr_code_url='https://project-chip.github.io/connectedhomeip/qrcode.html?data=MT%3A8IXS142C00KA0648G00'), software_version_string='1.0'))

Rpc: Make GetSerialNumber optional
dbffbb9 
GetSerialNumber previously returned an error if not provided, this
is optional in the spec and should just not return the value if it
is not available.
@github-actions
Copy link

github-actions bot commented Feb 3, 2023 •
edited
Loading

PR #24851: Size comparison from 87e7510 to dbffbb9

Increases (4 builds for cc13x2_26x2, esp32, psoc6, telink)
platform target config section 87e7510 dbffbb9 change % change
cc13x2_26x2 shell LP_CC2652R7 (read only) 668590 668598 8 0.0
.text 584016 584024 8 0.0
esp32 all-clusters-app c3devkit (read only) 1047340 1047344 4 0.0
.flash.text 1047340 1047344 4 0.0
psoc6 all-clusters-minimal cy8ckit_062s2_43012 .debug_info 27080391 27080392 1 0.0
telink ota-requestor-app tlsr9518adk80d text 604746 604748 2 0.0
Decreases (10 builds for bl602, bl702, cc13x2_26x2, cyw30739, esp32, nrfconnect, telink)
platform target config section 87e7510 dbffbb9 change % change
bl602 lighting-app bl602 (read/write) 1346102 1346094 -8 -0.0
.text 1023098 1023094 -4 -0.0
bl602+rpc .text 1053776 1053774 -2 -0.0
bl702 lighting-app bl702+rpc .debug_info 44608819 44608818 -1 -0.0
.text 1029156 1029154 -2 -0.0
cc13x2_26x2 shell LP_CC2652R7 (read/write) 184664 184656 -8 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584194 584186 -8 -0.0
.app_xip_area 461012 461004 -8 -0.0
esp32 all-clusters-app m5stack (read/write) 500387 500383 -4 -0.0
.flash.rodata 249528 249524 -4 -0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 774424 774420 -4 -0.0
telink all-clusters-app tlsr9518adk80d (read/write) 1016100 1016092 -8 -0.0
text 686130 686126 -4 -0.0
all-clusters-minimal-app tlsr9518adk80d text 648424 648422 -2 -0.0
contact-sensor-app tlsr9518adk80d text 579330 579328 -2 -0.0
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 87e7510 dbffbb9 change % change
bl602 lighting-app bl602 (read/write) 1346102 1346094 -8 -0.0
.bss 94794 94794 0 0.0
.data 9736 9736 0 0.0
.text 1023098 1023094 -4 -0.0
bl602+rpc (read/write) 1391286 1391286 0 0.0
.bss 102842 102842 0 0.0
.data 10128 10128 0 0.0
.text 1053776 1053774 -2 -0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1184091 1184091 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 69905 69905 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4056 4056 0 0.0
.debug_abbrev 1550392 1550392 0 0.0
.debug_aranges 134128 134128 0 0.0
.debug_frame 491212 491212 0 0.0
.debug_info 40212336 40212336 0 0.0
.debug_line 5267956 5267956 0 0.0
.debug_loc 3401541 3401541 0 0.0
.debug_ranges 371800 371800 0 0.0
.debug_str 3535643 3535643 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 106864 106864 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 572228 572228 0 0.0
.symtab 173328 173328 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
952132 952132 0 0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1276783 1276783 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 77953 77953 0 0.0
.bss_psram 30304 30304 0 0.0
.comment 48 48 0 0.0
.data 4608 4608 0 0.0
.debug_abbrev 1698806 1698806 0 0.0
.debug_aranges 142352 142352 0 0.0
.debug_frame 518916 518916 0 0.0
.debug_info 44608819 44608818 -1 -0.0
.debug_line 5666424 5666424 0 0.0
.debug_loc 3597833 3597833 0 0.0
.debug_ranges 395504 395504 0 0.0
.debug_str 3938881 3938881 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121408 121408 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 632825 632825 0 0.0
.symtab 191680 191680 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1029156 1029154 -2 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 677351 677351 0 0.0
(read/write) 173832 173832 0 0.0
.bss 80876 80876 0 0.0
.data 3384 3384 0 0.0
.rodata 87527 87527 0 0.0
.text 589508 589508 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 641359 641359 0 0.0
(read/write) 157568 157568 0 0.0
.bss 80068 80068 0 0.0
.data 3384 3384 0 0.0
.rodata 77479 77479 0 0.0
.text 563560 563560 0 0.0
lock-ftd LP_CC2652R7 (read only) 674451 674451 0 0.0
(read/write) 174076 174076 0 0.0
.bss 78308 78308 0 0.0
.data 3312 3312 0 0.0
.rodata 76323 76323 0 0.0
.text 597648 597648 0 0.0
lock-mtd LP_CC2652R7 (read only) 660987 660987 0 0.0
(read/write) 182804 182804 0 0.0
.bss 73572 73572 0 0.0
.data 3312 3312 0 0.0
.rodata 102899 102899 0 0.0
.text 557608 557608 0 0.0
pump-app LP_CC2652R7 (read only) 687431 687431 0 0.0
(read/write) 161832 161832 0 0.0
.bss 78276 78276 0 0.0
.data 3276 3276 0 0.0
.rodata 90535 90535 0 0.0
.text 596416 596416 0 0.0
pump-controller-app LP_CC2652R7 (read only) 672839 672839 0 0.0
(read/write) 176536 176536 0 0.0
.bss 78388 78388 0 0.0
.data 3300 3300 0 0.0
.rodata 86615 86615 0 0.0
.text 585744 585744 0 0.0
shell LP_CC2652R7 (read only) 668590 668598 8 0.0
(read/write) 184664 184656 -8 -0.0
.bss 82948 82948 0 0.0
.data 3380 3380 0 0.0
.rodata 84262 84262 0 0.0
.text 584016 584024 8 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584194 584186 -8 -0.0
.app_xip_area 461012 461004 -8 -0.0
.bss 65632 65632 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 588078 588078 0 0.0
.app_xip_area 459600 459600 0 0.0
.bss 70920 70920 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 549690 549690 0 0.0
.app_xip_area 431988 431988 0 0.0
.bss 60192 60192 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs911x (read/write) 1038144 1038144 0 0.0
.bss 181560 181560 0 0.0
.data 2044 2044 0 0.0
.text 854516 854516 0 0.0
BRD4187C (read/write) 1151328 1151328 0 0.0
.bss 132856 132856 0 0.0
.data 2544 2544 0 0.0
.text 991332 991332 0 0.0
lock-app BRD4161A+wf200 (read/write) 1065792 1065792 0 0.0
.bss 153088 153088 0 0.0
.data 2052 2052 0 0.0
.text 910632 910632 0 0.0
window-app BRD4187C (read/write) 1146220 1146220 0 0.0
.bss 134360 134360 0 0.0
.data 2572 2572 0 0.0
.text 984692 984692 0 0.0
esp32 all-clusters-app c3devkit (read only) 1047340 1047344 4 0.0
(read/write) 1518738 1518738 0 0.0
.dram0.bss 77960 77960 0 0.0
.dram0.data 13792 13792 0 0.0
.flash.rodata 220760 220760 0 0.0
.flash.text 1047340 1047344 4 0.0
.iram0.text 72896 72896 0 0.0
m5stack (read only) 1099799 1099799 0 0.0
(read/write) 500387 500383 -4 -0.0
.dram0.bss 83008 83008 0 0.0
.dram0.data 34080 34080 0 0.0
.flash.rodata 249528 249524 -4 -0.0
.flash.text 1094415 1094415 0 0.0
.iram0.text 124855 124855 0 0.0
k32w contact k32w0+release (read/write) 659768 659768 0 0.0
.bss 76560 76560 0 0.0
.data 2112 2112 0 0.0
.text 561984 561984 0 0.0
light k32w0+release (read/write) 671884 671884 0 0.0
.bss 74344 74344 0 0.0
.data 2064 2064 0 0.0
.text 592748 592748 0 0.0
lock k32w0+release (read/write) 631308 631308 0 0.0
.bss 75112 75112 0 0.0
.data 2084 2084 0 0.0
.text 551384 551384 0 0.0
linux all-clusters-app debug (read only) 3158033 3158033 0 0.0
(read/write) 154864 154864 0 0.0
.bss 63744 63744 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 82248 82248 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1192 1192 0 0.0
.rodata 283979 283979 0 0.0
.text 2688562 2688562 0 0.0
all-clusters-minimal-app debug (read only) 2973985 2973985 0 0.0
(read/write) 148080 148080 0 0.0
.bss 62880 62880 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 76472 76472 0 0.0
.dynamic 608 608 0 0.0
.got 4688 4688 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 282667 282667 0 0.0
.text 2509154 2509154 0 0.0
bridge-app debug (read only) 2526897 2526897 0 0.0
(read/write) 132352 132352 0 0.0
.bss 53632 53632 0 0.0
.data 3632 3632 0 0.0
.data.rel.ro 68968 68968 0 0.0
.dynamic 608 608 0 0.0
.got 4616 4616 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 214176 214176 0 0.0
.text 2140258 2140258 0 0.0
chip-tool debug (read only) 12665521 12665521 0 0.0
(read/write) 676144 676144 0 0.0
.bss 26264 26264 0 0.0
.data 3042 3042 0 0.0
.data.rel.ro 640088 640088 0 0.0
.dynamic 608 608 0 0.0
.got 5352 5352 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 651781 651781 0 0.0
.text 10440372 10440372 0 0.0
chip-tool-ipv6only arm64 (read only) 11940964 11940964 0 0.0
(read/write) 726664 726664 0 0.0
.bss 34248 34248 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 668952 668952 0 0.0
.dynamic 560 560 0 0.0
.got 15256 15256 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 581300 581300 0 0.0
.text 9632900 9632900 0 0.0
lighting-app debug+rpc (read only) 2694505 2694505 0 0.0
(read/write) 131688 131688 0 0.0
.bss 51104 51104 0 0.0
.data 2288 2288 0 0.0
.data.rel.ro 72088 72088 0 0.0
.dynamic 608 608 0 0.0
.got 4648 4648 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 230112 230112 0 0.0
.text 2286962 2286962 0 0.0
lock-app debug (read only) 2658689 2658689 0 0.0
(read/write) 126736 126736 0 0.0
.bss 49536 49536 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 69080 69080 0 0.0
.dynamic 608 608 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 246408 246408 0 0.0
.text 2239698 2239698 0 0.0
ota-provider-app debug (read only) 2227353 2227353 0 0.0
(read/write) 106512 106512 0 0.0
.bss 47712 47712 0 0.0
.data 2080 2080 0 0.0
.data.rel.ro 51608 51608 0 0.0
.dynamic 608 608 0 0.0
.got 3744 3744 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 197704 197704 0 0.0
.text 1889058 1889058 0 0.0
ota-requestor-app debug (read only) 2388865 2388865 0 0.0
(read/write) 114240 114240 0 0.0
.bss 50176 50176 0 0.0
.data 2480 2480 0 0.0
.data.rel.ro 56376 56376 0 0.0
.dynamic 608 608 0 0.0
.got 3744 3744 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 204656 204656 0 0.0
.text 2034594 2034594 0 0.0
shell debug (read only) 2687481 2687481 0 0.0
(read/write) 139360 139360 0 0.0
.bss 59144 59144 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 73136 73136 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 242066 242066 0 0.0
.text 2284898 2284898 0 0.0
thermostat-no-ble arm64 (read only) 2509052 2509052 0 0.0
(read/write) 144744 144744 0 0.0
.bss 56456 56456 0 0.0
.data 1824 1824 0 0.0
.data.rel.ro 77016 77016 0 0.0
.dynamic 560 560 0 0.0
.got 5408 5408 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 150984 150984 0 0.0
.text 2096096 2096096 0 0.0
tv-app debug (read only) 3317081 3317081 0 0.0
(read/write) 259632 259632 0 0.0
.bss 170872 170872 0 0.0
.data 3904 3904 0 0.0
.data.rel.ro 78144 78144 0 0.0
.dynamic 608 608 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 270776 270776 0 0.0
.text 2851506 2851506 0 0.0
tv-casting-app debug (read only) 6722817 6722817 0 0.0
(read/write) 185304 185304 0 0.0
.bss 53560 53560 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 123176 123176 0 0.0
.dynamic 608 608 0 0.0
.got 4928 4928 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 366036 366036 0 0.0
.text 6021026 6021026 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2464072 2464072 0 0.0
.bss 215892 215892 0 0.0
.data 5880 5880 0 0.0
.text 1426716 1426716 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1161400 1161400 0 0.0
bss 143531 143531 0 0.0
rodata 133556 133556 0 0.0
text 804428 804428 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1366668 1366668 0 0.0
bss 105990 105990 0 0.0
rodata 210988 210988 0 0.0
text 764160 764160 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1107584 1107584 0 0.0
bss 142687 142687 0 0.0
rodata 110700 110700 0 0.0
text 774424 774420 -4 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 840872 840872 0 0.0
(read/write) 1756516 1756516 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189800 189800 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2672 2672 0 0.0
.debug_abbrev 1251930 1251930 0 0.0
.debug_aranges 111392 111392 0 0.0
.debug_frame 373948 373948 0 0.0
.debug_info 27524520 27524520 0 0.0
.debug_line 3781071 3781071 0 0.0
.debug_loc 3676049 3676049 0 0.0
.debug_ranges 362456 362456 0 0.0
.debug_str 3486476 3486476 0 0.0
.heap 840872 840872 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 578105 578105 0 0.0
.symtab 424864 424864 0 0.0
.text 1555656 1555656 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 841688 841688 0 0.0
(read/write) 1698276 1698276 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188992 188992 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1237601 1237601 0 0.0
.debug_aranges 110656 110656 0 0.0
.debug_frame 376392 376392 0 0.0
.debug_info 27080391 27080392 1 0.0
.debug_line 3789417 3789417 0 0.0
.debug_loc 3659779 3659779 0 0.0
.debug_ranges 360424 360424 0 0.0
.debug_str 3472229 3472229 0 0.0
.heap 841688 841688 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 539313 539313 0 0.0
.symtab 410144 410144 0 0.0
.text 1498232 1498232 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850008 850008 0 0.0
(read/write) 1611724 1611724 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180872 180872 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1071935 1071935 0 0.0
.debug_aranges 102864 102864 0 0.0
.debug_frame 346828 346828 0 0.0
.debug_info 22502922 22502922 0 0.0
.debug_line 3341713 3341713 0 0.0
.debug_loc 3337839 3337839 0 0.0
.debug_ranges 319600 319600 0 0.0
.debug_str 3275475 3275475 0 0.0
.heap 850008 850008 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 474518 474518 0 0.0
.symtab 377920 377920 0 0.0
.text 1420000 1420000 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845024 845024 0 0.0
(read/write) 1645940 1645940 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 185848 185848 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1073639 1073639 0 0.0
.debug_aranges 103304 103304 0 0.0
.debug_frame 348768 348768 0 0.0
.debug_info 2272852 2272852 0 0.0
.debug_line 3343626 3343626 0 0.0
.debug_loc 3360643 3360643 0 0.0
.debug_ranges 321512 321512 0 0.0
.debug_str 3292701 3292701 0 0.0
.heap 845024 845024 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 477894 477894 0 0.0
.symtab 380080 380080 0 0.0
.text 1449232 1449232 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1148212 1148212 0 0.0
.bss 99876 99876 0 0.0
.data 848 848 0 0.0
.text 595312 595312 0 0.0
lock-app qpg6105+debug (read/write) 1116204 1116204 0 0.0
.bss 96396 96396 0 0.0
.data 860 860 0 0.0
.text 563300 563300 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1016100 1016092 -8 -0.0
bss 97980 97980 0 0.0
text 686130 686126 -4 -0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 952648 952648 0 0.0
bss 97028 97028 0 0.0
text 648424 648422 -2 -0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 857980 857980 0 0.0
bss 89152 89152 0 0.0
text 579330 579328 -2 -0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 873680 873680 0 0.0
bss 89240 89240 0 0.0
text 593378 593378 0 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 951004 951004 0 0.0
bss 97388 97388 0 0.0
text 658780 658780 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 887848 887848 0 0.0
bss 90188 90188 0 0.0
text 604746 604748 2 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 877888 877888 0 0.0
bss 90628 90628 0 0.0
text 594954 594954 0 0.0

@rgoliver rgoliver changed the title Rpc: Make GetSerialNumber optional Rpc: Make DeviceInfo SerialNumber field optional Feb 3, 2023
@bzbarsky-apple bzbarsky-apple merged commit 655d134 into project-chip:master Feb 4, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
Rpc: Make GetSerialNumber optional (project-chip#24851)
f5132ce 
GetSerialNumber previously returned an error if not provided, this
is optional in the spec and should just not return the value if it
is not available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rgoliver @andy31415 @bzbarsky-apple