-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs] Remove generic base class init from configuration manager #24346
Merged
jepenven-silabs
merged 3 commits into
project-chip:master
from
mkardous-silabs:fix/data_provider
Jan 20, 2023
Merged
[Silabs] Remove generic base class init from configuration manager #24346
jepenven-silabs
merged 3 commits into
project-chip:master
from
mkardous-silabs:fix/data_provider
Jan 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmartinez-silabs
approved these changes
Jan 10, 2023
andy31415
approved these changes
Jan 10, 2023
PR #24346: Size comparison from 6a0fb2e to d270d77 Increases (5 builds for cc13x2_26x2, psoc6, telink)
Decreases (8 builds for bl602, bl702, cc13x2_26x2, cyw30739, esp32, telink)
Full report (49 builds for bl602, bl702, cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jtung-apple,
ksperling-apple,
lazarkov,
LuDuda,
msandstedt,
saurabhst,
vijs,
vivien-apple,
woody-apple and
xylophone21
January 10, 2023 16:57
jmeg-sfy
approved these changes
Jan 18, 2023
mkardous-silabs
force-pushed
the
fix/data_provider
branch
from
January 20, 2023 14:16
c0082f1
to
f855965
Compare
PR #24346: Size comparison from f683392 to f855965 Increases (13 builds for bl602, bl702, efr32, psoc6, telink)
Decreases (6 builds for efr32, esp32, k32w, nrfconnect)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…roject-chip#24346) * Fix factory data provider init * remove commented code * Add missing function to data provider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Platform Configuration Manager was initializing the generic configuration manager which would replace the platform manager
Test
Manual tests with different factory data