-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Chef] Support assigning product name when compiling Chef applications #24731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
January 30, 2023 14:30
pullapprove
bot
requested review from
vivien-apple,
woody-apple,
xylophone21 and
yufengwangca
January 30, 2023 14:30
PR #24731: Size comparison from 4f24db4 to 26e47c1 Increases (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (6 builds for cc13x2_26x2)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
reviewed
Jan 30, 2023
src/include/platform/internal/GenericConfigurationManagerImpl.ipp
Outdated
Show resolved
Hide resolved
PR #24731: Size comparison from 25df49b to 8084d13 Increases (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (6 builds for cc13x2_26x2)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
reviewed
Feb 2, 2023
src/include/platform/internal/GenericConfigurationManagerImpl.ipp
Outdated
Show resolved
Hide resolved
andy31415
approved these changes
Feb 2, 2023
PR #24731: Size comparison from 6b8e32e to 1348e67 Increases (50 builds for bl602, bl702, cc13x2_26x2, esp32, linux, mbed, nrfconnect, qpg, telink)
Decreases (6 builds for cc13x2_26x2)
Full report (50 builds for bl602, bl702, cc13x2_26x2, esp32, linux, mbed, nrfconnect, qpg, telink)
|
PR #24731: Size comparison from 17d7f00 to a169e46 Increases (39 builds for bl602, bl702, cc13x2_26x2, esp32, linux, mbed, nrfconnect, qpg, telink)
Decreases (6 builds for cc13x2_26x2)
Full report (39 builds for bl602, bl702, cc13x2_26x2, esp32, linux, mbed, nrfconnect, qpg, telink)
|
PR #24731: Size comparison from 344c1e3 to a9bc2ef Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
auto-merge was automatically disabled
February 11, 2023 08:08
Head branch was pushed to by a user without write access
PR #24731: Size comparison from 344c1e3 to 51273c9 Increases (2 builds for cc32xx, mbed)
Full report (2 builds for cc32xx, mbed)
|
Support assigning product name for chef applications. Now only linux, esp32, nrfconnect are supported
PR #24731: Size comparison from e03a286 to c95e203 Increases (4 builds for cc32xx, mbed, qpg)
Full report (4 builds for cc32xx, mbed, qpg)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
project-chip#24731) * Chef support assigning product name Support assigning product name for chef applications. Now only linux, esp32, nrfconnect are supported * Show verbose err text when get product name failed * Restyled by clang-format * Print "err.Format()" when get product name failed * [Chef] Fix type when printing error message --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support assigning product name for chef applications. Now only
linux
,esp32
,nrfconnect
are supportedProductName
attribute ofBasicInformation
cluster