Merge branch 'master' into master

examples/chip-tool/commands/common/RemoteDataModelLogger.cpp

@@ -144,6 +144,8 @@ CHIP_ERROR LogErrorAsJSON(const chip::app::EventHeader & header, const chip::app
 
 CHIP_ERROR LogErrorAsJSON(const CHIP_ERROR & error)
 {
+    VerifyOrReturnError(gDelegate != nullptr, CHIP_NO_ERROR);
+
     Json::Value value;
     chip::app::StatusIB status;
     status.InitFromChipError(error);

examples/java-matter-controller/java/src/com/matter/controller/Main.java

@@ -112,9 +112,6 @@ public static void main(String[] args) {
 
     try {
       commandManager.run(args);
-    } catch (IllegalArgumentException e) {
-      logger.log(Level.INFO, "Arguments init failed with exception: " + e.getMessage());
-      System.exit(1);
     } catch (Exception e) {
       logger.log(Level.INFO, "Run command failed with exception: " + e.getMessage());
       System.exit(1);

examples/java-matter-controller/java/src/com/matter/controller/commands/common/CommandManager.java

@@ -96,8 +96,14 @@ public final void run(String[] args) throws Exception {
     // need skip over binary and command name and only get arguments
     String[] temp = Arrays.copyOfRange(args, 2, args.length);
 
-    command.initArguments(temp.length, temp);
-    showCommand(args[0], command);
+    try {
+      command.initArguments(temp.length, temp);
+    } catch (IllegalArgumentException e) {
+      logger.log(Level.INFO, "Arguments init failed with exception: " + e.getMessage());
+      showCommand(args[0], command);
+      System.exit(1);
+    }
+
     command.run();
   }
 

scripts/py_matter_yamltests/matter_yamltests/constraints.py

@@ -32,7 +32,7 @@ def __init__(self, types: list, is_null_allowed: bool = False):
         self._types = types
         self._is_null_allowed = is_null_allowed
 
-    def is_met(self, value):
+    def is_met(self, value, value_type_name):
         if value is None:
             return self._is_null_allowed
 
@@ -43,10 +43,10 @@ def is_met(self, value):
             if not found_type_match:
                 return False
 
-        return self.check_response(value)
+        return self.check_response(value, value_type_name)
 
     @abstractmethod
-    def check_response(self, value) -> bool:
+    def check_response(self, value, value_type_name) -> bool:
         pass
 
 
@@ -55,13 +55,13 @@ def __init__(self, has_value):
         super().__init__(types=[])
         self._has_value = has_value
 
-    def is_met(self, value):
+    def is_met(self, value, value_type_name):
         # We are overriding the BaseConstraint of is_met since has value is a special case where
         # we might not be expecting a value at all, but the basic null check in BaseConstraint
         # is not what we want.
-        return self.check_response(value)
+        return self.check_response(value, value_type_name)
 
-    def check_response(self, value) -> bool:
+    def check_response(self, value, value_type_name) -> bool:
         has_value = value is not None
         return self._has_value == has_value
 
@@ -71,7 +71,7 @@ def __init__(self, type):
         super().__init__(types=[], is_null_allowed=True)
         self._type = type
 
-    def check_response(self, value) -> bool:
+    def check_response(self, value, value_type_name) -> bool:
         success = False
         if self._type == 'boolean' and type(value) is bool:
             success = True
@@ -195,6 +195,8 @@ def check_response(self, value) -> bool:
             success = value >= -36028797018963967 and value <= 36028797018963967
         elif self._type == 'nullable_int64s' and type(value) is int:
             success = value >= -9223372036854775807 and value <= 9223372036854775807
+        else:
+            success = self._type == value_type_name
         return success
 
 
@@ -203,7 +205,7 @@ def __init__(self, min_length):
         super().__init__(types=[str, bytes, list])
         self._min_length = min_length
 
-    def check_response(self, value) -> bool:
+    def check_response(self, value, value_type_name) -> bool:
         return len(value) >= self._min_length
 
 
@@ -212,7 +214,7 @@ def __init__(self, max_length):
         super().__init__(types=[str, bytes, list])
         self._max_length = max_length
 
-    def check_response(self, value) -> bool:
+    def check_response(self, value, value_type_name) -> bool:
         return len(value) <= self._max_length
 
 
@@ -221,7 +223,7 @@ def __init__(self, is_hex_string: bool):
         super().__init__(types=[str])
         self._is_hex_string = is_hex_string
 
-    def check_response(self, value) -> bool:
+    def check_response(self, value, value_type_name) -> bool:
         return all(c in string.hexdigits for c in value) == self._is_hex_string
 
 
@@ -230,7 +232,7 @@ def __init__(self, starts_with):
         super().__init__(types=[str])
         self._starts_with = starts_with
 
-    def check_response(self, value) -> bool:
+    def check_response(self, value, value_type_name) -> bool:
         return value.startswith(self._starts_with)
 
 
@@ -239,7 +241,7 @@ def __init__(self, ends_with):
         super().__init__(types=[str])
         self._ends_with = ends_with
 
-    def check_response(self, value) -> bool:
+    def check_response(self, value, value_type_name) -> bool:
         return value.endswith(self._ends_with)
 
 
@@ -248,7 +250,7 @@ def __init__(self, is_upper_case):
         super().__init__(types=[str])
         self._is_upper_case = is_upper_case
 
-    def check_response(self, value) -> bool:
+    def check_response(self, value, value_type_name) -> bool:
         return value.isupper() == self._is_upper_case
 
 
@@ -257,7 +259,7 @@ def __init__(self, is_lower_case):
         super().__init__(types=[str])
         self._is_lower_case = is_lower_case
 
-    def check_response(self, value) -> bool:
+    def check_response(self, value, value_type_name) -> bool:
         return value.islower() == self._is_lower_case
 
 
@@ -266,7 +268,7 @@ def __init__(self, min_value):
         super().__init__(types=[int, float], is_null_allowed=True)
         self._min_value = min_value
 
-    def check_response(self, value) -> bool:
+    def check_response(self, value, value_type_name) -> bool:
         return value >= self._min_value
 
 
@@ -275,7 +277,7 @@ def __init__(self, max_value):
         super().__init__(types=[int, float], is_null_allowed=True)
         self._max_value = max_value
 
-    def check_response(self, value) -> bool:
+    def check_response(self, value, value_type_name) -> bool:
         return value <= self._max_value
 
 
@@ -284,7 +286,7 @@ def __init__(self, contains):
         super().__init__(types=[list])
         self._contains = contains
 
-    def check_response(self, value) -> bool:
+    def check_response(self, value, value_type_name) -> bool:
         return set(self._contains).issubset(value)
 
 
@@ -293,7 +295,7 @@ def __init__(self, excludes):
         super().__init__(types=[list])
         self._excludes = excludes
 
-    def check_response(self, value) -> bool:
+    def check_response(self, value, value_type_name) -> bool:
         return set(self._excludes).isdisjoint(value)
 
 
@@ -302,7 +304,7 @@ def __init__(self, has_masks_set):
         super().__init__(types=[int])
         self._has_masks_set = has_masks_set
 
-    def check_response(self, value) -> bool:
+    def check_response(self, value, value_type_name) -> bool:
         return all([(value & mask) == mask for mask in self._has_masks_set])
 
 
@@ -311,7 +313,7 @@ def __init__(self, has_masks_clear):
         super().__init__(types=[int])
         self._has_masks_clear = has_masks_clear
 
-    def check_response(self, value) -> bool:
+    def check_response(self, value, value_type_name) -> bool:
         return all([(value & mask) == 0 for mask in self._has_masks_clear])
 
 
@@ -320,7 +322,7 @@ def __init__(self, not_value):
         super().__init__(types=[], is_null_allowed=True)
         self._not_value = not_value
 
-    def check_response(self, value) -> bool:
+    def check_response(self, value, value_type_name) -> bool:
         return value != self._not_value
 
 

scripts/py_matter_yamltests/matter_yamltests/parser.py

@@ -233,6 +233,7 @@ def __init__(self, test: dict, config: dict, definitions: SpecDefinitions, pics_
 
         argument_mapping = None
         response_mapping = None
+        response_mapping_name = None
 
         if self.is_attribute:
             attribute = definitions.get_attribute_by_name(
@@ -242,6 +243,7 @@ def __init__(self, test: dict, config: dict, definitions: SpecDefinitions, pics_
                                                      attribute.definition.data_type.name)
                 argument_mapping = attribute_mapping
                 response_mapping = attribute_mapping
+                response_mapping_name = attribute.definition.data_type.name
         else:
             command = definitions.get_command_by_name(
                 self.cluster, self.command)
@@ -250,9 +252,11 @@ def __init__(self, test: dict, config: dict, definitions: SpecDefinitions, pics_
                     definitions, self.cluster, command.input_param)
                 response_mapping = self._as_mapping(
                     definitions, self.cluster, command.output_param)
+                response_mapping_name = command.output_param
 
         self.argument_mapping = argument_mapping
         self.response_mapping = response_mapping
+        self.response_mapping_name = response_mapping_name
         self.update_arguments(self.arguments_with_placeholders)
         self.update_response(self.response_with_placeholders)
 
@@ -401,12 +405,13 @@ def __init__(self, test: _TestStepWithPlaceholders, runtime_config_variable_stor
         self._runtime_config_variable_storage = runtime_config_variable_storage
         self.arguments = copy.deepcopy(test.arguments_with_placeholders)
         self.response = copy.deepcopy(test.response_with_placeholders)
-        self._update_placeholder_values(self.arguments)
-        self._update_placeholder_values(self.response)
-        self._test.node_id = self._config_variable_substitution(
-            self._test.node_id)
-        test.update_arguments(self.arguments)
-        test.update_response(self.response)
+        if test.is_pics_enabled:
+            self._update_placeholder_values(self.arguments)
+            self._update_placeholder_values(self.response)
+            self._test.node_id = self._config_variable_substitution(
+                self._test.node_id)
+            test.update_arguments(self.arguments)
+            test.update_response(self.response)
 
     @property
     def is_enabled(self):
@@ -677,13 +682,16 @@ def _response_constraints_validation(self, response, result):
         error_success = 'Constraints check passed'
         error_failure = 'Constraints check failed'
 
+        response_type_name = self._test.response_mapping_name
         for value in self.response['values']:
             if 'constraints' not in value:
                 continue
 
             received_value = response.get('value')
             if not self.is_attribute:
                 expected_name = value.get('name')
+                response_type_name = self._test.response_mapping.get(
+                    expected_name)
                 if received_value is None or expected_name not in received_value:
                     received_value = None
                 else:
@@ -692,7 +700,7 @@ def _response_constraints_validation(self, response, result):
 
             constraints = get_constraints(value['constraints'])
 
-            if all([constraint.is_met(received_value) for constraint in constraints]):
+            if all([constraint.is_met(received_value, response_type_name) for constraint in constraints]):
                 result.success(check_type, error_success)
             else:
                 # TODO would be helpful to be more verbose here

scripts/tests/chiptest/__init__.py

@@ -88,7 +88,6 @@ def _GetManualTests() -> Set[ManualTest]:
     manualtests.add(ManualTest(yaml="Test_TC_MEDIAPLAYBACK_6_2.yaml", reason="TODO"))
     manualtests.add(ManualTest(yaml="Test_TC_MEDIAPLAYBACK_6_3.yaml", reason="TODO"))
     manualtests.add(ManualTest(yaml="Test_TC_MEDIAPLAYBACK_6_4.yaml", reason="TODO"))
-    manualtests.add(ManualTest(yaml="Test_TC_OO_2_4.yaml", reason="Flaky"))
     manualtests.add(ManualTest(yaml="Test_TC_PCC_2_1.yaml", reason="TODO"))
     manualtests.add(ManualTest(yaml="Test_TC_PS_2_1.yaml", reason="TODO"))
     manualtests.add(ManualTest(yaml="Test_TC_SC_5_1.yaml", reason="TODO"))
@@ -101,11 +100,15 @@ def _GetManualTests() -> Set[ManualTest]:
     manualtests.add(ManualTest(yaml="Test_TC_WNCV_2_5.yaml", reason="TODO"))
     manualtests.add(ManualTest(yaml="TestClusterMultiFabric.yaml", reason="TODO"))
     manualtests.add(ManualTest(yaml="TestCommissionerNodeId.yaml", reason="TODO"))
-    manualtests.add(ManualTest(yaml="TestDiscovery.yaml", reason="TODO"))
     manualtests.add(ManualTest(yaml="TestEvents.yaml", reason="TODO"))
     manualtests.add(ManualTest(yaml="TestGroupMessaging.yaml", reason="TODO"))
     manualtests.add(ManualTest(yaml="TestMultiAdmin.yaml", reason="TODO"))
 
+    # Failing, unclear why. Likely repl specific, used to pass however first
+    # failure point seems unrelated. Historically this seems (very?) flaky
+    # in repl.
+    manualtests.add(ManualTest(yaml="Test_TC_OO_2_4.yaml", reason="Flaky"))
+
     # Examples:
     #
     # Currently these are not in ciTests.json, however yaml logic currently
@@ -114,8 +117,7 @@ def _GetManualTests() -> Set[ManualTest]:
     # This is on purpose for now to make it harder to orphan files, however
     # we can reconsider as things evolve.
     manualtests.add(ManualTest(yaml="Config_Example.yaml", reason="Example"))
-    manualtests.add(ManualTest(
-        yaml="Config_Variables_Example.yaml", reason="Example"))
+    manualtests.add(ManualTest(yaml="Config_Variables_Example.yaml", reason="Example"))
     manualtests.add(ManualTest(yaml="PICS_Example.yaml", reason="Example"))
     manualtests.add(ManualTest(yaml="Response_Example.yaml", reason="Example"))
     manualtests.add(ManualTest(yaml="Test_Example.yaml", reason="Example"))

scripts/tests/chiptest/yamltest_with_chip_repl_tester.py

@@ -15,6 +15,7 @@
 #    limitations under the License.
 
 import atexit
+import logging
 import os
 import tempfile
 import traceback
@@ -32,7 +33,7 @@
 from chip.ChipStack import *
 from chip.yaml.runner import ReplTestRunner
 from matter_yamltests.definitions import SpecDefinitionsFromPaths
-from matter_yamltests.parser import TestParser
+from matter_yamltests.parser import PostProcessCheckStatus, TestParser
 
 _DEFAULT_CHIP_ROOT = os.path.abspath(
     os.path.join(os.path.dirname(__file__), "..", "..", ".."))
@@ -118,6 +119,11 @@ def _StackShutDown():
                 post_processing_result = test_step.post_process_response(
                     decoded_response)
                 if not post_processing_result.is_success():
+                    logging.warning(f"Test step failure in 'test_step.label'")
+                    for entry in post_processing_result.entries:
+                        if entry.state == PostProcessCheckStatus.SUCCESS:
+                            continue
+                        logging.warning("%s: %s", entry.state, entry.message)
                     raise Exception(f'Test step failed {test_step.label}')
         except Exception:
             print(traceback.format_exc())

src/app/clusters/door-lock-server/door-lock-server-callback.cpp

@@ -195,3 +195,39 @@ emberAfPluginDoorLockSetSchedule(chip::EndpointId endpointId, uint8_t holidayInd
 void __attribute__((weak))
 emberAfPluginDoorLockLockoutStarted(chip::EndpointId endpointId, chip::System::Clock::Timestamp lockoutEndTime)
 {}
+
+bool __attribute__((weak))
+emberAfPluginDoorLockGetNumberOfFingerprintCredentialsSupported(chip::EndpointId endpointId, uint16_t & maxNumberOfCredentials)
+{
+    return false;
+}
+
+bool __attribute__((weak))
+emberAfPluginDoorLockGetNumberOfFingerVeinCredentialsSupported(chip::EndpointId endpointId, uint16_t & maxNumberOfCredentials)
+{
+    return false;
+}
+
+bool __attribute__((weak))
+emberAfPluginDoorLockGetNumberOfFaceCredentialsSupported(chip::EndpointId endpointId, uint16_t & maxNumberOfCredentials)
+{
+    return false;
+}
+
+bool __attribute__((weak))
+emberAfPluginDoorLockGetFingerprintCredentialLengthConstraints(chip::EndpointId endpointId, uint8_t & minLen, uint8_t & maxLen)
+{
+    return false;
+}
+
+bool __attribute__((weak))
+emberAfPluginDoorLockGetFingerVeinCredentialLengthConstraints(chip::EndpointId endpointId, uint8_t & minLen, uint8_t & maxLen)
+{
+    return false;
+}
+
+bool __attribute__((weak))
+emberAfPluginDoorLockGetFaceCredentialLengthConstraints(chip::EndpointId endpointId, uint8_t & minLen, uint8_t & maxLen)
+{
+    return false;
+}