Remove zap checkout for darwin builds in CI, assume CIPD provides this #24677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s. If this works, we can work on modifying the dockerfiles for linux too
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mrjerryjohns and
msandstedt
pullapprove
bot
requested review from
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
|
Zap-cli may actually just work. It is the zaptool that is more tricky and requires We will probably have to figure out how to make the tool work with CIPD. |
|
PR #24677: Size comparison from 33ce048 to e513252 Increases (5 builds for cc13x2_26x2, nrfconnect, telink)
Decreases (12 builds for bl602, bl702, cc13x2_26x2, esp32, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jan 28, 2023
|
PR #24677: Size comparison from 7e69c66 to 7627a64 Increases (5 builds for bl602, bl702, psoc6, telink)
Decreases (4 builds for bl602, esp32, qpg, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
project-chip#24677) * Remove zap checkout for darwin builds in CI, assume CIPD provides this. If this works, we can work on modifying the dockerfiles for linux too * Make zap-cli NOT available for xcodebuild * Add --version to zap-cli to not try to run more things * The zap test should be under the build environment, to get the path working * Run in build environment when checking for zap --------- Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #24630 , CIPD contains zap for both linux and mac.
Since mac CI was always trying to self-download zap, updating the logic here.
This may need some tweaks however, as zap-cli for mac may require a different sub-path. This PR is to try things out.