-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add zap to CIPD setup #24630
Add zap to CIPD setup #24630
Conversation
This makes the tool available for running the tests.
PR #24630: Size comparison from 7299a2a to 637a57b Increases (1 build for qpg)
Decreases (8 builds for bl602, bl702, psoc6, telink)
Full report (41 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this will be hard to maintain - this would require a fucsia push whenever we want zap updates and unless we get more permissions to do that (i.e. beyond fucsia team) it is probably not something we can manage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved: had offline chat about this - CIPD is automated to get the latest release of zap within 4 hours ... this seems to actually speed up our development cycle because we stop requiring a separate docker file.
Remove arm64 version, since the prebuilt zap-linux is for amd64 only.
@andy31415 I updated the zap update script, but will leave any Dockerfile and documentation updates to you. |
PR #24630: Size comparison from 2ce5f2d to 658f144 Increases (8 builds for bl602, bl702, cyw30739, psoc6, telink)
Decreases (8 builds for cc13x2_26x2, efr32, esp32, psoc6, telink)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
I believe the only blocker is that I need approval from another reviewer. @bzbarsky-apple could you approve (assuming I've addressed your concerns!)? |
PR #24630: Size comparison from 89a9007 to d76f678 Increases (6 builds for bl702, cc13x2_26x2, k32w, nrfconnect, psoc6, qpg)
Decreases (11 builds for bl602, cc13x2_26x2, cyw30739, esp32, psoc6, qpg, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
* Add zap to CIPD setup This makes the tool available for running the tests. * Add to zap version update script Remove arm64 version, since the prebuilt zap-linux is for amd64 only. Co-authored-by: Boris Zbarsky <[email protected]>
This makes the tool available for running the tests in CI.
@andreilitvin