-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old general commands in src/app/zap-templates/zcl/data-model/s… #24672
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
vivien-apple:RemoveOldZclGeneralCommands
Jan 27, 2023
Merged
Remove old general commands in src/app/zap-templates/zcl/data-model/s… #24672
bzbarsky-apple
merged 1 commit into
project-chip:master
from
vivien-apple:RemoveOldZclGeneralCommands
Jan 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilabs/general.xml
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mlepage-google
January 26, 2023 20:33
pullapprove
bot
requested review from
mrjerryjohns,
msandstedt,
mspang,
pjzander-signify,
rgoliver,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
woody-apple,
xylophone21 and
yufengwangca
January 26, 2023 20:33
heh ... had #24676 to ignore these in the parser. Removing is also good I think! |
andy31415
approved these changes
Jan 26, 2023
PR #24672: Size comparison from 86b064d to 21389fc Increases (13 builds for bl602, bl702, cc13x2_26x2, cyw30739, k32w, nrfconnect, psoc6, telink)
Decreases (8 builds for cc13x2_26x2, esp32, k32w, psoc6, qpg, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jan 27, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ilabs/general.xml
Problem
General commands (zcl commands basically) has been removed since a while. This is just noise in the xml files.